From: Nicolas Petton <nicolas@petton.fr>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master c13a4df: Remove the calls to `seq-into` from `seq-concatenate`
Date: Tue, 25 Aug 2015 10:32:46 +0200 [thread overview]
Message-ID: <878u8zahu9.fsf@petton.fr> (raw)
In-Reply-To: <jwv37z8try1.fsf-monnier+emacsdiffs@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 703 bytes --]
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>>> I don't understand this change. Can't it cause two CL-structs to be
>>> vconcat'd together, which wouldn't make much sense?
>> The previous version of `seq-concatenate' did not prevent that, since
>> CL-structs are vectors, thus sequences, and the function was using
>> `sequencep' to determine if the seq had to be converted or not.
>
> Indeed, but if we intend to work for new "sequence" types defined via
> CL-struct, that's still a problem.
Yes, it is still a problem. One solution would be to test if the seq is
a cl-struct with, in which case we could use `seq-into'. But then that
would only fix the cl-struct case, not any other.
Nico
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 512 bytes --]
next prev parent reply other threads:[~2015-08-25 8:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150823191413.17383.23210@vcs.savannah.gnu.org>
[not found] ` <E1ZTaib-0004Wz-Ih@vcs.savannah.gnu.org>
2015-08-24 13:37 ` [Emacs-diffs] master c13a4df: Remove the calls to `seq-into` from `seq-concatenate` Stefan Monnier
2015-08-24 13:51 ` Nicolas Petton
2015-08-24 19:23 ` Stefan Monnier
2015-08-25 8:32 ` Nicolas Petton [this message]
2015-08-25 14:30 ` Stefan Monnier
2015-08-25 14:48 ` Nicolas Petton
2015-08-25 21:52 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878u8zahu9.fsf@petton.fr \
--to=nicolas@petton.fr \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.