From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: phillip.lord@russet.org.uk (Phillip Lord) Newsgroups: gmane.emacs.devel Subject: why does make check run all tests? Date: Wed, 02 Dec 2015 12:12:04 +0000 Message-ID: <878u5dcanf.fsf@russet.org.uk> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1449058377 9738 80.91.229.3 (2 Dec 2015 12:12:57 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 2 Dec 2015 12:12:57 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Dec 02 13:12:52 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a46HE-0006qQ-J7 for ged-emacs-devel@m.gmane.org; Wed, 02 Dec 2015 13:12:52 +0100 Original-Received: from localhost ([::1]:57690 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a46HD-00072p-Ta for ged-emacs-devel@m.gmane.org; Wed, 02 Dec 2015 07:12:51 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42493) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a46GX-0006RZ-OT for emacs-devel@gnu.org; Wed, 02 Dec 2015 07:12:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a46GT-0005P3-K9 for emacs-devel@gnu.org; Wed, 02 Dec 2015 07:12:09 -0500 Original-Received: from cheviot12.ncl.ac.uk ([128.240.234.12]:60807) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a46GT-0005Oz-Ee for emacs-devel@gnu.org; Wed, 02 Dec 2015 07:12:05 -0500 Original-Received: from smtpauth-vm.ncl.ac.uk ([10.8.233.129] helo=smtpauth.ncl.ac.uk) by cheviot12.ncl.ac.uk with esmtp (Exim 4.63) (envelope-from ) id 1a46GS-0008Iz-Bx for emacs-devel@gnu.org; Wed, 02 Dec 2015 12:12:04 +0000 Original-Received: from jangai.ncl.ac.uk ([10.66.67.223] helo=localhost) by smtpauth.ncl.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63) (envelope-from ) id 1a46GS-0006F8-Ih for emacs-devel@gnu.org; Wed, 02 Dec 2015 12:12:04 +0000 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 128.240.234.12 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:195736 Archived-At: I've been looking through the Makefile for the test directory. Currently, the check target says this. ## Re-run all the tests every time. check: -@for f in *.log; do test ! -f $$f || mv $$f $$f~; done @${MAKE} check-maybe I realised last night, that my recent changes have actually broken this (check is now incremental). This to me seems to be a good thing (although it was accidental). Why should check run all tests everytime? Especially now that I have added dependencies between tests and source (so, if you change abbrevs.el, then abbrevs-test.el will get run). Should make check just not build incrementally? If you want to run everything unconditionally, then why not use make clean check Or am I missing something obvious? In which case, I will need to restore the old behaviour for make check and leave make check-maybe as is. Phil