From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#20032: eww: access bookmarks right from the URI prompt Date: Fri, 25 Dec 2015 07:35:16 +0100 Message-ID: <878u4jdoij.fsf@gnus.org> References: <87fv9gzj4e.fsf@violet.siamics.net> <878uf7zsya.fsf@violet.siamics.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1451025382 27620 80.91.229.3 (25 Dec 2015 06:36:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 25 Dec 2015 06:36:22 +0000 (UTC) Cc: 20032@debbugs.gnu.org To: Ivan Shmakov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Dec 25 07:36:11 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aCLz0-0008Mc-FX for geb-bug-gnu-emacs@m.gmane.org; Fri, 25 Dec 2015 07:36:10 +0100 Original-Received: from localhost ([::1]:34423 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aCLyz-0006DQ-O4 for geb-bug-gnu-emacs@m.gmane.org; Fri, 25 Dec 2015 01:36:09 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53769) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aCLyw-0006DI-47 for bug-gnu-emacs@gnu.org; Fri, 25 Dec 2015 01:36:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aCLys-0007XP-T4 for bug-gnu-emacs@gnu.org; Fri, 25 Dec 2015 01:36:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:54763) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aCLys-0007XL-PC for bug-gnu-emacs@gnu.org; Fri, 25 Dec 2015 01:36:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aCLys-0002xm-Df for bug-gnu-emacs@gnu.org; Fri, 25 Dec 2015 01:36:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 25 Dec 2015 06:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20032 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 20032-submit@debbugs.gnu.org id=B20032.145102533911360 (code B ref 20032); Fri, 25 Dec 2015 06:36:02 +0000 Original-Received: (at 20032) by debbugs.gnu.org; 25 Dec 2015 06:35:39 +0000 Original-Received: from localhost ([127.0.0.1]:34132 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aCLyV-0002xA-Jd for submit@debbugs.gnu.org; Fri, 25 Dec 2015 01:35:39 -0500 Original-Received: from hermes.netfonds.no ([80.91.224.195]:40606) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aCLyU-0002x2-4F for 20032@debbugs.gnu.org; Fri, 25 Dec 2015 01:35:38 -0500 Original-Received: from 2.150.58.24.tmi.telenormobil.no ([2.150.58.24] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aCLy8-0002Xb-Q3; Fri, 25 Dec 2015 07:35:16 +0100 In-Reply-To: <878uf7zsya.fsf@violet.siamics.net> (Ivan Shmakov's message of "Sun, 08 Mar 2015 10:25:49 +0000") User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.1.50 (gnu/linux) X-MailScanner-ID: 1aCLy8-0002Xb-Q3 MailScanner-NULL-Check: 1451630117.41171@//eZ7AWuIul3oEh9PNXuZA X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:110367 Archived-At: Ivan Shmakov writes: > Please consider the revised patch MIMEd. > > * lisp/net/eww.el (eww-suggest-uris): Add eww-suggest-bookmarks > to the default value and :options. (Bug#20032) > (eww-suggested-bookmarks-annotation): New customizable variable. > (eww-suggest-bookmarks, eww-remove-annotation) > (eww-substring-nil-property): New functions. > (eww-suggested-uris, eww): Use eww-remove-annotation. I get a compilation warning after applying the patch... (The defvar for eww-bookmarks should be moved.) But conceptually I'm not sure this is a good idea. If you have a bookmarks file, then if you say `M-x eww', you will apparently default to the first entry in the bookmarks file? That doesn't seem very helpful. It would be OK to have that as the first entry in the `M-n' history, but not as the default. If I read the code correctly. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no