From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#22493: 25.1.50; open-gnutls-stream doesn't respect :nowait, so the connections are synchronous Date: Sat, 30 Jan 2016 05:45:21 +0100 Message-ID: <878u37zndq.fsf@gnus.org> References: <87mvrnzpge.fsf@gnus.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1454129204 14674 80.91.229.3 (30 Jan 2016 04:46:44 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 30 Jan 2016 04:46:44 +0000 (UTC) To: 22493@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jan 30 05:46:33 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aPNQH-0000Ni-PW for geb-bug-gnu-emacs@m.gmane.org; Sat, 30 Jan 2016 05:46:10 +0100 Original-Received: from localhost ([::1]:37565 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aPNQG-0005wI-UA for geb-bug-gnu-emacs@m.gmane.org; Fri, 29 Jan 2016 23:46:08 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55863) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aPNQD-0005vs-Bj for bug-gnu-emacs@gnu.org; Fri, 29 Jan 2016 23:46:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aPNQA-0001UP-4U for bug-gnu-emacs@gnu.org; Fri, 29 Jan 2016 23:46:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:52717) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aPNQA-0001Tv-0g for bug-gnu-emacs@gnu.org; Fri, 29 Jan 2016 23:46:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aPNQ9-0001Yp-N3 for bug-gnu-emacs@gnu.org; Fri, 29 Jan 2016 23:46:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 30 Jan 2016 04:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22493 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 22493-submit@debbugs.gnu.org id=B22493.14541291555984 (code B ref 22493); Sat, 30 Jan 2016 04:46:01 +0000 Original-Received: (at 22493) by debbugs.gnu.org; 30 Jan 2016 04:45:55 +0000 Original-Received: from localhost ([127.0.0.1]:40937 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aPNQ3-0001YS-BO for submit@debbugs.gnu.org; Fri, 29 Jan 2016 23:45:55 -0500 Original-Received: from hermes.netfonds.no ([80.91.224.195]:53218) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aPNQ1-0001YJ-GO for 22493@debbugs.gnu.org; Fri, 29 Jan 2016 23:45:54 -0500 Original-Received: from cpe-60-225-211-161.nsw.bigpond.net.au ([60.225.211.161] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aPNPb-00018e-MF for 22493@debbugs.gnu.org; Sat, 30 Jan 2016 05:45:29 +0100 In-Reply-To: <87mvrnzpge.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 30 Jan 2016 05:00:33 +0100") User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.1.50 (gnu/linux) X-MailScanner-ID: 1aPNPb-00018e-MF MailScanner-NULL-Check: 1454733929.49399@MY4T96fpxhqCkjXOJPBjYw X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:112096 Archived-At: Looking at the code, and doing some experimentation, it looks like this should be possible to implement. First of all, gnutls-open-stream should call open-network-stream with :nowait, and put a sentinel on the stream to see when it's opened, and then it should call gnutls-negotiate from the sentinel. The problem is, though, that the process isn't marked as a gnutls process until gnutls_boot is called, so this needs to happen much earlier. Possibly by adding another keyword to make-network-process that just sets XPROCESS (proc)->gnutls_p = 1; The other problem is that reading/writing from these things will just send plain text if the gnutls stuff hasn't been initialised: #ifdef HAVE_GNUTLS if (p->gnutls_p && p->gnutls_state) written = emacs_gnutls_write (p, cur_buf, cur_len); else #endif written = emacs_write_sig (outfd, cur_buf, cur_len); I think that looks rather nonsensical. If it's p->gnutls_p, then it should never write to the process, no matter what the state is. Rather is should just skip writing until p->gnutls_state gets set (which happens during gnutls_boot). Or is there something subtle here I'm missing? When would we ever want to write plain text to something that's p->gnutls_p? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no