From: Juri Linkov <juri@jurta.org>
To: martin rudalics <rudalics@gmx.at>
Cc: "N. Jackson" <nljlistbox2@gmail.com>, 23092@debbugs.gnu.org
Subject: bug#23092: 25.0.92; Minibuffer completion fails to resize completion window if reused during same command
Date: Wed, 23 Mar 2016 23:27:18 +0200 [thread overview]
Message-ID: <878u18x4um.fsf@mail.linkov.net> (raw)
In-Reply-To: <56F2E647.7040400@gmx.at> (martin rudalics's message of "Wed, 23 Mar 2016 19:53:59 +0100")
>> But in the case of completion of a file path, this assumption is not
>> valid. (And completing each directory name down a file path is a
>> perfectly normal use case.) The difference is that one is not doing a
>> single completion but several discrete completions.
>
> I'm not sure whether we should by default change something in this case.
> Juri has designed the present concept and I would rather leave it to him
> how to proceed.
I noticed this deficiency, but failed to properly fix it earlier,
because it's only you who completely understands all the intricacies
of window-displaying machinery ;-)
However, after I looked at this again now, it looks natural to just
replace ‘shrink-window-if-larger-than-buffer’ with ‘fit-window-to-buffer’.
But I'd leave it to you to decide how good this change is and what
consequences it might entail.
diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el
index ecac0ae..6540059 100644
--- a/lisp/minibuffer.el
+++ b/lisp/minibuffer.el
@@ -1835,7 +1835,7 @@ minibuffer-completion-help
'display-buffer-below-selected))
,(if temp-buffer-resize-mode
'(window-height . resize-temp-buffer-window)
- '(window-height . shrink-window-if-larger-than-buffer))
+ '(window-height . fit-window-to-buffer))
,(when temp-buffer-resize-mode
'(preserve-size . (nil . t))))
nil
next prev parent reply other threads:[~2016-03-23 21:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-22 17:07 bug#23092: 25.0.92; Minibuffer completion fails to resize completion window if reused during same command N. Jackson
2016-03-22 17:21 ` martin rudalics
2016-03-22 18:42 ` N. Jackson
2016-03-22 18:53 ` martin rudalics
2016-03-22 19:56 ` N. Jackson
2016-03-22 20:10 ` Eli Zaretskii
2016-03-22 21:06 ` N. Jackson
2016-03-22 18:28 ` Eli Zaretskii
2016-03-22 18:55 ` N. Jackson
2016-03-22 19:04 ` Eli Zaretskii
2016-03-22 20:07 ` N. Jackson
2016-03-23 8:09 ` martin rudalics
2016-03-23 16:45 ` N. Jackson
2016-03-23 18:53 ` martin rudalics
2016-03-23 20:34 ` N. Jackson
2016-03-23 21:27 ` Juri Linkov [this message]
2016-03-24 7:43 ` martin rudalics
2016-03-24 22:14 ` Juri Linkov
2016-03-25 7:42 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878u18x4um.fsf@mail.linkov.net \
--to=juri@jurta.org \
--cc=23092@debbugs.gnu.org \
--cc=nljlistbox2@gmail.com \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.