From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: phillip.lord@russet.org.uk (Phillip Lord) Newsgroups: gmane.emacs.bugs Subject: bug#22295: viper-mode undo bug introduced between Nov 10 and Nov 14 Date: Mon, 16 May 2016 13:41:17 +0100 Message-ID: <878tzatbte.fsf@russet.org.uk> References: <83vb2h6lfq.fsf@gnu.org> <83r3d56jrg.fsf@gnu.org> <87poso7nf5.fsf@russet.org.uk> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1463402631 14737 80.91.229.3 (16 May 2016 12:43:51 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 16 May 2016 12:43:51 +0000 (UTC) Cc: 22295@debbugs.gnu.org, Michael Kifer To: Jim Meyering Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon May 16 14:43:38 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1b2Hri-0000es-2q for geb-bug-gnu-emacs@m.gmane.org; Mon, 16 May 2016 14:43:18 +0200 Original-Received: from localhost ([::1]:43713 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b2Hrh-0001z4-A7 for geb-bug-gnu-emacs@m.gmane.org; Mon, 16 May 2016 08:43:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48261) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b2HrZ-0001pF-RO for bug-gnu-emacs@gnu.org; Mon, 16 May 2016 08:43:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b2HrU-0004FF-5D for bug-gnu-emacs@gnu.org; Mon, 16 May 2016 08:43:09 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41033) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b2HrU-0004F1-1i for bug-gnu-emacs@gnu.org; Mon, 16 May 2016 08:43:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1b2HrS-0003IX-OK for bug-gnu-emacs@gnu.org; Mon, 16 May 2016 08:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: phillip.lord@russet.org.uk (Phillip Lord) Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 16 May 2016 12:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22295 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 22295-submit@debbugs.gnu.org id=B22295.146340254712625 (code B ref 22295); Mon, 16 May 2016 12:43:02 +0000 Original-Received: (at 22295) by debbugs.gnu.org; 16 May 2016 12:42:27 +0000 Original-Received: from localhost ([127.0.0.1]:53369 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b2Hqs-0003HZ-Ro for submit@debbugs.gnu.org; Mon, 16 May 2016 08:42:27 -0400 Original-Received: from cloud103.planethippo.com ([31.216.48.48]:45643) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b2Hqm-0003H5-0V for 22295@debbugs.gnu.org; Mon, 16 May 2016 08:42:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=russet.org.uk; s=default; h=Content-Type:MIME-Version:References:Message-ID :Date:In-Reply-To:Subject:Cc:To:From; bh=QfeAlFPdXf3r40z5dqQF+fZgmfEs94322hB11hHU9bg=; b=kyLity3364XUxpKGGnrKffEvKQ M05llXHIgD+Ow7cjNOihvpQNHb+jLUvOcnzUYvuwJK23sbTlB22ctM7GgmrUz8u4qYOGdDwrlbCZa Ihazl4CsApsj5AiPY21wVyorno4miXLM2ZRyywp8M9cSYhImXz4fmTTBQ7wg+3fyfooGZvd54NA/L TV6U/eEk803R9q4kRTYrFNma8BviT1c3/mzaGj8csm0sW/mF/c7Evb11V3/3bUYEIjQqSYsZAqvkB B7mc+6rbDc4DgWygVk5RC5am0EHjH2FjICSoOcFrfj2cHRjSw8oo88Cykt3EBH3nZ4AXe5bgtE3Ge l7qZfc8w==; Original-Received: from janus-nat-128-240-225-60.ncl.ac.uk ([128.240.225.60]:33415 helo=russet.org.uk) by cloud103.planethippo.com with esmtpsa (TLSv1.2:DHE-RSA-AES128-SHA:128) (Exim 4.86_1) (envelope-from ) id 1b2Hqg-001Tzo-0L; Mon, 16 May 2016 13:42:14 +0100 In-Reply-To: (Jim Meyering's message of "Sun, 15 May 2016 19:31:56 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.93 (gnu/linux) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cloud103.planethippo.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - russet.org.uk X-Get-Message-Sender-Via: cloud103.planethippo.com: authenticated_id: phillip.lord@russet.org.uk X-Authenticated-Sender: cloud103.planethippo.com: phillip.lord@russet.org.uk X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:118281 Archived-At: Jim Meyering writes: >> Sorry for slow response -- was travelling. >> >> Yep, viper is doing strange things to undo -- it adds a symbol ('viper) >> to the undo list, then removes it later, amalgamating everything upto >> 'viper. >> >> I've got a complete test case (below in case anyone is interested -- >> I'll make a proper unit test of it on master eventually). > > Thank you for working on this. My fingers seem to have developed a > serious dependence on viper-mode over the last two decades. > I don't want to retrain them :-) It's okay. I don't want Eli forwarding bug reports once emacs-25 comes out! I have pushed a first attempt at a fix to branch fix/viper-undo. Clearly, it's not finished yet, but I'd like to get your feedback as to whether it works; it should fix the example given, but I haven't used viper at all, so if it breaks other things I won't know. I haven't managed to work out exactly why the error is happening -- probably though because the timing of the undo-boundary is somewhat different, though. With this fix, viper just disables automatic boundary addition and adds it's own as necessary, which seems cleaner. Phil