From: Tino Calancha <tino.calancha@gmail.com>
To: 24987@debbugs.gnu.org
Subject: bug#24987: 26.0.50; ibuffer-unmark-backward doesn't unmark the region
Date: Wed, 23 Nov 2016 00:49:06 +0900 [thread overview]
Message-ID: <878tsba51p.fsf@gmail.com> (raw)
Severity: wishlist
It would be more consistent if `ibuffer-unmark-backward' unmark
the region when is active, as other Emacs commands do.
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
From f6d724eb43b01cd08f8bf12398491704e28a21bd Mon Sep 17 00:00:00 2001
From: Tino Calancha <tino.calancha@gmail.com>
Date: Wed, 23 Nov 2016 00:29:00 +0900
Subject: [PATCH] ibuffer-unmark-backward: Unmark the region when is active
* lisp/ibuffer.el (ibuffer-unmark-backward):
Use 'ibuffer-get-region-and-prefix'; call 'ibuffer-unmark-forward'
with the region boundary as the first 2 arguments.
---
lisp/ibuffer.el | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/lisp/ibuffer.el b/lisp/ibuffer.el
index dc5681c..fe0873a 100644
--- a/lisp/ibuffer.el
+++ b/lisp/ibuffer.el
@@ -1427,11 +1427,11 @@ ibuffer-unmark-forward
(interactive (ibuffer-get-region-and-prefix))
(ibuffer-mark-region-or-n-with-char start end arg ?\s))
-(defun ibuffer-unmark-backward (arg)
- "Unmark the ARG previous buffers.
+(defun ibuffer-unmark-backward (start end arg)
+ "Unmark the buffers in the region, or previous ARG buffers.
If point is on a group name, this function operates on that group."
- (interactive "p")
- (ibuffer-unmark-forward nil nil (- arg)))
+ (interactive (ibuffer-get-region-and-prefix))
+ (ibuffer-unmark-forward start end (- arg)))
(defun ibuffer-mark-region-or-n-with-char (start end arg mark-char)
(if (use-region-p)
--
2.10.2
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
In GNU Emacs 26.0.50.1 (x86_64-pc-linux-gnu, GTK+ Version 3.22.3)
of 2016-11-23
Repository revision: afe2997119a5e6b108851f2e236037da1d4acef2
next reply other threads:[~2016-11-22 15:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-22 15:49 Tino Calancha [this message]
2016-12-07 12:39 ` bug#24987: 26.0.50; ibuffer-unmark-backward doesn't unmark the region Tino Calancha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878tsba51p.fsf@gmail.com \
--to=tino.calancha@gmail.com \
--cc=24987@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.