all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Chris Gregory <czipperz@gmail.com>
Subject: (unknown)
Date: Wed, 28 Dec 2016 01:15:01 -0600	[thread overview]
Message-ID: <878tr0le2y.fsf@gmail.com> (raw)

Here is another patch that does more of this.
-- 
Chris Gregory

diff --git a/src/eval.c b/src/eval.c
index e50e26a..9e1d612 100644
--- a/src/eval.c
+++ b/src/eval.c
@@ -1313,20 +1313,12 @@ internal_condition_case (Lisp_Object (*bfun) (void), Lisp_Object handlers,
 			 Lisp_Object (*hfun) (Lisp_Object))
 {
   struct handler *c = push_handler (handlers, CONDITION_CASE);
-  if (sys_setjmp (c->jmp))
-    {
-      Lisp_Object val = handlerlist->val;
-      clobbered_eassert (handlerlist == c);
-      handlerlist = handlerlist->next;
-      return hfun (val);
-    }
-  else
-    {
-      Lisp_Object val = bfun ();
-      clobbered_eassert (handlerlist == c);
-      handlerlist = handlerlist->next;
-      return val;
-    }
+  bool is_returning = sys_setjmp (c->jmp);
+  Lisp_Object val = is_returning ? handlerlist->val : bfun ();
+
+  clobbered_eassert (handlerlist == c);
+  handlerlist = handlerlist->next;
+  return is_returning ? hfun (val) : val;
 }
 
 /* Like internal_condition_case but call BFUN with ARG as its argument.  */
@@ -1364,20 +1356,12 @@ internal_condition_case_2 (Lisp_Object (*bfun) (Lisp_Object, Lisp_Object),
 			   Lisp_Object (*hfun) (Lisp_Object))
 {
   struct handler *c = push_handler (handlers, CONDITION_CASE);
-  if (sys_setjmp (c->jmp))
-    {
-      Lisp_Object val = handlerlist->val;
-      clobbered_eassert (handlerlist == c);
-      handlerlist = handlerlist->next;
-      return hfun (val);
-    }
-  else
-    {
-      Lisp_Object val = bfun (arg1, arg2);
-      clobbered_eassert (handlerlist == c);
-      handlerlist = handlerlist->next;
-      return val;
-    }
+  bool is_returning = sys_setjmp (c->jmp);
+  Lisp_Object val = is_returning ? handlerlist->val : bfun (arg1, arg2);
+
+  clobbered_eassert (handlerlist == c);
+  handlerlist = handlerlist->next;
+  return is_returning ? hfun (val) : val;
 }
 
 /* Like internal_condition_case but call BFUN with NARGS as first,
@@ -1393,20 +1377,12 @@ internal_condition_case_n (Lisp_Object (*bfun) (ptrdiff_t, Lisp_Object *),
 						Lisp_Object *args))
 {
   struct handler *c = push_handler (handlers, CONDITION_CASE);
-  if (sys_setjmp (c->jmp))
-    {
-      Lisp_Object val = handlerlist->val;
-      clobbered_eassert (handlerlist == c);
-      handlerlist = handlerlist->next;
-      return hfun (val, nargs, args);
-    }
-  else
-    {
-      Lisp_Object val = bfun (nargs, args);
-      clobbered_eassert (handlerlist == c);
-      handlerlist = handlerlist->next;
-      return val;
-    }
+  bool is_returning = sys_setjmp (c->jmp);
+  Lisp_Object val = is_returning ? handlerlist->val : bfun (nargs, args);
+
+  clobbered_eassert (handlerlist == c);
+  handlerlist = handlerlist->next;
+  return is_returning ? hfun (val, nargs, args) : val;
 }
 
 struct handler *



             reply	other threads:[~2016-12-28  7:15 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-28  7:15 Chris Gregory [this message]
2016-12-28  8:58 ` (unknown) Andreas Schwab
  -- strict thread matches above, loose matches on Subject: below --
2024-05-21  2:03 (unknown) Tennyson Bardwell
2024-03-13 12:48 (unknown) Eli Zaretskii
2023-11-18  3:13 (unknown) Greg Minshall
2023-11-18  7:05 ` (unknown) Jim Porter
2023-03-13  6:32 (unknown) Pedro Andres Aranda Gutierrez
2023-03-13  6:18 (unknown) Pedro Andres Aranda Gutierrez
2023-02-11 20:24 (unknown) cheyrn via Users list for the GNU Emacs text editor
2022-10-03  6:30 (unknown) Pedro Andres Aranda Gutierrez
2022-07-21 11:36 (unknown) Gregory Heytings
2022-07-09 13:53 (unknown) Lorenzo Isella
2022-07-09 15:06 ` (unknown) Óscar Fuentes
2022-05-29  6:06 (unknown) Pedro Andres Aranda Gutierrez
2022-02-17 19:24 (unknown) hput
2022-02-17 20:03 ` (unknown) Stefan Monnier via Users list for the GNU Emacs text editor
2021-12-20  2:29 (unknown) Davin Pearson
2021-08-23 18:37 (unknown) telegraph
2021-08-23 18:36 (unknown) telegraph
2021-07-27 23:54 (unknown) Troy Hinckley
2021-06-06  8:06 (unknown) Sai Karthik
2021-05-07 12:51 (unknown) Eric Skoglund
2021-05-07 14:40 ` (unknown) Bastien
2020-09-06  7:04 (unknown) Ag Ibragimov
2020-03-15 22:42 (unknown) Arne Babenhauserheide
2019-10-18  2:46 (unknown) Justin Barclay
2019-05-02  0:36 (unknown) Budi
2019-05-02  0:40 ` (unknown) Óscar Fuentes
2018-04-09 23:58 (unknown) siraben
2017-08-30 19:33 (unknown) Mark Oteiza
2017-04-07 23:43 Understanding how to specify UTF-8 Will Parsons
2017-04-13  5:09 ` B. T. Raven
2017-04-13  6:37   ` (unknown) Eli Zaretskii
2017-03-19 16:48 (unknown) Paul Pogonyshev
2017-03-19 19:16 ` (unknown) Mark Oteiza
2017-03-19 19:36   ` (unknown) Paul Pogonyshev
2016-09-28 12:26 (unknown) Takesi Ayanokoji
2016-09-29 13:52 ` (unknown) Byung-Hee HWANG (황병희, 黃炳熙)
2016-02-20 15:28 (unknown) Anders Lindgren
2016-02-08  7:54 (unknown) steve
2016-02-08  8:01 ` (unknown) Steve Purcell
2015-08-10 13:59 (unknown) David Kastrup
2015-08-10 14:02 ` (unknown) David Kastrup
2014-11-13 15:21 (unknown) Eli Zaretskii
2014-11-13 15:30 ` (unknown) Lars Magne Ingebrigtsen
2013-07-04  7:50 (unknown) João Távora
2013-07-06 15:22 ` (unknown) Lars Ingebrigtsen
2013-07-06 17:58   ` (unknown) João Távora
2013-07-06 18:01     ` (unknown) Lars Ingebrigtsen
2012-06-29 13:20 (unknown) Eli Zaretskii
2011-09-17  8:02 (unknown) tester12312
2007-04-04 19:09 (unknown) Jost Burkardt
2005-01-16 15:38 (unknown) mayuko_v_v_sutekimax
2003-05-12  7:59 (unknown) Knowledg1
2003-05-12  7:59 (unknown) Knowledg1
2003-05-01  3:08 (unknown) @Traduire
2003-05-01  3:08 (unknown) @Traduire
2003-04-03 22:41 (unknown) Sebastian Tennant
2003-03-14  6:09 (unknown) Waruna Singappuli
2003-02-02  3:30 (unknown) JMT
2002-04-01  2:15 (unknown) ¿ì¹®°ü

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878tr0le2y.fsf@gmail.com \
    --to=czipperz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.