From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.devel Subject: Re: How to help with bug 21071 Date: Sat, 31 Dec 2016 11:04:47 -0800 Message-ID: <878tqvc434.fsf@ericabrahamsen.net> References: <87vau3efml.fsf@thinkpad.rath.org> <837f6ivijl.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1483211105 12195 195.159.176.226 (31 Dec 2016 19:05:05 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 31 Dec 2016 19:05:05 +0000 (UTC) User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/26.0.50 (gnu/linux) Cc: Nikolaus Rath , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Dec 31 20:05:00 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cNOxc-000255-5j for ged-emacs-devel@m.gmane.org; Sat, 31 Dec 2016 20:04:56 +0100 Original-Received: from localhost ([::1]:45151 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cNOxh-0003Dt-A0 for ged-emacs-devel@m.gmane.org; Sat, 31 Dec 2016 14:05:01 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36874) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cNOxb-0003Dl-Bd for emacs-devel@gnu.org; Sat, 31 Dec 2016 14:04:56 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cNOxa-0006VP-HK for emacs-devel@gnu.org; Sat, 31 Dec 2016 14:04:55 -0500 Original-Received: from mail.ericabrahamsen.net ([50.56.99.223]:51986) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cNOxW-0006UG-DQ; Sat, 31 Dec 2016 14:04:50 -0500 Original-Received: from localhost (71-212-13-2.tukw.qwest.net [71.212.13.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id B158BBC903; Sat, 31 Dec 2016 19:04:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mail.ericabrahamsen.net; s=mail; t=1483211088; bh=T4v3QQEB71tLcl6FFJCcUstDd8WMdo7mPgElaYErpdA=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Ju22BvzedZXXfGeccib0K4mkFICsSl8Mkv5cGA7aLQpZ7kfBLJFw+jdC8L7nCG4mE qx715eMXoY2qgIqX30ZG+Ggkn0xNtXjBC+kiULKDde/kWTrPR0pS5NQxKVxHkF/+Fq Y3ZuXKJBxKq4GfFcE7bazXjbOUCZdoNTMJT0xvY0= In-Reply-To: <837f6ivijl.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 29 Dec 2016 17:53:02 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 50.56.99.223 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:211040 Archived-At: Eli Zaretskii writes: >> From: Nikolaus Rath >> Date: Wed, 28 Dec 2016 16:35:46 -0800 >> >> What is the best way for me to fix bug >> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=21071. This is about IMAP >> mails not being marked as read when they are expired at the same time. >> >> I'm happy to write a patch, but it's not clear to me what the patch >> should do. Is the suggestion in message #11 a good idea? > > Could some Gnus maintainer please answer Nikolaus's questions? > Thanks. I'm by no means a Gnus maintainer, but I'm somewhat familiar with the code, and would opt for Nikolaus' second suggestion on the bug tracker: taking `gnus-summary-expire-articles' out of `gnus-summary-prepare-exit-hook', and explicitly calling it in `gnus-summary-exit'. My understanding of hooks is they're meant more for user customization, but running the expiration is Gnus plumbing (if users don't want to expire articles, they already have plenty of ways of doing that). And it seems evident that setting marks should happen before expiration (at least to me!). Eric