From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#25482: 26.0.50; Allow setting `query-replace-from-to-separator` to nil Date: Mon, 30 Jan 2017 02:16:10 +0200 Organization: LINKOV.NET Message-ID: <878tptxv05.fsf@mail.linkov.net> References: <871svzzcn4.fsf@gmail.com> <83lgu76nuf.fsf@gnu.org> <87vatac0a2.fsf@gmail.com> <83a8am6u6q.fsf@gnu.org> <87y3y6ezge.fsf@gmail.com> <8337gd7udo.fsf@gnu.org> <87o9z1n4o3.fsf@gmail.com> <83lgu252zc.fsf@gnu.org> <87o9yy26pg.fsf@gmail.com> <83fuka4yzj.fsf@gnu.org> <87vat65h3o.fsf@gmail.com> <87r33n3cgk.fsf@gmail.com> <83tw8jzllx.fsf@gnu.org> <87poj7wjkr.fsf@gmail.com> <83inozzbvz.fsf@gnu.org> <87mvebwhpx.fsf@gmail.com> <83h94jz42j.fsf@gnu.org> <87h94jyvx6.fsf@gmail.com> <87k29ey93n.fsf@mail.linkov.net> <83lgtuy1jo.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1485736515 10928 195.159.176.226 (30 Jan 2017 00:35:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 30 Jan 2017 00:35:15 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (x86_64-pc-linux-gnu) Cc: 25482@debbugs.gnu.org, thierry.volpiatto@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jan 30 01:35:12 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXzw7-0002eu-CS for geb-bug-gnu-emacs@m.gmane.org; Mon, 30 Jan 2017 01:35:11 +0100 Original-Received: from localhost ([::1]:57373 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cXzwB-0007X6-9V for geb-bug-gnu-emacs@m.gmane.org; Sun, 29 Jan 2017 19:35:15 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50673) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cXzw0-0007T6-6P for bug-gnu-emacs@gnu.org; Sun, 29 Jan 2017 19:35:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cXzvz-00039L-DD for bug-gnu-emacs@gnu.org; Sun, 29 Jan 2017 19:35:04 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:52338) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cXzvz-00039C-9e for bug-gnu-emacs@gnu.org; Sun, 29 Jan 2017 19:35:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cXzvy-0007J2-UB for bug-gnu-emacs@gnu.org; Sun, 29 Jan 2017 19:35:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 Jan 2017 00:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25482 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 25482-submit@debbugs.gnu.org id=B25482.148573645428020 (code B ref 25482); Mon, 30 Jan 2017 00:35:02 +0000 Original-Received: (at 25482) by debbugs.gnu.org; 30 Jan 2017 00:34:14 +0000 Original-Received: from localhost ([127.0.0.1]:50535 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXzvC-0007Hr-1e for submit@debbugs.gnu.org; Sun, 29 Jan 2017 19:34:14 -0500 Original-Received: from sub3.mail.dreamhost.com ([69.163.253.7]:41953 helo=homiemail-a13.g.dreamhost.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXzvA-0007Hd-V5 for 25482@debbugs.gnu.org; Sun, 29 Jan 2017 19:34:13 -0500 Original-Received: from homiemail-a13.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a13.g.dreamhost.com (Postfix) with ESMTP id 5D3B9334075; Sun, 29 Jan 2017 16:34:10 -0800 (PST) Original-Received: from localhost.linkov.net (m213-100-238-78.cust.tele2.ee [213.100.238.78]) (Authenticated sender: jurta@jurta.org) by homiemail-a13.g.dreamhost.com (Postfix) with ESMTPA id 4E89833406C; Sun, 29 Jan 2017 16:34:09 -0800 (PST) In-Reply-To: <83lgtuy1jo.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 29 Jan 2017 05:42:35 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:128775 Archived-At: >> >> So that design decision and the resulting code we have now had some >> >> justification, and any replacement will have to support the same >> >> features, which I think a simple string will not do. >> > >> > Ok, thanks for explanation, perhaps you can close this bug. >> >> Please don't close this bug. I think your idea for customization was = good. >> We just need to find the right implementation that will keep the curre= nt >> default intact, at the same time allowing you to customize the string >> or set it to nil. > > I intended to move the char-displayable-p call from the defcustom, and > remove the re-evaluate call. But if you want to handle this part, it > would be even better. It's just that you've been very silent on this > issue until now. I've been silent because I agreed to your replies to Thierry :) At one point in the beginning of this thread I believe Thierry sent a patch closest to what would be good to have (before =E2=80=9Ccode simpl= ification=E2=80=9D where development went astray). We could return to that patch and test if it does these things right: instead of re-evaluating checks char-displayable-p, but when query-replace-from-to-separator is nil falls back to pre-24.5 that adds strings to the history without ^@.