From: Juri Linkov <juri@linkov.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 25482@debbugs.gnu.org, thierry.volpiatto@gmail.com
Subject: bug#25482: 26.0.50; Allow setting `query-replace-from-to-separator` to nil
Date: Mon, 30 Jan 2017 02:16:10 +0200 [thread overview]
Message-ID: <878tptxv05.fsf@mail.linkov.net> (raw)
In-Reply-To: <83lgtuy1jo.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 29 Jan 2017 05:42:35 +0200")
>> >> So that design decision and the resulting code we have now had some
>> >> justification, and any replacement will have to support the same
>> >> features, which I think a simple string will not do.
>> >
>> > Ok, thanks for explanation, perhaps you can close this bug.
>>
>> Please don't close this bug. I think your idea for customization was good.
>> We just need to find the right implementation that will keep the current
>> default intact, at the same time allowing you to customize the string
>> or set it to nil.
>
> I intended to move the char-displayable-p call from the defcustom, and
> remove the re-evaluate call. But if you want to handle this part, it
> would be even better. It's just that you've been very silent on this
> issue until now.
I've been silent because I agreed to your replies to Thierry :)
At one point in the beginning of this thread I believe Thierry sent
a patch closest to what would be good to have (before “code simplification”
where development went astray). We could return to that patch and test
if it does these things right: instead of re-evaluating checks
char-displayable-p, but when query-replace-from-to-separator is nil
falls back to pre-24.5 that adds strings to the history without ^@.
next prev parent reply other threads:[~2017-01-30 0:16 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-19 8:18 bug#25482: 26.0.50; Allow setting `query-replace-from-to-separator` to nil Thierry Volpiatto
2017-01-19 16:01 ` Eli Zaretskii
2017-01-20 5:54 ` Thierry Volpiatto
[not found] ` <87vatac0a2.fsf@gmail.com>
2017-01-20 5:42 ` bug#25482: Fwd: " Thierry Volpiatto
2017-01-20 7:56 ` Eli Zaretskii
2017-01-20 11:35 ` Thierry Volpiatto
2017-01-20 13:06 ` Eli Zaretskii
2017-01-20 15:16 ` Thierry Volpiatto
2017-01-22 19:06 ` Eli Zaretskii
2017-01-22 20:14 ` Thierry Volpiatto
2017-01-22 20:32 ` Eli Zaretskii
2017-01-23 8:13 ` Thierry Volpiatto
2017-01-28 6:50 ` Thierry Volpiatto
2017-01-28 7:31 ` Eli Zaretskii
2017-01-28 10:43 ` Thierry Volpiatto
2017-01-28 11:01 ` Eli Zaretskii
2017-01-28 11:23 ` Thierry Volpiatto
2017-01-28 13:50 ` Eli Zaretskii
2017-01-28 16:46 ` Thierry Volpiatto
[not found] ` <87k29ey93n.fsf@mail.linkov.net>
2017-01-29 3:42 ` Eli Zaretskii
2017-01-30 0:16 ` Juri Linkov [this message]
2017-02-13 0:37 ` Juri Linkov
2017-02-13 2:24 ` Glenn Morris
2017-02-13 3:04 ` Glenn Morris
2017-02-13 5:51 ` Eli Zaretskii
2017-02-14 0:04 ` Juri Linkov
2017-02-14 0:24 ` Drew Adams
2017-02-18 10:45 ` Eli Zaretskii
2017-02-13 5:53 ` Thierry Volpiatto
2017-02-16 20:43 ` Juri Linkov
2017-01-21 10:05 ` Thierry Volpiatto
2017-01-21 10:24 ` Thierry Volpiatto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878tptxv05.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=25482@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=thierry.volpiatto@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.