From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: [patch] Run occur command restricted to a region Date: Mon, 30 Jan 2017 02:09:08 +0200 Organization: LINKOV.NET Message-ID: <878tpt1m4b.fsf@mail.linkov.net> References: <87vau3jl6f.fsf@gmail.com> <87shp6uwvj.fsf@mail.linkov.net> <83h95lua2f.fsf@gnu.org> <878tqxm1wh.fsf@mail.linkov.net> <87r34ozq20.fsf@gmail.com> <87inq0xhiw.fsf@mail.linkov.net> <87d1g55h8d.fsf@mail.linkov.net> <87r33ywquz.fsf@mail.linkov.net> <87ziilc05e.fsf@gmail.com> <8760l9wcci.fsf@mail.linkov.net> <87fukb2xmk.fsf@gmail.com> <87h94qu01u.fsf@mail.linkov.net> <87inp6nsdf.fsf@gmail.com> <87lgtu4w5c.fsf@mail.linkov.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1485736461 4184 195.159.176.226 (30 Jan 2017 00:34:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 30 Jan 2017 00:34:21 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (x86_64-pc-linux-gnu) Cc: Emacs developers To: Tino Calancha Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jan 30 01:34:17 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXzvE-0000ow-1s for ged-emacs-devel@m.gmane.org; Mon, 30 Jan 2017 01:34:16 +0100 Original-Received: from localhost ([::1]:57363 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cXzvH-00071w-Pf for ged-emacs-devel@m.gmane.org; Sun, 29 Jan 2017 19:34:19 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50372) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cXzvB-00071p-FC for emacs-devel@gnu.org; Sun, 29 Jan 2017 19:34:14 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cXzv8-0002lZ-Da for emacs-devel@gnu.org; Sun, 29 Jan 2017 19:34:13 -0500 Original-Received: from sub3.mail.dreamhost.com ([69.163.253.7]:50709 helo=homiemail-a13.g.dreamhost.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cXzv8-0002l4-7N for emacs-devel@gnu.org; Sun, 29 Jan 2017 19:34:10 -0500 Original-Received: from homiemail-a13.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a13.g.dreamhost.com (Postfix) with ESMTP id CA338334075; Sun, 29 Jan 2017 16:34:07 -0800 (PST) Original-Received: from localhost.linkov.net (m213-100-238-78.cust.tele2.ee [213.100.238.78]) (Authenticated sender: jurta@jurta.org) by homiemail-a13.g.dreamhost.com (Postfix) with ESMTPA id 01A6C33406C; Sun, 29 Jan 2017 16:34:06 -0800 (PST) In-Reply-To: (Tino Calancha's message of "Sun, 29 Jan 2017 15:00:48 +0900 (JST)") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] [fuzzy] X-Received-From: 69.163.253.7 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:211747 Archived-At: >>> +Optional arg REGION, if non-nil, mean restrict search to the >>> +specified region. Otherwise search the entire buffer. >>> +When REGION is non-nil, it must be a cons (START . END). >> >> When someone decides to add support for rectangular regions in occur l= ater, >> your current implementation will make this problematic since it change= s >> the format ((START . END)) to (START . END), that makes difficult to s= upport >> ((START1 . END1) (START2 . END2) ...) later. >> >> Let's stick to the same format in all uses of the new =E2=80=98REGION=E2= =80=99 arg, and >> currently in occur support only the degenerate case of ((START . END)) >> for non-rectangular regions. > > Thanks. I was also a bit worry with that detail. > OK, i keep the general format ((START . END)). > Let me know if the following patch is OK to be pushed: Looks good to me, but you have to ask Eli for the permission to push.