From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.bugs Subject: bug#27272: 25.2; [patch] Fix positional args among keyword args in eldoc. Date: Sun, 11 Jun 2017 10:08:29 +0200 Message-ID: <878tkzc5fm.fsf@gmail.com> References: <87poegnnyn.fsf@gmail.com> <87tw3ng6ov.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1497168551 31939 195.159.176.226 (11 Jun 2017 08:09:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 11 Jun 2017 08:09:11 +0000 (UTC) User-Agent: mu4e 0.9.19; emacs 24.5.1 Cc: 27272@debbugs.gnu.org To: Johan =?UTF-8?Q?Bockg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jun 11 10:09:07 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dJxvn-00083s-1W for geb-bug-gnu-emacs@m.gmane.org; Sun, 11 Jun 2017 10:09:07 +0200 Original-Received: from localhost ([::1]:33172 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dJxvr-0003lE-VY for geb-bug-gnu-emacs@m.gmane.org; Sun, 11 Jun 2017 04:09:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54132) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dJxvm-0003ky-1q for bug-gnu-emacs@gnu.org; Sun, 11 Jun 2017 04:09:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dJxvi-0006FL-RR for bug-gnu-emacs@gnu.org; Sun, 11 Jun 2017 04:09:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37031) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dJxvi-0006EY-NW for bug-gnu-emacs@gnu.org; Sun, 11 Jun 2017 04:09:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dJxvi-0004rl-9w for bug-gnu-emacs@gnu.org; Sun, 11 Jun 2017 04:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Thierry Volpiatto Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Jun 2017 08:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27272 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 27272-submit@debbugs.gnu.org id=B27272.149716852218678 (code B ref 27272); Sun, 11 Jun 2017 08:09:02 +0000 Original-Received: (at 27272) by debbugs.gnu.org; 11 Jun 2017 08:08:42 +0000 Original-Received: from localhost ([127.0.0.1]:39708 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dJxvN-0004rC-N0 for submit@debbugs.gnu.org; Sun, 11 Jun 2017 04:08:41 -0400 Original-Received: from mail-wr0-f177.google.com ([209.85.128.177]:33099) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dJxvM-0004qz-7Y for 27272@debbugs.gnu.org; Sun, 11 Jun 2017 04:08:40 -0400 Original-Received: by mail-wr0-f177.google.com with SMTP id v104so67592428wrb.0 for <27272@debbugs.gnu.org>; Sun, 11 Jun 2017 01:08:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version:content-transfer-encoding; bh=6f4kAY+KUx58bVSfUvgTP5F9HcgjVJSPAqa/VCIoSCA=; b=hvsoU7woLwZpu+nYBO6c+rEdSJMMbQ12s3XXAk1EafJep7NllBAvFokZKDOLvdAfpq w6MSByZQrqC2jXFr1zBaJ620RkoaBr17csHCJ16xXCls8PHLIKPo/z7hU/paI/06EMzv WRQO7g9jlBD1m2fqvKikcHX9zcXC+pPanwqQp2D6dnZEQMXwXSJAoepyc9uC8RZNK3Bc Fr2qUmF2CiFCz5n2PMsKNpV3DPf0BkFVfey7111Woaj7bKrd7Itl0yYj6Lsyb7tixIyE U9fCUxLzXTQig6vMKxgeEAJEZFsDYuWSTjzVyjtnGyZd9RXbFjv2gtVhsbEx4ALbBkHz fY3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version:content-transfer-encoding; bh=6f4kAY+KUx58bVSfUvgTP5F9HcgjVJSPAqa/VCIoSCA=; b=cvAZ9kUNMattSabEJpBtwNchxGEQFyotHeeZ2CThpl4P6YJuBJUmOR0ScXMzn1N01w DtIfa82WoveMsQTpU7Q/AkVV/vxldqliOQmVGoMga1W9oSNWpzjzgynYJ2GPQi9EQgB2 xPpWBUB2oOT0pJXQTqcDZo9+t0vixQHGg5aG6IJNqh/v804XQRxvlTxyrrO5egbhWEXH /rmB67ZmdfQsE7p102JpP+JNiNOpaO5oDprLfZuLBjG08SXfrjaoQWtHRw3wEtkXUcCo oIJxuEN/A8VU2mp4FwdpA8XKfcaQ+vrAAOQ6C5GtpJ3HqqzVK2cUciPucdcsSpx6CnhP 6s2g== X-Gm-Message-State: AODbwcCgRd3B2IKCs4xgIGPZdkxe0X14uRm+1hZCuOau57Cvgir+syYd HJ4KIfsY3bj25BOI X-Received: by 10.223.139.158 with SMTP id o30mr3684332wra.178.1497168514022; Sun, 11 Jun 2017 01:08:34 -0700 (PDT) Original-Received: from dell-14z ([179.43.176.99]) by smtp.gmail.com with ESMTPSA id e24sm11685607wre.54.2017.06.11.01.08.32 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Sun, 11 Jun 2017 01:08:33 -0700 (PDT) In-reply-to: <87tw3ng6ov.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:133464 Archived-At: Johan Bockgård writes: > Thierry Volpiatto writes: > >> Fix eldoc with positional arg among keyword args. >> >> * lisp/progmodes/elisp-mode.el (elisp--highlight-function-argument): >> Switch to indexed arg searching when no keyword found behind arg. > > This code is wrong both with and without your fix. All mandatory and > optional arguments should be used *before* keywords are matched. > > Given this definition of `foo', > > (cl-defun foo (x &key a b c) > (list x a b c)) > > `:b' in the following call specifies the positional argument `x', not > the keyword argument `b': > > (foo :b :a 1) => (:b 1 nil nil) Fixed as well. Thanks. -- Thierry Gpg Key fingerprint = 6CEC 7081 AB33 E251 4AB8 5FC2 28D1 7F53 59F2 9997