From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Rob Browning Newsgroups: gmane.emacs.bugs Subject: bug#27880: 25.2; elisp-mode-tests may downcase too aggressively Date: Sun, 30 Jul 2017 18:17:00 -0500 Message-ID: <878tj55xcj.fsf@trouble.defaultvalue.org> References: <87fudd6gkr.fsf@trouble.defaultvalue.org> <87zibl7j4r.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1501456704 20754 195.159.176.226 (30 Jul 2017 23:18:24 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 30 Jul 2017 23:18:24 +0000 (UTC) Cc: 27880@debbugs.gnu.org To: npostavs@users.sourceforge.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jul 31 01:18:17 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dbxTS-0004cj-3I for geb-bug-gnu-emacs@m.gmane.org; Mon, 31 Jul 2017 01:18:14 +0200 Original-Received: from localhost ([::1]:56692 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dbxTU-0008H0-J7 for geb-bug-gnu-emacs@m.gmane.org; Sun, 30 Jul 2017 19:18:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59350) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dbxTJ-0008EP-GC for bug-gnu-emacs@gnu.org; Sun, 30 Jul 2017 19:18:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dbxTG-00041j-Af for bug-gnu-emacs@gnu.org; Sun, 30 Jul 2017 19:18:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60177) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dbxTG-00041b-6g for bug-gnu-emacs@gnu.org; Sun, 30 Jul 2017 19:18:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dbxTG-0003iU-0i for bug-gnu-emacs@gnu.org; Sun, 30 Jul 2017 19:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Rob Browning Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 30 Jul 2017 23:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27880 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 27880-submit@debbugs.gnu.org id=B27880.150145662814220 (code B ref 27880); Sun, 30 Jul 2017 23:18:01 +0000 Original-Received: (at 27880) by debbugs.gnu.org; 30 Jul 2017 23:17:08 +0000 Original-Received: from localhost ([127.0.0.1]:34621 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dbxSO-0003hH-9X for submit@debbugs.gnu.org; Sun, 30 Jul 2017 19:17:08 -0400 Original-Received: from defaultvalue.org ([70.85.129.156]:51762 ident=postfix) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dbxSM-0003h7-6J for 27880@debbugs.gnu.org; Sun, 30 Jul 2017 19:17:06 -0400 Original-Received: from trouble.defaultvalue.org (localhost [127.0.0.1]) (Authenticated sender: rlb@defaultvalue.org) by defaultvalue.org (Postfix) with ESMTPSA id 8638B20106; Sun, 30 Jul 2017 18:17:03 -0500 (CDT) Original-Received: by trouble.defaultvalue.org (Postfix, from userid 1000) id C8BEC14E0AD; Sun, 30 Jul 2017 18:17:00 -0500 (CDT) In-Reply-To: <87zibl7j4r.fsf@users.sourceforge.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:135178 Archived-At: npostavs@users.sourceforge.net writes: > This is the same as Bug#25534 "xref ERT tests fail when the source path > is mixed case", right? Looks likely. And at least for Debian, something like this fixes it: +++ b/test/automated/elisp-mode-tests.el @@ -179,11 +179,15 @@ xref-elisp-test-descr-to-target (defun xref-elisp-test-run (xrefs expected-xrefs) (should (= (length xrefs) (length expected-xrefs))) (while xrefs - (let* ((xref (pop xrefs)) + (let* ((real-xref (pop xrefs)) + (xref (clone real-xref)) (expected (pop expected-xrefs)) (expected-xref (or (when (consp expected) (car expected)) expected)) (expected-source (when (consp expected) (cdr expected)))) + (setf (oref xref location) + (copy-xref-elisp-location (oref xref location))) + ;; Downcase the filenames for case-insensitive file systems. (setf (xref-elisp-location-file (oref xref location)) (downcase (xref-elisp-location-file (oref xref location)))) @@ -193,7 +197,7 @@ xref-elisp-test-run (should (equal xref expected-xref)) - (xref--goto-location (xref-item-location xref)) + (xref--goto-location (xref-item-location real-xref)) (back-to-indentation) (should (looking-at (or expected-source (xref-elisp-test-descr-to-target expected))))) -- Rob Browning rlb @defaultvalue.org and @debian.org GPG as of 2011-07-10 E6A9 DA3C C9FD 1FF8 C676 D2C4 C0F0 39E9 ED1B 597A GPG as of 2002-11-03 14DD 432F AE39 534D B592 F9A0 25C8 D377 8C7E 73A4