From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alex Newsgroups: gmane.emacs.bugs Subject: bug#28658: 27.0.50; [PATCH] double/triple clicking in xterm-mouse-mode doesn't respect mouse position Date: Sun, 01 Oct 2017 12:30:23 -0600 Message-ID: <878tgura9s.fsf@gmail.com> References: <87r2unyh79.fsf@gmail.com> <87zi9bwmet.fsf@gmail.com> <59D0A616.2000003@gmx.at> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: blaine.gmane.org 1506882676 19148 195.159.176.226 (1 Oct 2017 18:31:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 1 Oct 2017 18:31:16 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 28658@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Oct 01 20:31:11 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dyj1B-0004Gt-Px for geb-bug-gnu-emacs@m.gmane.org; Sun, 01 Oct 2017 20:31:10 +0200 Original-Received: from localhost ([::1]:49484 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dyj1E-0000xD-Jd for geb-bug-gnu-emacs@m.gmane.org; Sun, 01 Oct 2017 14:31:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51898) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dyj17-0000vv-Ty for bug-gnu-emacs@gnu.org; Sun, 01 Oct 2017 14:31:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dyj14-0008U7-GK for bug-gnu-emacs@gnu.org; Sun, 01 Oct 2017 14:31:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34419) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dyj14-0008Tx-Bi for bug-gnu-emacs@gnu.org; Sun, 01 Oct 2017 14:31:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dyj14-0002aG-6d for bug-gnu-emacs@gnu.org; Sun, 01 Oct 2017 14:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alex Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 Oct 2017 18:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28658 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 28658-submit@debbugs.gnu.org id=B28658.15068826349891 (code B ref 28658); Sun, 01 Oct 2017 18:31:02 +0000 Original-Received: (at 28658) by debbugs.gnu.org; 1 Oct 2017 18:30:34 +0000 Original-Received: from localhost ([127.0.0.1]:43100 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dyj0c-0002ZT-1D for submit@debbugs.gnu.org; Sun, 01 Oct 2017 14:30:34 -0400 Original-Received: from mail-io0-f182.google.com ([209.85.223.182]:54668) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dyj0Z-0002Z9-VW for 28658@debbugs.gnu.org; Sun, 01 Oct 2017 14:30:32 -0400 Original-Received: by mail-io0-f182.google.com with SMTP id h66so3217438ioh.11 for <28658@debbugs.gnu.org>; Sun, 01 Oct 2017 11:30:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=/BY/5dEShd00+EQlnaY2VxjRG5b06G8QVL/yvKQQg1s=; b=rmCoamW/Cjj1QMReVa9O/6kalPrL3OvJLMUj5FMz0ond6Z55FVe9HT/5epc43RJ9Pl rMNS1+3cktREhKQj7eR40noDsn2qZehMHs8qlAUFchC4Jb13jIh8knt4g4b01tBFRz5d 03Ej3BUXQ+z/llxvkPKNVjRkIMyJMUaK+ds4F0iLAahmZM3E2lAW1l+zdeOhyZsObgIK 5vXuxHfNr1Tps8TPZHcqHVm6w2F9sUpBUiOjw4bo9wv4K8qOyYq+YeHWcJSf4CdYZWZL 7S0oGewssJVtxsoF4+TPqH+i3eOA6Od3nkdyGWcjVoE0CyNFPKQMN4lFQAUuUKyJGLOR VeSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=/BY/5dEShd00+EQlnaY2VxjRG5b06G8QVL/yvKQQg1s=; b=AQ1NheLXZ4jSsokPWUUX/RDQ1A3qYROS57dfmg4oRrXFZFOH/BsrZmOjCiq/SgefBN Op6qtDJBwjeHhpdHdO3XhhsXgsZS6t3EdBzMlrSTRqp3QBYddp0jbFwN9c+xlIhqF+L9 r+dAd5Oi9lLNXzqG+HotZlyj91CIdRZRbbR44DUrRc9RJCxc171HOnBR+XGC/zLDP+SW WBzYVnGitYb53SnT9k1cyP6QGWY6RyvacCO76qpqKCU/iylzzWIiLPdvUVdROUe+cT85 7Bm+kN0eBjbaKxD1F1V//XGURXs9VQVRbtVqcDP2MsgRSboHv8MZbJCVMBUMJPWGl16C 6vdw== X-Gm-Message-State: AMCzsaUqB+USvH2i/mv8nPdT5WSEm1fj2hRA9M7D8MRbHJDserOZi823 QqzguogqcvqSKTdbaSBaTDG/vw== X-Google-Smtp-Source: AOwi7QA1H13bDhO+buA3j5TXN2LTn7CvHQCVrlxhPM0LQ7NiS+zs6AF/W88TKnTY0NmWUjeXBLX2ww== X-Received: by 10.107.180.216 with SMTP id d207mr23288103iof.275.1506882626182; Sun, 01 Oct 2017 11:30:26 -0700 (PDT) Original-Received: from lylat (S010664777d9cebe3.ss.shawcable.net. [70.64.85.59]) by smtp.gmail.com with ESMTPSA id m12sm3872501ita.17.2017.10.01.11.30.24 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 01 Oct 2017 11:30:25 -0700 (PDT) In-Reply-To: <59D0A616.2000003@gmx.at> (martin rudalics's message of "Sun, 01 Oct 2017 10:23:50 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:137754 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable martin rudalics writes: > + ((and last-time > + (> double-click-time (* 1000 (- this-time last-time))) > > Note that here and elsewhere coders assume that =E2=80=98double-click-tim= e=E2=80=99 is a > number. However, it may be also nil or t and we should fix those > instances eventually (see Bug#23419). In new or changed code, at least. Sure, here's a third patch to deal with that: --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-lisp-xt-mouse.el-xterm-mouse-event-Handle-boolean-do.patch Content-Description: boolean >From efb7f09f585d6652221f5e58e9bc635e6100a588 Mon Sep 17 00:00:00 2001 From: Alexander Gramiak Date: Sun, 1 Oct 2017 12:21:19 -0600 Subject: [PATCH] * lisp/xt-mouse.el (xterm-mouse-event): Handle boolean double-click-time --- lisp/xt-mouse.el | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lisp/xt-mouse.el b/lisp/xt-mouse.el index cbbeec82fa..aa5aa0f7f5 100644 --- a/lisp/xt-mouse.el +++ b/lisp/xt-mouse.el @@ -291,7 +291,9 @@ xterm-mouse-event (equal name (replace-match "" t t last-name))) (xterm-mouse--set-click-count event click-count))) ((and last-time - (> double-click-time (* 1000 (- this-time last-time))) + double-click-time + (or (eq double-click-time t) + (> double-click-time (* 1000 (- this-time last-time)))) (eq x last-x) (eq y last-y) (equal last-name (replace-match "" t t name))) -- 2.14.2 --=-=-=--