From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alex Newsgroups: gmane.emacs.bugs Subject: bug#28710: 27.0.50; eassert failure in maybe_produce_line_number Date: Sat, 07 Oct 2017 17:05:34 -0600 Message-ID: <878tgmd0e9.fsf@gmail.com> References: <8760buwnne.fsf@gmail.com> <83d162xahp.fsf@gnu.org> <87bmllxieq.fsf@gmail.com> <83wp48vffr.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1507417575 20611 195.159.176.226 (7 Oct 2017 23:06:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 7 Oct 2017 23:06:15 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 28710@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Oct 08 01:06:11 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e0yAb-0004Ph-8B for geb-bug-gnu-emacs@m.gmane.org; Sun, 08 Oct 2017 01:06:09 +0200 Original-Received: from localhost ([::1]:51538 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e0yAg-0007Nc-Oc for geb-bug-gnu-emacs@m.gmane.org; Sat, 07 Oct 2017 19:06:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47852) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e0yAX-0007NW-DH for bug-gnu-emacs@gnu.org; Sat, 07 Oct 2017 19:06:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e0yAU-0004cI-7E for bug-gnu-emacs@gnu.org; Sat, 07 Oct 2017 19:06:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46519) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e0yAU-0004bS-2s for bug-gnu-emacs@gnu.org; Sat, 07 Oct 2017 19:06:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e0yAT-0001qM-Ms for bug-gnu-emacs@gnu.org; Sat, 07 Oct 2017 19:06:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alex Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Oct 2017 23:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28710 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 28710-submit@debbugs.gnu.org id=B28710.15074175467060 (code B ref 28710); Sat, 07 Oct 2017 23:06:01 +0000 Original-Received: (at 28710) by debbugs.gnu.org; 7 Oct 2017 23:05:46 +0000 Original-Received: from localhost ([127.0.0.1]:55200 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e0yAD-0001pn-Uv for submit@debbugs.gnu.org; Sat, 07 Oct 2017 19:05:46 -0400 Original-Received: from mail-it0-f50.google.com ([209.85.214.50]:44853) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e0yAB-0001pa-IS for 28710@debbugs.gnu.org; Sat, 07 Oct 2017 19:05:43 -0400 Original-Received: by mail-it0-f50.google.com with SMTP id n195so5014147itg.1 for <28710@debbugs.gnu.org>; Sat, 07 Oct 2017 16:05:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=UQQM2ILrzdEKSHY2HBwjF5phXSltN4JL6NewJ7u3XNY=; b=JAP8VbSrwmUYvFzM+cQiPZcxHAA5gLmUqFtxRNijG0ND3bfnB3MYupqBzMLMu2umAI AxK7d6ACU1uoul+LJ/XpcqiqegTRGPotxJMCN2weZdU0Zy84s1PlC9AibRXDJmbYk/O/ Uc55SggSyUBcou2HiXP+3afnU/g6htHWL7GiVl5SmhjVZkgooP3MdvSfZTMSU8PR1Yf+ xx3nwjSuyNCtTa3MFf6DSNhVEJrDMDknmW6J+eviR2/GeVfdM302KvhaeWfymhVOJsB0 rCRVu9eo7wSYL+qBaLLTYCn1aL2u0ToYAByi3YUmo3helrDputv7DXOtXyP/rHMSA4/x mIFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=UQQM2ILrzdEKSHY2HBwjF5phXSltN4JL6NewJ7u3XNY=; b=YhzB+PMpB7IfYQwHU9pZM4ABprm9xj+1QtoDTtjrdUfNhjqaI4DIe9HYx2DAZdePaE 6FN87WVCwOj01IpOuAmtWvHE+9FTbF5oVKuFHnr1hRTU+cZiMKwkEVIdiKDKEC33+7zx nlFkbft1Zai4l7TBHtu0hP8zS5dfkLHFmn3zzuzn83EAo70t12Chr51CwnyQAZDdWUrm 4MDQepgztN7XmD9svhybSuVSL+nO5rfeJZxvGW/PXNwQp735vP86HVf4ps590G2szJrM N2a1sDlsG1cE8jMUb3LOHtY9nmfoPV7YAd6FyjwQR150ZqQwCmmUNgi0Q8uhTNs6OUwC /QiA== X-Gm-Message-State: AMCzsaWGFm4OBycVhMJpmOzMJyPhzDOFXXBL5d27NNb0FM3xU+lEXhar sNq7RFon3kLU7j5vGLkmtFJZQQ== X-Google-Smtp-Source: AOwi7QAJlCT3XFOb0Qb1h9H2LJLrLlrz7vLfWrdTN0foEUZzMEQJf5oc9WY7xNZbZGebZH2t2SLArA== X-Received: by 10.36.25.205 with SMTP id b196mr8859593itb.78.1507417537654; Sat, 07 Oct 2017 16:05:37 -0700 (PDT) Original-Received: from lylat (S010664777d9cebe3.ss.shawcable.net. [70.64.85.59]) by smtp.gmail.com with ESMTPSA id 65sm2498745ite.31.2017.10.07.16.05.35 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 07 Oct 2017 16:05:36 -0700 (PDT) In-Reply-To: <83wp48vffr.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 06 Oct 2017 11:38:48 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:138060 Archived-At: Eli Zaretskii writes: > I wrote instructions for a debugging session to find that out, see > > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=27668#89 > > Instead of "r -Q", type just "run" to run Emacs as usual, or even > attach to an already running Emacs with "gdb -p", set the breakpoint, > and type "continue. The "Inside Emacs" part will have to be replaced > with your recipe, up to and including step 5, and you should invoke > redraw-display just before hitting the final RET in step 6, the one > that triggers the assertion. After performing the GDB commands and > continuing Emacs, hit RET, and post the backtraces from every time the > watchpoint set by those GDB commands is hit. I hope we will then see > the offending code that needs to be fixed. > > Let me know if you need me to rewrite the instructions to fit your > case exactly. Okay, I've pasted the output below. 2 watchpoints triggered right after M-x redraw-display, and I only get the third before the assertion. After your recipe, you mention update_display and how it runs after Emacs "redrawn the window to the glass", so it should be noted that the assertion violated is triggered before the buffer with display-line-numbers is displayed. Thread 1 "emacs" hit Hardware watchpoint 4: -location $1->desired_matrix->rows->enabled_p Old value = false New value = true prepare_desired_row (w=0x45066d0, row=0x4509fa0, mode_line_p=true) at dispnew.c:1076 1076 row->reversed_p = rp; (gdb) Lisp Backtrace: "redisplay_internal (C function)" (0x0) Thread 1 "emacs" hit Hardware watchpoint 4: -location $1->desired_matrix->rows->enabled_p Old value = true New value = false clear_glyph_matrix_rows (matrix=0x38d2a30, start=0, end=37) at dispnew.c:693 693 for (; start < end; ++start) Lisp Backtrace: "redisplay_internal (C function)" (0x0) Thread 1 "emacs" hit Hardware watchpoint 4: -location $1->desired_matrix->rows->enabled_p Old value = false New value = true prepare_desired_row (w=0x45066d0, row=0x4509fa0, mode_line_p=false) at dispnew.c:1076 1076 row->reversed_p = rp; Lisp Backtrace: "redisplay_internal (C function)" (0x0) Thread 1 "emacs" hit Breakpoint 1, terminate_due_to_signal (sig=6, backtrace_limit=2147483647) at emacs.c:364 364 signal (sig, SIG_DFL); >> That's odd, since I believe unless there was a git error the first line >> should start with "Head:" and pressing RET on it shows the commit at >> HEAD. Maybe there's another situation where that's not the case. > > What if HEAD is a merge-commit? I think this is what I got when I > tried. Anyway, this is just a tangential issue. I believe it should still show the "Head:" line, but there's no hunks that are displayed in the revision buffer. I tried reproducing by pressing RET on a filename in its revision buffer and it also crashes. >> Just to specify a commit, try M-x magit-show-commit RET 92045f45 RET in >> an Emacs repo and press RET on the following line: >> +@code{file-symlink-p}, @code{file-system-info} > > You mean "C-u M-x magit-show-commit", right? Tried this as well, > still no assertion violation. If you want to force a completing-read for the commit, then yes. Too bad you still can't reproduce it; every build I've configured with "--enable-checking=yes,glyphs --enable-check-lisp-object-type 'CFLAGS=-O0 -g3'" crashes here. > P.S. Btw, I'm debugging this in the emacs-26 branch, so perhaps so > should you, to avoid any irrelevant differences between what you and I > see. I tried reproducing the assertion violation in both branches, > and failed in both. Okay, the debugging done above is with an up-to-date emacs-26 branch.