all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* The issue with with-temp-buffer (or with-current-buffer)
@ 2017-12-15 18:25 OGAWA Hirofumi
  2017-12-15 20:13 ` OGAWA Hirofumi
  2017-12-15 20:51 ` Eli Zaretskii
  0 siblings, 2 replies; 7+ messages in thread
From: OGAWA Hirofumi @ 2017-12-15 18:25 UTC (permalink / raw)
  To: emacs-devel

Hi,

The following is the reproduce code of issue,

(let ((buf (get-buffer-create "test-case")))
  (display-buffer buf)
  (with-current-buffer buf
    (erase-buffer)
    (insert "1\n")
    ;; start suspect
    (with-temp-buffer
      (save-window-excursion
	(set-window-buffer nil (current-buffer))))
    ;; end suspect
    (insert "2\n")))

and expected result is

    ---- test-case ----
    2
    1
    -------------------

But actual result is

    ---- test-case ----
    1
    2
    -------------------

[The actual issue that I'm hitted was using `shr-insert-document'
like following. And above is simplied version to reproduce the issue.

  (with-current-buffer buf
    (erase-buffer)
    (insert ...)
    (shr-insert-document '(html nil (body nil ...)))
    (insert ...)))
]

After some debugging, I noticed `with-current-buffer' that is
used in `with-temp-buffer' doesn't restore `point'.

And if I replaced `with-current-buffer' with
save-excursion+set-buffer, the issue is fixed.

I.e. from
	(with-temp-buffer
to
	(save-excursion
	  (set-buffer ,temp-buffer)

Well so, this behavior (doesn't restore point) of
`with-temp-buffer' (or `with-current-buffer') is intented or bug?

And to fix this issue, we should change which one of
with-temp-buffer, with-current-buffer, shr-insert-document, or
user of shr-insert-document?

Thanks.
-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>



^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2017-12-16 12:55 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-15 18:25 The issue with with-temp-buffer (or with-current-buffer) OGAWA Hirofumi
2017-12-15 20:13 ` OGAWA Hirofumi
2017-12-15 20:51 ` Eli Zaretskii
2017-12-15 21:46   ` OGAWA Hirofumi
2017-12-15 22:40     ` OGAWA Hirofumi
2017-12-16  8:29       ` Eli Zaretskii
2017-12-16 12:55         ` OGAWA Hirofumi

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.