From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.bugs Subject: bug#29763: New Feature: Remove unneeded eval-expression in minibuffer-history Date: Fri, 22 Dec 2017 13:58:49 +0100 Message-ID: <878tdu9awm.fsf@linux-m68k.org> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1513947501 21967 195.159.176.226 (22 Dec 2017 12:58:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 22 Dec 2017 12:58:21 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) Cc: rswgnu@gmail.com, 29763@debbugs.gnu.org To: Robert Weiner Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Dec 22 13:58:16 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eSMu0-0005Qp-4L for geb-bug-gnu-emacs@m.gmane.org; Fri, 22 Dec 2017 13:58:16 +0100 Original-Received: from localhost ([::1]:49434 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eSMvy-0005f5-Iy for geb-bug-gnu-emacs@m.gmane.org; Fri, 22 Dec 2017 08:00:18 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41540) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eSMvo-0005X4-Lb for bug-gnu-emacs@gnu.org; Fri, 22 Dec 2017 08:00:12 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eSMvj-0003Lw-4S for bug-gnu-emacs@gnu.org; Fri, 22 Dec 2017 08:00:08 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:38313) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eSMvj-0003Lk-1C for bug-gnu-emacs@gnu.org; Fri, 22 Dec 2017 08:00:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eSMvi-0002kG-P0 for bug-gnu-emacs@gnu.org; Fri, 22 Dec 2017 08:00:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Andreas Schwab Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 22 Dec 2017 13:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29763 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 29763-submit@debbugs.gnu.org id=B29763.151394754210420 (code B ref 29763); Fri, 22 Dec 2017 13:00:02 +0000 Original-Received: (at 29763) by debbugs.gnu.org; 22 Dec 2017 12:59:02 +0000 Original-Received: from localhost ([127.0.0.1]:46991 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eSMuj-0002hv-N2 for submit@debbugs.gnu.org; Fri, 22 Dec 2017 07:59:01 -0500 Original-Received: from mail-out.m-online.net ([212.18.0.9]:49102) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eSMuh-0002he-F3 for 29763@debbugs.gnu.org; Fri, 22 Dec 2017 07:58:59 -0500 Original-Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3z37qk24kRz1qrjj; Fri, 22 Dec 2017 13:58:58 +0100 (CET) Original-Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 3z37qk0z6Fz1qqkC; Fri, 22 Dec 2017 13:58:58 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Original-Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id rDNSN08EsAyq; Fri, 22 Dec 2017 13:58:50 +0100 (CET) X-Auth-Info: XwpIY7255VHoFejPILldtg8AZxrxYh27nunjacTWgg9cyZbDVmdVSzCNENJRnhiD Original-Received: from localhost (ppp-188-174-145-180.dynamic.mnet-online.de [188.174.145.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Fri, 22 Dec 2017 13:58:50 +0100 (CET) Original-Received: by localhost (Postfix, from userid 1000) id 78CD82C3181; Fri, 22 Dec 2017 13:58:49 +0100 (CET) X-Yow: A KAISER ROLL?! What good is a Kaiser Roll without a little COLE SLAW on the SIDE? In-Reply-To: (Robert Weiner's message of "Sun, 17 Dec 2017 23:13:17 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:141371 Archived-At: On Dez 17 2017, Robert Weiner wrote: > + (defun minibuffer-history-edit-element (elt) > + "Automatically simplify ELT if possible, e.g. removing eval-expression." > + (or (and (consp elt) (eq (car elt) 'eval-expression) > + ;; Remove eval-expression wrapper and leave just the expression. > + (cadadr elt)) That mishandles self-evaluating expressions, they are not wrapped with quote. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."