From: Marcin Borkowski <mbork@amu.edu.pl>
To: Emanuel Berg <moasen@zoho.com>
Cc: help-gnu-emacs@gnu.org
Subject: Re: DWIM region (was: Re: count regexp hits)
Date: Sun, 07 Jan 2018 08:21:10 +0100 [thread overview]
Message-ID: <878tdaf82h.fsf@amu.edu.pl> (raw)
In-Reply-To: <86a7xqupz0.fsf@zoho.com>
On 2018-01-07, at 07:45, Emanuel Berg <moasen@zoho.com> wrote:
> Marcin Borkowski wrote:
>
>> spacing is kind of strange.
>
> "spacing"?
(defun count-regexp-hits (regexp)
(interactive "sregexp: ")
(let*((region (if mark-active
`(,(region-beginning) ,(region-end))
`(,(point-min) ,(point-max)) ))
(start (car region))
(end (cadr region)) )
(count-matches regexp start end t) ))
1. Lack of space after `let*'.
2. Unnecessary space before `))` (twice).
3. Unnecessary double spaces in lines with `start' and `end' (I
understand their purpose, but my OCD does not like them anyway).
Best,
--
Marcin Borkowski
http://octd.wmi.amu.edu.pl/en/Marcin_Borkowski
Faculty of Mathematics and Computer Science
Adam Mickiewicz University
next prev parent reply other threads:[~2018-01-07 7:21 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-04 4:12 count regexp hits Emanuel Berg
2018-01-04 5:02 ` Drew Adams
[not found] ` <mailman.6799.1515042142.27995.help-gnu-emacs@gnu.org>
2018-01-04 18:47 ` Emanuel Berg
2018-01-04 21:32 ` DWIM region (was: Re: count regexp hits) Emanuel Berg
2018-01-04 22:18 ` DWIM region Stefan Monnier
2018-01-05 23:18 ` Philipp Stephani
2018-01-04 22:48 ` DWIM region (was: Re: count regexp hits) Kaushal Modi
[not found] ` <mailman.6836.1515106138.27995.help-gnu-emacs@gnu.org>
2018-01-04 23:03 ` Emanuel Berg
2018-01-04 23:14 ` Kaushal Modi
[not found] ` <mailman.6837.1515107666.27995.help-gnu-emacs@gnu.org>
2018-01-05 2:10 ` Emanuel Berg
2018-01-08 16:09 ` advice vs hooks in org (was DWIM region) Rusi
[not found] ` <mailman.6835.1515104325.27995.help-gnu-emacs@gnu.org>
2018-01-04 23:09 ` DWIM region Emanuel Berg
2018-01-04 23:14 ` Stefan Monnier
[not found] ` <mailman.6838.1515107716.27995.help-gnu-emacs@gnu.org>
2018-01-04 23:36 ` Emanuel Berg
2018-01-05 0:19 ` Emanuel Berg
2018-01-05 20:45 ` Emanuel Berg
2018-01-05 22:31 ` Stefan Monnier
[not found] ` <mailman.6892.1515191546.27995.help-gnu-emacs@gnu.org>
2018-01-06 2:20 ` Emanuel Berg
2018-01-06 15:53 ` Stefan Monnier
[not found] ` <mailman.6929.1515254243.27995.help-gnu-emacs@gnu.org>
2018-01-06 18:52 ` Emanuel Berg
2018-01-06 20:29 ` Emanuel Berg
2018-01-06 22:14 ` Emanuel Berg
2018-01-07 3:14 ` Emanuel Berg
2018-01-07 3:25 ` Emanuel Berg
2018-01-08 14:17 ` Stefan Monnier
[not found] ` <mailman.7019.1515421057.27995.help-gnu-emacs@gnu.org>
2018-01-09 1:41 ` Emanuel Berg
2018-01-09 2:30 ` Stefan Monnier
[not found] ` <mailman.7052.1515465048.27995.help-gnu-emacs@gnu.org>
2018-01-09 4:11 ` Emanuel Berg
2018-01-09 13:40 ` Stefan Monnier
2018-01-08 14:11 ` Stefan Monnier
[not found] ` <mailman.7018.1515420745.27995.help-gnu-emacs@gnu.org>
2018-01-08 20:26 ` Emanuel Berg
2018-01-08 14:08 ` Stefan Monnier
2018-01-04 23:20 ` Emanuel Berg
2018-01-07 5:32 ` DWIM region (was: Re: count regexp hits) Marcin Borkowski
[not found] ` <mailman.6953.1515303153.27995.help-gnu-emacs@gnu.org>
2018-01-07 6:45 ` Emanuel Berg
2018-01-07 7:21 ` Marcin Borkowski [this message]
[not found] ` <mailman.6967.1515337253.27995.help-gnu-emacs@gnu.org>
2018-01-07 20:57 ` Emanuel Berg
2018-01-09 5:28 ` Marcin Borkowski
2018-01-09 13:42 ` DWIM region Stefan Monnier
[not found] ` <mailman.7069.1515505638.27995.help-gnu-emacs@gnu.org>
2018-01-10 3:31 ` Emanuel Berg
[not found] ` <mailman.7055.1515475732.27995.help-gnu-emacs@gnu.org>
2018-01-09 6:20 ` DWIM region (was: Re: count regexp hits) Emanuel Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878tdaf82h.fsf@amu.edu.pl \
--to=mbork@amu.edu.pl \
--cc=help-gnu-emacs@gnu.org \
--cc=moasen@zoho.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.