From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tom Tromey Newsgroups: gmane.emacs.bugs Subject: bug#30377: 27.0.50; Missing and misspelled SHR/CSS colors Date: Wed, 07 Feb 2018 08:03:47 -0700 Message-ID: <878tc4yh7w.fsf@tromey.com> References: <87eflxii72.fsf@tcd.ie> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1518015746 25093 195.159.176.226 (7 Feb 2018 15:02:26 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 7 Feb 2018 15:02:26 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.91 (gnu/linux) Cc: Julien Danjou , Tom Tromey , 30377@debbugs.gnu.org, Simen =?UTF-8?Q?Heggest=C3=B8yl?= To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Feb 07 16:02:22 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ejREj-0005hY-ML for geb-bug-gnu-emacs@m.gmane.org; Wed, 07 Feb 2018 16:02:13 +0100 Original-Received: from localhost ([::1]:49162 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ejRGl-0002Hk-36 for geb-bug-gnu-emacs@m.gmane.org; Wed, 07 Feb 2018 10:04:19 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36779) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ejRGZ-000261-Lf for bug-gnu-emacs@gnu.org; Wed, 07 Feb 2018 10:04:11 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ejRGU-0006Z5-Lr for bug-gnu-emacs@gnu.org; Wed, 07 Feb 2018 10:04:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:53706) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ejRGU-0006YL-EN for bug-gnu-emacs@gnu.org; Wed, 07 Feb 2018 10:04:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ejRGU-0003cM-3O for bug-gnu-emacs@gnu.org; Wed, 07 Feb 2018 10:04:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Tom Tromey Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 07 Feb 2018 15:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30377 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 30377-submit@debbugs.gnu.org id=B30377.151801583613894 (code B ref 30377); Wed, 07 Feb 2018 15:04:02 +0000 Original-Received: (at 30377) by debbugs.gnu.org; 7 Feb 2018 15:03:56 +0000 Original-Received: from localhost ([127.0.0.1]:33370 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ejRGM-0003c0-38 for submit@debbugs.gnu.org; Wed, 07 Feb 2018 10:03:56 -0500 Original-Received: from gateway32.websitewelcome.com ([192.185.145.113]:20485) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ejRGI-0003bq-7g for 30377@debbugs.gnu.org; Wed, 07 Feb 2018 10:03:50 -0500 Original-Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway32.websitewelcome.com (Postfix) with ESMTP id 5F71926350 for <30377@debbugs.gnu.org>; Wed, 7 Feb 2018 09:03:49 -0600 (CST) Original-Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id jRGHecSyh0aRHjRGHewlRp; Wed, 07 Feb 2018 09:03:49 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Iz4cOs8cECNrssQCPXZNextHaNVNn01XONGCxMP/EiI=; b=YRdRe1qbLyJqC/MQ1CaRLiYAJF ThbUT5YyqUkAVzJsHG/gPkp1uvBa+GvXkbykSO9oWdaoyqgqaXOvgrkWV4F0hFIngNwImeA8/uh40 vejgS5eDS1BX+qqfGad9KRYJD; Original-Received: from 174-29-33-254.hlrn.qwest.net ([174.29.33.254]:51946 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1ejRGH-001JRC-1Y; Wed, 07 Feb 2018 09:03:49 -0600 X-Attribution: Tom In-Reply-To: <87eflxii72.fsf@tcd.ie> (Basil L. Contovounesios's message of "Wed, 07 Feb 2018 03:37:05 +0000") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.29.33.254 X-Source-L: No X-Exim-ID: 1ejRGH-001JRC-1Y X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-29-33-254.hlrn.qwest.net (pokyo) [174.29.33.254]:51946 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:143005 Archived-At: >>>>> "Basil" == Basil L Contovounesios writes: Basil> * lisp/textmodes/css-mode.el (css--color-map): Add fuchsia-magenta Basil> and aqua-cyan aliases. Thanks. According to MDN these are the only non-grey/gray aliases. Maybe they weren't on whatever list I started with for that reason. Basil> In that bug report, which introduced css--color-map, Eli was referring Basil> to the list of colours in lisp/term/tty-colors.el. I would instead like Basil> to draw attention to the overlap between css--color-map and Basil> shr-color-html-colors-alist. Yes, I wasn't aware of this list from shr. It seems to me that shr ought to use exactly the CSS colors, so the lists can be shared. Though, I recommend contacting Lars before doing anything. Basil> A (very) cursory glance through bug#25525 and lisp/net/shr-color.el Basil> suggests there may be some further code duplication pertaining to colour Basil> distances; is this so? It seems so but I've mostly forgotten whatever I knew about this area. What I do remember is checking my original algorithm against the one Eli suggested, by comparing all the CSS named colors with their backgrounds; and concluding that the one Eli suggested (built in to Emacs) was just as good. So perhaps shr is doing too much work here as well. Tom