all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Tom Tromey <tom@tromey.com>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: "Julien Danjou" <julien@danjou.info>,
	"Tom Tromey" <tom@tromey.com>,
	30377@debbugs.gnu.org, "Simen Heggestøyl" <simenheg@gmail.com>
Subject: bug#30377: 27.0.50; Missing and misspelled SHR/CSS colors
Date: Wed, 07 Feb 2018 08:03:47 -0700	[thread overview]
Message-ID: <878tc4yh7w.fsf@tromey.com> (raw)
In-Reply-To: <87eflxii72.fsf@tcd.ie> (Basil L. Contovounesios's message of "Wed, 07 Feb 2018 03:37:05 +0000")

>>>>> "Basil" == Basil L Contovounesios <contovob@tcd.ie> writes:

Basil> * lisp/textmodes/css-mode.el (css--color-map): Add fuchsia-magenta
Basil> and aqua-cyan aliases.

Thanks.  According to MDN these are the only non-grey/gray aliases.
Maybe they weren't on whatever list I started with for that reason.

Basil> In that bug report, which introduced css--color-map, Eli was referring
Basil> to the list of colours in lisp/term/tty-colors.el.  I would instead like
Basil> to draw attention to the overlap between css--color-map and
Basil> shr-color-html-colors-alist.

Yes, I wasn't aware of this list from shr.  It seems to me that shr
ought to use exactly the CSS colors, so the lists can be shared.
Though, I recommend contacting Lars before doing anything.

Basil> A (very) cursory glance through bug#25525 and lisp/net/shr-color.el
Basil> suggests there may be some further code duplication pertaining to colour
Basil> distances; is this so?

It seems so but I've mostly forgotten whatever I knew about this area.

What I do remember is checking my original algorithm against the one Eli
suggested, by comparing all the CSS named colors with their backgrounds;
and concluding that the one Eli suggested (built in to Emacs) was just
as good.  So perhaps shr is doing too much work here as well.

Tom





      parent reply	other threads:[~2018-02-07 15:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-07  3:37 bug#30377: 27.0.50; Missing and misspelled SHR/CSS colors Basil L. Contovounesios
2018-02-07  9:45 ` Simen Heggestøyl
2018-02-07 18:22   ` Eli Zaretskii
2018-02-07 21:19     ` Simen Heggestøyl
2018-02-07 15:03 ` Tom Tromey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878tc4yh7w.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=30377@debbugs.gnu.org \
    --cc=contovob@tcd.ie \
    --cc=julien@danjou.info \
    --cc=simenheg@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.