From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: John Shahid Newsgroups: gmane.emacs.bugs Subject: bug#30610: clarify linux-mode usage from Lisp Date: Sat, 03 Mar 2018 18:24:04 -0500 Message-ID: <878tb8bv57.fsf@gmail.com> References: <87d10skfna.fsf@gmail.com> <87a7vwkeux.fsf@gmail.com> <87bmg740qd.fsf@gmail.com> <87a7vobvgg.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: blaine.gmane.org 1520122280 28423 195.159.176.226 (4 Mar 2018 00:11:20 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 4 Mar 2018 00:11:20 +0000 (UTC) User-Agent: mu4e 1.0-alpha3; emacs 26.0.91 Cc: 30610@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Mar 04 01:11:16 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1esHFB-0006MQ-48 for geb-bug-gnu-emacs@m.gmane.org; Sun, 04 Mar 2018 01:11:13 +0100 Original-Received: from localhost ([::1]:42785 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1esHHD-0005r0-M3 for geb-bug-gnu-emacs@m.gmane.org; Sat, 03 Mar 2018 19:13:19 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39561) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1esHH0-0005op-Du for bug-gnu-emacs@gnu.org; Sat, 03 Mar 2018 19:13:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1esHGx-0008UH-8U for bug-gnu-emacs@gnu.org; Sat, 03 Mar 2018 19:13:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35426) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1esHGx-0008TM-2b for bug-gnu-emacs@gnu.org; Sat, 03 Mar 2018 19:13:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1esGWU-0000Fv-7o for bug-gnu-emacs@gnu.org; Sat, 03 Mar 2018 18:25:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: John Shahid Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 03 Mar 2018 23:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30610 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30610-submit@debbugs.gnu.org id=B30610.1520119454921 (code B ref 30610); Sat, 03 Mar 2018 23:25:02 +0000 Original-Received: (at 30610) by debbugs.gnu.org; 3 Mar 2018 23:24:14 +0000 Original-Received: from localhost ([127.0.0.1]:43314 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1esGVi-0000Em-Hy for submit@debbugs.gnu.org; Sat, 03 Mar 2018 18:24:14 -0500 Original-Received: from mail-qk0-f173.google.com ([209.85.220.173]:41582) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1esGVg-0000EX-H9 for 30610@debbugs.gnu.org; Sat, 03 Mar 2018 18:24:12 -0500 Original-Received: by mail-qk0-f173.google.com with SMTP id w142so16478596qkb.8 for <30610@debbugs.gnu.org>; Sat, 03 Mar 2018 15:24:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=YTx56wMmOh5PWmH+fPKNm8zK7XCPWyPNHNx0NH/9Kts=; b=Rxv/9/hrtEBKa0LjiyRWRvjZNnXyzrZtgYkNz0odPqf7tevBc7JN+baZW+BVOdf2JU rVaBTKygUlvvuJJvhtqWkrdyj9neH9OGnBaLplR8r8lTn67kN6qri5VGnT5d3sD5/YS8 pHjJd4IU1s9k/SK596vl/6bsEbMgO5+4PqAj7JaMsmMDkou8kJy8B2smzNe7MDTT6mO1 AgcqZIv4qXea7t85bBQIKtv849NF1AYQ7r0VyPjOIwmrcib5Q3CQtWyozG+f8aOA6aob 1jme+IeeTHAXcwYpRchTgY8IXjW4fQ2vmdPpXGhuff9rfK+mkUHy9KW3do1MgcYw5XST GuIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=YTx56wMmOh5PWmH+fPKNm8zK7XCPWyPNHNx0NH/9Kts=; b=atCGRnJRsBgl0+L9ZywNog1sK2/lWqn6s99ql0cny2lxuDeeO6voQRBQgT2g1WzNgQ QCBCf5eFr4Ttd3fILWd6HEYZH0UUFO+FogSQICJR4GRLFDp2bmW5J8ti7vBDAcja8ME5 5YoGxIaDjNoW1bShKc664rqpp4d57zjsTOTGjTuLsnhoir1jKChnIu/MMsZxYC+RrrVV Q8FFpEih07sLV9anhUpMO36jWlp+eYT2TWmE03WQbt2aRSnISDHxhe74YQ7/Bt6pE+JR SzwEQSF307acuyU8gkWbImMJCpfArjtXmKdRwUThUG30MF0mg0RAMTaKFATvHLu+590F MkIQ== X-Gm-Message-State: AElRT7FgWde8Q8RTfAERD1X0AAP0FVbLbQCpeTAphoyEcWTCxkTXVeba Rv7kUXZWztJTtdlOWn5UifiBL5u7 X-Google-Smtp-Source: AG47ELvOnWKWkfDR9bTUvYCuDQG6HTJZXD9Ivyb/04Gsh4mbeppRtcPGcC98qGL+hsNnh/nQvagGhQ== X-Received: by 10.55.5.6 with SMTP id 6mr15540100qkf.213.1520119446846; Sat, 03 Mar 2018 15:24:06 -0800 (PST) Original-Received: from amun (cpe-184-152-54-116.nyc.res.rr.com. [184.152.54.116]) by smtp.gmail.com with ESMTPSA id s4sm6900456qta.34.2018.03.03.15.24.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 03 Mar 2018 15:24:05 -0800 (PST) In-reply-to: <87a7vobvgg.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:143882 Archived-At: --=-=-= Content-Type: text/plain forgot to add asterisk before the file name. attached the new patch with the asterisk John Shahid writes: > Noam Postavsky writes: > >> John Shahid writes: >> >>> Worth noting that this is my first patch to Emacs. Let me know if >>> there's anything wrong with the way I submitted the patch. >> >> The patch looks fine, but the commit message should have a ChangeLog >> style entry as described in CONTRIBUTE under "Commit messages". > > fixed and attached a new patch > >> And if you haven't assigned copyright for Emacs, it should also have a >> 'Copyright-paperwork-exempt: yes' line. Note that we only accept up >> to 15 lines worth of unassigned patches. If you want to start the >> assignment process, fill out the form at [1] and send it to >> fsf-records@gnu.org (they will reply with further instructions). > > i filled out and sent the paper work. i also exempt this commit from the > paperwork since it is a very minor change. > > thanks, > > -js > > From 113b30d8739dc8d1673a53d06b201e6c9ea1a54a Mon Sep 17 00:00:00 2001 > From: John Shahid > Date: Sun, 25 Feb 2018 14:33:00 -0500 > Subject: [PATCH] lisp/linum.el: clarify linum-mode handling of `ARG' > > Copyright-paperwork-exempt: yes > --- > lisp/linum.el | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/lisp/linum.el b/lisp/linum.el > index 9df0c5d023..fa66d62bfe 100644 > --- a/lisp/linum.el > +++ b/lisp/linum.el > @@ -76,8 +76,12 @@ linum-delay > (define-minor-mode linum-mode > "Toggle display of line numbers in the left margin (Linum mode). > With a prefix argument ARG, enable Linum mode if ARG is positive, > -and disable it otherwise. If called from Lisp, enable the mode > -if ARG is omitted or nil. > +and disable it otherwise. > + > +When called from Lisp, toggles the mode if the argument is > +`toggle', disables the mode if the argument is a non-positive > +integer, and enables the mode otherwise (including if the > +argument is omitted or nil or a positive integer). > > Linum mode is a buffer-local minor mode." > :lighter "" ; for desktop.el --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-lisp-linum.el-clarify-linum-mode-handling-of-ARG.patch >From 7024af1df6fccedbdba1ea24337f417cbb03a6a2 Mon Sep 17 00:00:00 2001 From: John Shahid Date: Sun, 25 Feb 2018 14:33:00 -0500 Subject: [PATCH] * lisp/linum.el: clarify linum-mode handling of `ARG' Copyright-paperwork-exempt: yes --- lisp/linum.el | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/lisp/linum.el b/lisp/linum.el index 9df0c5d023..fa66d62bfe 100644 --- a/lisp/linum.el +++ b/lisp/linum.el @@ -76,8 +76,12 @@ linum-delay (define-minor-mode linum-mode "Toggle display of line numbers in the left margin (Linum mode). With a prefix argument ARG, enable Linum mode if ARG is positive, -and disable it otherwise. If called from Lisp, enable the mode -if ARG is omitted or nil. +and disable it otherwise. + +When called from Lisp, toggles the mode if the argument is +`toggle', disables the mode if the argument is a non-positive +integer, and enables the mode otherwise (including if the +argument is omitted or nil or a positive integer). Linum mode is a buffer-local minor mode." :lighter "" ; for desktop.el -- 2.16.2 --=-=-=--