all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: John Shahid <jvshahid@gmail.com>
To: Noam Postavsky <npostavs@gmail.com>
Cc: 30610@debbugs.gnu.org
Subject: bug#30610: clarify linux-mode usage from Lisp
Date: Sat, 03 Mar 2018 18:24:04 -0500	[thread overview]
Message-ID: <878tb8bv57.fsf@gmail.com> (raw)
In-Reply-To: <87a7vobvgg.fsf@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2191 bytes --]


forgot to add asterisk before the file name. attached the new patch with
the asterisk

John Shahid <jvshahid@gmail.com> writes:

> Noam Postavsky <npostavs@gmail.com> writes:
>
>> John Shahid <jvshahid@gmail.com> writes:
>>
>>> Worth noting that this is my first patch to Emacs. Let me know if
>>> there's anything wrong with the way I submitted the patch.
>>
>> The patch looks fine, but the commit message should have a ChangeLog
>> style entry as described in CONTRIBUTE under "Commit messages".
>
> fixed and attached a new patch
>
>> And if you haven't assigned copyright for Emacs, it should also have a
>> 'Copyright-paperwork-exempt: yes' line.  Note that we only accept up
>> to 15 lines worth of unassigned patches.  If you want to start the
>> assignment process, fill out the form at [1] and send it to
>> fsf-records@gnu.org (they will reply with further instructions).
>
> i filled out and sent the paper work. i also exempt this commit from the
> paperwork since it is a very minor change.
>
> thanks,
>
> -js
>
> From 113b30d8739dc8d1673a53d06b201e6c9ea1a54a Mon Sep 17 00:00:00 2001
> From: John Shahid <jvshahid@gmail.com>
> Date: Sun, 25 Feb 2018 14:33:00 -0500
> Subject: [PATCH] lisp/linum.el: clarify linum-mode handling of `ARG'
>
> Copyright-paperwork-exempt: yes
> ---
>  lisp/linum.el | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/lisp/linum.el b/lisp/linum.el
> index 9df0c5d023..fa66d62bfe 100644
> --- a/lisp/linum.el
> +++ b/lisp/linum.el
> @@ -76,8 +76,12 @@ linum-delay
>  (define-minor-mode linum-mode
>    "Toggle display of line numbers in the left margin (Linum mode).
>  With a prefix argument ARG, enable Linum mode if ARG is positive,
> -and disable it otherwise.  If called from Lisp, enable the mode
> -if ARG is omitted or nil.
> +and disable it otherwise.
> +
> +When called from Lisp, toggles the mode if the argument is
> +`toggle', disables the mode if the argument is a non-positive
> +integer, and enables the mode otherwise (including if the
> +argument is omitted or nil or a positive integer).
>  
>  Linum mode is a buffer-local minor mode."
>    :lighter ""                           ; for desktop.el


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-lisp-linum.el-clarify-linum-mode-handling-of-ARG.patch --]
[-- Type: text/x-diff, Size: 1120 bytes --]

From 7024af1df6fccedbdba1ea24337f417cbb03a6a2 Mon Sep 17 00:00:00 2001
From: John Shahid <jvshahid@gmail.com>
Date: Sun, 25 Feb 2018 14:33:00 -0500
Subject: [PATCH] * lisp/linum.el: clarify linum-mode handling of `ARG'

Copyright-paperwork-exempt: yes
---
 lisp/linum.el | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/lisp/linum.el b/lisp/linum.el
index 9df0c5d023..fa66d62bfe 100644
--- a/lisp/linum.el
+++ b/lisp/linum.el
@@ -76,8 +76,12 @@ linum-delay
 (define-minor-mode linum-mode
   "Toggle display of line numbers in the left margin (Linum mode).
 With a prefix argument ARG, enable Linum mode if ARG is positive,
-and disable it otherwise.  If called from Lisp, enable the mode
-if ARG is omitted or nil.
+and disable it otherwise.
+
+When called from Lisp, toggles the mode if the argument is
+`toggle', disables the mode if the argument is a non-positive
+integer, and enables the mode otherwise (including if the
+argument is omitted or nil or a positive integer).
 
 Linum mode is a buffer-local minor mode."
   :lighter ""                           ; for desktop.el
-- 
2.16.2


  reply	other threads:[~2018-03-03 23:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-25 19:55 bug#30610: clarify linux-mode usage from Lisp John Shahid
2018-02-25 20:12 ` John Shahid
2018-03-02  3:26   ` Noam Postavsky
2018-03-03 23:17     ` John Shahid
2018-03-03 23:24       ` John Shahid [this message]
2018-03-04  1:49         ` Glenn Morris
2018-03-04  2:14           ` John Shahid
2018-03-04  2:22     ` Glenn Morris
2018-03-04 17:40       ` John Shahid
2019-08-20 12:22 ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878tb8bv57.fsf@gmail.com \
    --to=jvshahid@gmail.com \
    --cc=30610@debbugs.gnu.org \
    --cc=npostavs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.