From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#29156: 25.3; eshell/kill does not understand -, [PATCH] Make eshell/kill handle - and - Date: Sat, 17 Mar 2018 10:43:04 -0400 Message-ID: <878taqvk3r.fsf@gmail.com> References: <87vaiprmg5.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: blaine.gmane.org 1521297730 29158 195.159.176.226 (17 Mar 2018 14:42:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 17 Mar 2018 14:42:10 +0000 (UTC) Cc: Eric Skoglund , Pierre Neidhardt To: 29156@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Mar 17 15:42:05 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1exD25-0007Tz-8z for geb-bug-gnu-emacs@m.gmane.org; Sat, 17 Mar 2018 15:42:05 +0100 Original-Received: from localhost ([::1]:33942 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1exD47-0005SQ-Nt for geb-bug-gnu-emacs@m.gmane.org; Sat, 17 Mar 2018 10:44:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55689) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1exD41-0005SD-EG for bug-gnu-emacs@gnu.org; Sat, 17 Mar 2018 10:44:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1exD3y-0000UG-A2 for bug-gnu-emacs@gnu.org; Sat, 17 Mar 2018 10:44:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:58897) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1exD3y-0000U3-3j for bug-gnu-emacs@gnu.org; Sat, 17 Mar 2018 10:44:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1exD3x-0000Be-Sf for bug-gnu-emacs@gnu.org; Sat, 17 Mar 2018 10:44:01 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <87vaiprmg5.fsf@gmail.com> Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Mar 2018 14:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29156 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed easy Original-Received: via spool by 29156-submit@debbugs.gnu.org id=B29156.1521297793649 (code B ref 29156); Sat, 17 Mar 2018 14:44:01 +0000 Original-Received: (at 29156) by debbugs.gnu.org; 17 Mar 2018 14:43:13 +0000 Original-Received: from localhost ([127.0.0.1]:38561 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1exD3B-0000AP-2p for submit@debbugs.gnu.org; Sat, 17 Mar 2018 10:43:13 -0400 Original-Received: from mail-io0-f172.google.com ([209.85.223.172]:39425) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1exD39-0000AB-Rw for 29156@debbugs.gnu.org; Sat, 17 Mar 2018 10:43:12 -0400 Original-Received: by mail-io0-f172.google.com with SMTP id v13so2193305iob.6 for <29156@debbugs.gnu.org>; Sat, 17 Mar 2018 07:43:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version; bh=JKBeIEpPiqNQ/umeMPDM5GQzNphnapMRXC/sZT/QBcY=; b=Kg0CmRokIXtffTN/w77PMh4WKz1nvK9w/qH9h3shOhiPNoS9IBPeQ4ozbkunn7+57o oHUAA6622Jw+vB5/8Kg37h9cVvmvkHKoA6HN4jDzgU8sjr9Sun/ca6gc5Cc6LYNjPzcT bbd1G3EACBi6edvOx5n6Vm6NDID90fI9Agzctlu6eceoD4CmD4qxtToNBQ8OFopyln04 XV/5OZP8yh4+0SQJYsro4DaWWqgvUJ5WdMYjHkSvKDx8Wl19ycVOR+NDuzs5+s+cGKK8 gGHpDveoExgECgytWLOxeHELhxgw9PKfQwvs4hGydoVYNjwnvkRDyq+9B5AB2dO4ctBh 6XSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version; bh=JKBeIEpPiqNQ/umeMPDM5GQzNphnapMRXC/sZT/QBcY=; b=BtIKWeVSdAsph0hMS2bDnXWKUr5jf/ZXy2k7K7vhM+cmgdpp43zXwidNhOKPSHIbhj JR22uC5XRsT/Dhc9KBV1wn5QPbeYq00INvod67SDXr9Nh4NDMvTMT/N+5p8D7yGV10/4 +YUfU/2l//v188pEaE43zI3q6wQ7rIAuA5ySBKZX8n1uTVMPID2CtioJqVS+RxTu5Qv+ 26fM4JTH4HsLm61Dw1YetJYPMriAOcTAYXXaRC8VAttVllQ21Bx0zJSuL0T+kCug3jpS JC2tDuVlEGHeVRTgP6rN+XUo/kJj2tx/GQb0f8gghicdh/NqT1PCKJWhS+GXTjmp7hUA +gew== X-Gm-Message-State: AElRT7ECUdHHVzM0G7lXGohJyEC6YQmZFJCDLTzLUAc+427xjhDyqZVL dc0SNu4nK3LXLcU/7XHTiQs= X-Google-Smtp-Source: AG47ELutRhjvurWZa4ZBMhnq60G4VmByZ/Wj5efehQZvSqwez0gB3glzFvvnyPYyFh5QqVOkONFk1g== X-Received: by 10.107.183.4 with SMTP id h4mr5869388iof.201.1521297786337; Sat, 17 Mar 2018 07:43:06 -0700 (PDT) Original-Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id k199sm6013423itb.35.2018.03.17.07.43.04 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 17 Mar 2018 07:43:05 -0700 (PDT) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:144365 Archived-At: --=-=-= Content-Type: text/plain [forwarding to list, please use "Reply All" to keep 29156@debbugs.gnu.org on Cc] --=-=-= Content-Type: message/rfc822 Content-Disposition: inline From: Eric Skoglund To: Noam Postavsky Subject: Re: bug#29156: 25.3; eshell/kill does not understand -, [PATCH] Make eshell/kill handle - and - References: <87vaiprmg5.fsf@gmail.com> <87o9jnv9et.fsf@gmail.com> <87lgerv8tq.fsf@gmail.com> Date: Sat, 17 Mar 2018 15:11:41 +0100 In-Reply-To: <87lgerv8tq.fsf@gmail.com> (Noam Postavsky's message of "Fri, 16 Mar 2018 20:34:25 -0400") Message-ID: <877eqa7pwi.fsf@pagefault.se> MIME-Version: 1.0 Content-Type: text/plain Thanks for the review! > More importantly, could you explain a bit how your change works/why it's > correct? I'm guessing you mean in the commit message and not here in the bug report right? > Not sure this `make-symbol' call, should it rather be `intern'? (Maybe > we should update signal-process take a string as well a symbol.) Saw that Eli also agreed, for future reference when do we want to use `make-symbol` vs `intern`? > I think the args have already been converted to numbers, or did you mean > to also add a (put 'eshell/kill 'eshell-no-numeric-conversions t)? Yes indeed. I'm unsure how I managed to lose that in git... // Eric --=-=-=--