bug#29156: 25.3; eshell/kill does not understand -<signal>, [PATCH] Make eshell/kill handle -<signal> and -<SIGNALNAME>

[Noam Postavsky <npostavs@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 82 bytes --]

[forwarding to list, please use "Reply All" to keep 29156@debbugs.gnu.org on Cc]


[-- Attachment #2: Type: message/rfc822, Size: 1183 bytes --]

From: Eric Skoglund <eric@pagefault.se>
To: Noam Postavsky <npostavs@gmail.com>
Subject: Re: bug#29156: 25.3; eshell/kill does not understand -<signal>, [PATCH] Make eshell/kill handle -<signal> and -<SIGNALNAME>
Date: Sat, 17 Mar 2018 15:11:41 +0100
Message-ID: <877eqa7pwi.fsf@pagefault.se>


Thanks for the review!

> More importantly, could you explain a bit how your change works/why it's
> correct?

I'm guessing you mean in the commit message and not here in the bug
report right?

> Not sure this `make-symbol' call, should it rather be `intern'?  (Maybe
> we should update signal-process take a string as well a symbol.)

Saw that Eli also agreed, for future reference when do we want to use
`make-symbol` vs `intern`?

> I think the args have already been converted to numbers, or did you mean
> to also add a (put 'eshell/kill 'eshell-no-numeric-conversions t)?

Yes indeed. I'm unsure how I managed to lose that in git...

// Eric