From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#30786: Save text properties in desktop Date: Wed, 04 Apr 2018 23:01:02 +0300 Organization: LINKOV.NET Message-ID: <878ta2zqpt.fsf@mail.linkov.net> References: <87k1uhnehk.fsf@mail.linkov.net> <87o9jsydtz.fsf@gmail.com> <877eqfabjv.fsf@mail.linkov.net> <87vadzwffx.fsf@gmail.com> <877eppv8yu.fsf@mail.linkov.net> <87370dp9eu.fsf@gmail.com> <87efjw59tp.fsf@mail.linkov.net> <87po3gne5d.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1522872248 9241 195.159.176.226 (4 Apr 2018 20:04:08 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 4 Apr 2018 20:04:08 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: 30786@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Apr 04 22:04:04 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f3odX-0002IE-9e for geb-bug-gnu-emacs@m.gmane.org; Wed, 04 Apr 2018 22:04:03 +0200 Original-Received: from localhost ([::1]:54874 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f3ofc-0005re-O0 for geb-bug-gnu-emacs@m.gmane.org; Wed, 04 Apr 2018 16:06:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34835) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f3odY-0004Bf-3l for bug-gnu-emacs@gnu.org; Wed, 04 Apr 2018 16:04:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f3odW-0006BJ-OZ for bug-gnu-emacs@gnu.org; Wed, 04 Apr 2018 16:04:04 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:58997) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f3odW-0006BF-L5 for bug-gnu-emacs@gnu.org; Wed, 04 Apr 2018 16:04:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1f3odW-0001pY-Ar for bug-gnu-emacs@gnu.org; Wed, 04 Apr 2018 16:04:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 04 Apr 2018 20:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30786 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30786-submit@debbugs.gnu.org id=B30786.15228722337021 (code B ref 30786); Wed, 04 Apr 2018 20:04:02 +0000 Original-Received: (at 30786) by debbugs.gnu.org; 4 Apr 2018 20:03:53 +0000 Original-Received: from localhost ([127.0.0.1]:38661 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f3odN-0001pB-1W for submit@debbugs.gnu.org; Wed, 04 Apr 2018 16:03:53 -0400 Original-Received: from sub3.mail.dreamhost.com ([69.163.253.7]:46542 helo=homiemail-a19.g.dreamhost.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f3odL-0001p3-Kx for 30786@debbugs.gnu.org; Wed, 04 Apr 2018 16:03:51 -0400 Original-Received: from homiemail-a19.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a19.g.dreamhost.com (Postfix) with ESMTP id D5454604076; Wed, 4 Apr 2018 13:03:50 -0700 (PDT) Original-Received: from localhost.linkov.net (m91-129-105-236.cust.tele2.ee [91.129.105.236]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by homiemail-a19.g.dreamhost.com (Postfix) with ESMTPSA id BF57760406B; Wed, 4 Apr 2018 13:03:49 -0700 (PDT) In-Reply-To: <87po3gne5d.fsf@gmail.com> (Noam Postavsky's message of "Tue, 03 Apr 2018 18:01:02 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:144904 Archived-At: >>>> Do you think this patch covers all possible unreadable cases on writ= ing? >>>> >>>> + ;; Get rid of unreadable text properties. >>>> + (if (ignore-errors (read (format "%S" value))) >>>> + (cons 'may value) >>>> + (let ((copy (copy-sequence value))) >>>> + (set-text-properties 0 (length copy) nil copy) >>>> + (cons 'may copy)))) >>> >>> I think it won't cover the case where an object's print syntax is onl= y >>> readable by the current Emacs version, and not an earlier one. To >>> handle that you'll need to call desktop--v2s recursively, like in the >>> vectorp and consp branches. >> >> I don't understand how calling desktop--v2s recursively will ensure it= s >> readability in earlier versions? For example, if Emacs 27 will write = to >> the desktop file =E2=80=98#("foo" 0 3 (bar 42))=E2=80=99 how Emacs 19 = can read it? > > Ah, I wasn't thinking of the #(...) specifically, rather about the > values of text properties, e.g., > > (cl-defstruct foo f1 f2) > (desktop--v2s (make-foo :f1 1 :f2 2)) ;=3D> (may . "Unprintable ent= ity") > > So desktop--v2s considers structs as unprintable, unlike read, hence > using desktop--v2s recursively instead of read will catch properties > that would otherwise be unreadable in Emacs 25. > > If we want to support Emacs versions that don't even know about #(...) > then we can't write string properties at all, I guess. If we can afford continuing incrementing the desktop file version in =E2=80=98desktop-file-version=E2=80=99 doing this every time when support= for reading more syntaxes is added, thus preventing incompatibilities, then the patch abov= e would be the most reliable solution.