From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#30072: 27.0.50; completing-read-multiple chokes on list of default values Date: Wed, 11 Apr 2018 12:36:07 +0100 Message-ID: <878t9uf00o.fsf@tcd.ie> References: <878td5pf80.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: blaine.gmane.org 1523446521 11586 195.159.176.226 (11 Apr 2018 11:35:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 11 Apr 2018 11:35:21 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: 30072@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Apr 11 13:35:17 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f6E20-0002qz-HC for geb-bug-gnu-emacs@m.gmane.org; Wed, 11 Apr 2018 13:35:16 +0200 Original-Received: from localhost ([::1]:47925 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f6E3v-0005ns-MN for geb-bug-gnu-emacs@m.gmane.org; Wed, 11 Apr 2018 07:37:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43025) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f6E3m-0005mL-3j for bug-gnu-emacs@gnu.org; Wed, 11 Apr 2018 07:37:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f6E3j-0008DJ-1e for bug-gnu-emacs@gnu.org; Wed, 11 Apr 2018 07:37:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37863) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f6E3i-0008D9-T0 for bug-gnu-emacs@gnu.org; Wed, 11 Apr 2018 07:37:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1f6E3i-0008Hf-EG for bug-gnu-emacs@gnu.org; Wed, 11 Apr 2018 07:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 11 Apr 2018 11:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30072 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 30072-submit@debbugs.gnu.org id=B30072.152344657831782 (code B ref 30072); Wed, 11 Apr 2018 11:37:02 +0000 Original-Received: (at 30072) by debbugs.gnu.org; 11 Apr 2018 11:36:18 +0000 Original-Received: from localhost ([127.0.0.1]:45760 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f6E30-0008GY-GB for submit@debbugs.gnu.org; Wed, 11 Apr 2018 07:36:18 -0400 Original-Received: from mail-wm0-f44.google.com ([74.125.82.44]:54654) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f6E2z-0008GM-GV for 30072@debbugs.gnu.org; Wed, 11 Apr 2018 07:36:17 -0400 Original-Received: by mail-wm0-f44.google.com with SMTP id r191so3443680wmg.4 for <30072@debbugs.gnu.org>; Wed, 11 Apr 2018 04:36:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:subject:references:date:in-reply-to:message-id:user-agent :mime-version; bh=WreY+oLVbLQdOBvt1Vhe0UMTBDN+/2VZQ5roER6957o=; b=CbQyzPjpmnTT3tdcfdLCjluDZDTKrflVruqjf+lebRf5fEFvM/6zH2o2qEASblckD8 w4bGlI9vOFgzxQkipHyIgyWa4BDeIOVzmImIg8OoY99ORaarcqtWWEBSGvA6caE7otLT 3+Yj92I+203SwPSsFBrCfrFymk21SKNOxuP/roIJQjGf7Riq4kAE8u3adh69lSHWNjEE nyl/zUCPLHjLxXt5rYzNQAi7Y40mFn7K00EBZH4uaIyQWkCzsvz9fza0UqiQKUeLNL9X bCfUDovcunC9jAdhj8QL1ffg4r/8Z8Kp5Gv7rWYwdmH5u4vYg8TG4WraVu4p81hrhepf 1jkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=WreY+oLVbLQdOBvt1Vhe0UMTBDN+/2VZQ5roER6957o=; b=DrhhBBUHud5pni3zEZxl/SYyiymZAVoSPi8KNAF8ZHFTWvaviXJCQmz8Ul0Y+JRIac MNeQeH8fvaiZGTngZoLqmWo/aaxPsR7rBp7fnOh7xAUc3XdxHlV8PkeX1LfJ4RMX4uNQ pWH++6+k9exVssf4Oej4ir2PWVpe/H4mRL+Z6b9fVeHljLKn6Eo0CZXdRtkqgTTxEHDB xSWUgKQ5SaodXXjV+GaOORG9AgKhrq8ML9iBSCj6Wr7neFwXzvKANCn8AKuwzCPqpmgM tKIxkc/mxvQ2cqyJAdWfYjOTEL8nNpSF7oP6yxySqzosWskBnB441wBELFBR0/qzqhVC U3aQ== X-Gm-Message-State: ALQs6tAgw2dGQ+9UnboBZ8Bp9xck2Sa+FiO2+yLTlILn8CEidrpZUChC sT17cZwDBw9zZIh7Pqd5gbEL+Gsoz8Y= X-Google-Smtp-Source: AIpwx49VrgBG3y1uOfwHl/eRpPnpCqtgj+YJHjNodlvfVac9FagkEEzVaJJ+fVGNa3gTuHd3xU5+JA== X-Received: by 10.28.128.145 with SMTP id b139mr2194688wmd.62.1523446571652; Wed, 11 Apr 2018 04:36:11 -0700 (PDT) Original-Received: from localhost ([178.62.40.52]) by smtp.gmail.com with ESMTPSA id k14sm1371234wrc.62.2018.04.11.04.36.09 for <30072@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 11 Apr 2018 04:36:10 -0700 (PDT) In-Reply-To: <878td5pf80.fsf@gmail.com> (Basil L. Contovounesios's message of "Wed, 10 Jan 2018 21:37:51 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:145070 Archived-At: --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Support-list-of-default-values-in-completing-read-mu.patch >From 7a33c02e2815e0a9625ffc48f3850894522169b6 Mon Sep 17 00:00:00 2001 From: "Basil L. Contovounesios" Date: Wed, 10 Jan 2018 20:21:25 +0000 Subject: [PATCH] Support list of default values in completing-read-multiple * lisp/emacs-lisp/crm.el (completing-read-multiple): Consider head of DEF argument when specified as a list, as per completing-read-default. (bug#30072) --- lisp/emacs-lisp/crm.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lisp/emacs-lisp/crm.el b/lisp/emacs-lisp/crm.el index 5aa856f467..1a67494d3c 100644 --- a/lisp/emacs-lisp/crm.el +++ b/lisp/emacs-lisp/crm.el @@ -263,7 +263,8 @@ completing-read-multiple (input (read-from-minibuffer prompt initial-input map nil hist def inherit-input-method))) - (and def (string-equal input "") (setq input def)) + (when (and def (string-equal input "")) + (setq input (if (consp def) (car def) def))) ;; Remove empty strings in the list of read strings. (split-string input crm-separator t))) (remove-hook 'choose-completion-string-functions -- 2.16.3 --=-=-= Content-Type: text/plain "Basil L. Contovounesios" writes: > I attach a fix which follows the implementation of > completing-read-default. Updated to include bug ticket number. Thanks, -- Basil --=-=-=--