From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#31373: 26.1; frame-list-z-order segfaults on initial daemon frame Date: Sun, 06 May 2018 13:09:33 -0400 Message-ID: <878t8wn22a.fsf@gmail.com> References: <87sh747vsf.fsf@tcd.ie> <87efiona6i.fsf@gmail.com> <87muxcomoy.fsf@tcd.ie> <87bmdsn3z3.fsf@gmail.com> <8336z4sp8x.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1525626486 29337 195.159.176.226 (6 May 2018 17:08:06 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 6 May 2018 17:08:06 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: 31373@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun May 06 19:08:02 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fFN8j-0007W3-7Z for geb-bug-gnu-emacs@m.gmane.org; Sun, 06 May 2018 19:08:01 +0200 Original-Received: from localhost ([::1]:42773 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fFNAq-0005wp-7v for geb-bug-gnu-emacs@m.gmane.org; Sun, 06 May 2018 13:10:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45245) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fFNAj-0005wW-Ow for bug-gnu-emacs@gnu.org; Sun, 06 May 2018 13:10:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fFNAg-0006Yb-J3 for bug-gnu-emacs@gnu.org; Sun, 06 May 2018 13:10:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:43694) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fFNAg-0006YW-Ez for bug-gnu-emacs@gnu.org; Sun, 06 May 2018 13:10:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fFNAg-0007VJ-6j for bug-gnu-emacs@gnu.org; Sun, 06 May 2018 13:10:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 06 May 2018 17:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31373 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 31373-submit@debbugs.gnu.org id=B31373.152562658228815 (code B ref 31373); Sun, 06 May 2018 17:10:02 +0000 Original-Received: (at 31373) by debbugs.gnu.org; 6 May 2018 17:09:42 +0000 Original-Received: from localhost ([127.0.0.1]:51591 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fFNAM-0007Ug-Ge for submit@debbugs.gnu.org; Sun, 06 May 2018 13:09:42 -0400 Original-Received: from mail-it0-f53.google.com ([209.85.214.53]:52794) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fFNAL-0007UT-0w for 31373@debbugs.gnu.org; Sun, 06 May 2018 13:09:41 -0400 Original-Received: by mail-it0-f53.google.com with SMTP id y189-v6so2769946itb.2 for <31373@debbugs.gnu.org>; Sun, 06 May 2018 10:09:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=1/Hy815WdCY8PEI/TxUGC6yrmYGZnvR+NAKO5NF9gUg=; b=K6RjMwO9RJUPEiSoEwukAMguL6mt+o3GcdnIiJVeC8J62zoPycNqqF4UpLRfyFX9Xi e83ifpwfeVL+DEQAGAEQ/oRMqQw2zO3JV+Fha560Jrcnzt3Cu5akdViEcsTwyk3M2ztZ zR81CyW3YZnvvZgH3RRbqlXBA5rv3oQIqxdjo5VJ1VeKy1zrF4KXzWaccgT695K477/Z RF7EwmjxwPI1SyOx7oJiUAsNGM4tOx6gPt6Z33xiyEtMwAA+WZMENOTu5mavO23W9ePD uyw61WwWCJAvlcqxuL5PzArDGb4czbC6LdBmgbqSovM9JbAHsiTzSKq/hLw/8hG0izMb h2pA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=1/Hy815WdCY8PEI/TxUGC6yrmYGZnvR+NAKO5NF9gUg=; b=hDzPssNS+Lkq1muJ78jo6tJm5OR7cJjbpcj3h0HabQuVfMyssNBkrSQ+hythBvxhNn m3pznOAtv/oKqrtW+1U1pWmh+8O8EWDeHA2BA/c8gYmRvLQ3iTQvY6spGnm+ifbcAYq6 sWBC5axM/J7T8++6PBgEtoVsqab2gYxSVjIiJvYuSfx88NrX2uY7rPvzHdHRc8uezCxB wEtcZ+HsBJ4VC02JaeULomVPP+VkNmOXhzw0go+zn46jGBwRI5irAyX29Umx/Qa2E6Cv +YueoNDylZ4BRdwxhe8QH+SswHQUgWAULqP+ik32PIk9JEV+sueB3RFhFJM83yGyWGx2 fd4Q== X-Gm-Message-State: ALQs6tAXYfb9WINXKGJLIqucqK9pA1nQ0CeTOoDstKDg/uYsN5eGcYL0 w1cEfxtDrGjsy5dVUvi/WIuiSQ== X-Google-Smtp-Source: AB8JxZpNhgeDMRkLJwzIB7ReDOCdW/1MUvlIzLK47mJ6O7Rn5jskJez7Ak1X6tOO7Vl8kbkrq/c6Hg== X-Received: by 2002:a24:b803:: with SMTP id m3-v6mr34902557ite.131.1525626575340; Sun, 06 May 2018 10:09:35 -0700 (PDT) Original-Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id m38-v6sm10875681ioi.30.2018.05.06.10.09.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 06 May 2018 10:09:34 -0700 (PDT) In-Reply-To: <8336z4sp8x.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 06 May 2018 19:49:50 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:146050 Archived-At: Eli Zaretskii writes: >> From: Noam Postavsky >> Date: Sun, 06 May 2018 12:28:16 -0400 >> >> >> + if (XFRAME (frame)->output_method == output_x_window >> >> Also, I noticed that there is FRAME_X_P for this. I can't find any more >> obvious instances of missing this check, although it's hard to tell in >> many cases if the frame is really guaranteed to have output_x_window has >> the output_method. > > Don't we usually signal an error in such cases? Through > check_x_display_info or somesuch? Fx_frame_list_z_order already has a check_x_display_info call, but the FRAME_X_P check is needed when looping over all the frames, like in xic_create_xfontset and x_make_monitor_attribute_list. Perhaps a FOR_EACH_FRAME_IN_TERMINAL macro would be less error-prone?