From: Noam Postavsky <npostavs@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 31373@debbugs.gnu.org
Subject: bug#31373: 26.1; frame-list-z-order segfaults on initial daemon frame
Date: Sun, 06 May 2018 13:09:33 -0400 [thread overview]
Message-ID: <878t8wn22a.fsf@gmail.com> (raw)
In-Reply-To: <8336z4sp8x.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 06 May 2018 19:49:50 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Noam Postavsky <npostavs@gmail.com>
>> Date: Sun, 06 May 2018 12:28:16 -0400
>>
>> >> + if (XFRAME (frame)->output_method == output_x_window
>>
>> Also, I noticed that there is FRAME_X_P for this. I can't find any more
>> obvious instances of missing this check, although it's hard to tell in
>> many cases if the frame is really guaranteed to have output_x_window has
>> the output_method.
>
> Don't we usually signal an error in such cases? Through
> check_x_display_info or somesuch?
Fx_frame_list_z_order already has a check_x_display_info call, but the
FRAME_X_P check is needed when looping over all the frames, like in
xic_create_xfontset and x_make_monitor_attribute_list.
Perhaps a FOR_EACH_FRAME_IN_TERMINAL macro would be less error-prone?
next prev parent reply other threads:[~2018-05-06 17:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-06 13:34 bug#31373: 26.1; frame-list-z-order segfaults on initial daemon frame Basil L. Contovounesios
2018-05-06 14:14 ` Noam Postavsky
2018-05-06 14:58 ` Basil L. Contovounesios
2018-05-06 16:28 ` Noam Postavsky
2018-05-06 16:49 ` Eli Zaretskii
2018-05-06 17:09 ` Noam Postavsky [this message]
2018-05-06 17:03 ` Basil L. Contovounesios
2018-05-11 2:51 ` Noam Postavsky
2018-05-11 8:29 ` Basil L. Contovounesios
2018-05-07 6:26 ` martin rudalics
2018-05-07 17:59 ` Eli Zaretskii
2018-05-07 18:08 ` Noam Postavsky
2018-05-07 19:30 ` Eli Zaretskii
2018-05-08 1:40 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878t8wn22a.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=31373@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.