Bug: org-toggle-tag always marks buffer modified [9.1.13 (9.1.13-elpaplus @ .emacs.d/elpa/org-plus-contrib-20180618/)]

Bug: org-toggle-tag always marks buffer modified [9.1.13 (9.1.13-elpaplus @ .emacs.d/elpa/org-plus-contrib-20180618/)]

[Allen Li]

org-toggle-tag always marks the buffer as modified due to how it is
implemented.  It would be better if it did not mark the buffer
modified if it does not change anything.  This is annoying for
org-depend.el (which is contrib, not officially supported) because the
org-blocker-hook set by org-depend.el will mark the buffer modified
whenever an agenda view is built/refreshed.

Glancing at org-toggle-tag, the feature isn't difficult to implement,
but it'll be ugly.

Emacs  : GNU Emacs 26.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version
3.22.24), modified by Debian
Package: Org mode version 9.1.13 (9.1.13-elpaplus @
/usr/local/google/home/ayatane/.emacs.d/elpa/org-plus-contrib-20180618/)

Re: Bug: org-toggle-tag always marks buffer modified [9.1.13 (9.1.13-elpaplus @ .emacs.d/elpa/org-plus-contrib-20180618/)]

[Nicolas Goaziou]

Hello,

Allen Li <darkfeline@felesatra.moe> writes:

> org-toggle-tag always marks the buffer as modified due to how it is
> implemented.  It would be better if it did not mark the buffer
> modified if it does not change anything.  This is annoying for
> org-depend.el (which is contrib, not officially supported) because the
> org-blocker-hook set by org-depend.el will mark the buffer modified
> whenever an agenda view is built/refreshed.

Fixed. Thank you.

Regards,

-- 
Nicolas Goaziou

Re: Bug: org-toggle-tag always marks buffer modified [9.1.13 (9.1.13-elpaplus @ .emacs.d/elpa/org-plus-contrib-20180618/)]

[Bernt Hansen]

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> Allen Li <darkfeline@felesatra.moe> writes:
>
>> org-toggle-tag always marks the buffer as modified due to how it is
>> implemented.  It would be better if it did not mark the buffer
>> modified if it does not change anything.  This is annoying for
>> org-depend.el (which is contrib, not officially supported) because the
>> org-blocker-hook set by org-depend.el will mark the buffer modified
>> whenever an agenda view is built/refreshed.
>
> Fixed. Thank you.

Hi Nicholas,

This fix breaks my capture templates.

commit 593058e4a6270f52fdede2b871a0ee6504944f13
Author: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Date:   Tue Jun 19 09:40:00 2018 +0200

    `org-set-tags' modifies buffer only when necessary

    * lisp/org.el (org--align-tags-here):
    (org-set-tags): Modify buffer only when necessary.

    * testing/lisp/test-org.el (test-org/set-tags): Add tests.

    Reported-by: Allen Li <darkfeline@felesatra.moe>
    <http://lists.gnu.org/r/emacs-orgmode/2018-06/msg00242.html>



I have reverted it locally and it works again.

My normal TODO capture template doesn't allow SPC to separate words when
entering the new headline for the task.

The relevant capture template entry is

(setq org-capture-templates
      (quote (("t" "Todo" entry (file "C:/D-Drive/org/refile.org")
             "* TODO %?\n%U\n\n%x\n" :clock-in t :clock-resume t)
...

After opening the capture window and point is moved to the %? position I
type the headline but SPC no longer enters a space.  C-v SPC works but
that is inconvenient.

Thanks,
Bernt

Re: Bug: org-toggle-tag always marks buffer modified [9.1.13 (9.1.13-elpaplus @ .emacs.d/elpa/org-plus-contrib-20180618/)]

[Bernt Hansen]

Hi Nicolas,

Please disregard this bug report.  I can't reproduce it anymore after an
Emacs restart.

Sorry for the noise.

Regards,
Bernt

Bernt Hansen <bernt@norang.ca> writes:

> Hi Nicholas,
>
> This fix breaks my capture templates.
>
> commit 593058e4a6270f52fdede2b871a0ee6504944f13
> Author: Nicolas Goaziou <mail@nicolasgoaziou.fr>
> Date:   Tue Jun 19 09:40:00 2018 +0200

Re: Bug: org-toggle-tag always marks buffer modified [9.1.13 (9.1.13-elpaplus @ .emacs.d/elpa/org-plus-contrib-20180618/)]

[Bernt Hansen]

Hi Nicolas,

This problem still exists when the capture template includes TAGS

In the below capture-templates definition the "t" (todo) template works
fine but the "m" Meeting template does not allow SPC to enter a space
between words when entering the headling for the meeting task.

(setq org-capture-templates
      (quote (("t" "Todo" entry (file "C:/D-Drive/org/refile.org")
             "* TODO %?\n%U\n\n%x\n" :clock-in t :clock-resume t)
                   ("m" "Meeting" entry (file
      "C:/D-Drive/org/refile.org")
             "* TODO %? :MEETING:\n%U\n\n" :clock-in t :clock-resume
      t))))

Thanks,
Bernt

Bernt Hansen <bernt@norang.ca> writes:

> Hi Nicolas,
>
> Please disregard this bug report.  I can't reproduce it anymore after an
> Emacs restart.
>
> Sorry for the noise.
>
> Regards,
> Bernt
>
> Bernt Hansen <bernt@norang.ca> writes:
>
>> Hi Nicholas,
>>
>> This fix breaks my capture templates.
>>
>> commit 593058e4a6270f52fdede2b871a0ee6504944f13
>> Author: Nicolas Goaziou <mail@nicolasgoaziou.fr>
>> Date:   Tue Jun 19 09:40:00 2018 +0200

Re: Bug: org-toggle-tag always marks buffer modified [9.1.13 (9.1.13-elpaplus @ .emacs.d/elpa/org-plus-contrib-20180618/)]

[Nicolas Goaziou]

Hello,

Bernt Hansen <bernt@norang.ca> writes:

> This problem still exists when the capture template includes TAGS
>
> In the below capture-templates definition the "t" (todo) template works
> fine but the "m" Meeting template does not allow SPC to enter a space
> between words when entering the headling for the meeting task.
>
> (setq org-capture-templates
>       (quote (("t" "Todo" entry (file "C:/D-Drive/org/refile.org")
>              "* TODO %?\n%U\n\n%x\n" :clock-in t :clock-resume t)
>                    ("m" "Meeting" entry (file
>       "C:/D-Drive/org/refile.org")
>              "* TODO %? :MEETING:\n%U\n\n" :clock-in t :clock-resume
>       t))))

I re-introduced the problem recently. This is now fixed, with
a regression test for good measure.

Thank you.

Regards,

-- 
Nicolas Goaziou                                                0x80A93738

Re: Bug: org-toggle-tag always marks buffer modified [9.1.13 (9.1.13-elpaplus @ .emacs.d/elpa/org-plus-contrib-20180618/)]

[Bernt Hansen]

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> Bernt Hansen <bernt@norang.ca> writes:
>
>> This problem still exists when the capture template includes TAGS
>>
>> In the below capture-templates definition the "t" (todo) template works
>> fine but the "m" Meeting template does not allow SPC to enter a space
>> between words when entering the headling for the meeting task.
>>
>> (setq org-capture-templates
>>       (quote (("t" "Todo" entry (file "C:/D-Drive/org/refile.org")
>>              "* TODO %?\n%U\n\n%x\n" :clock-in t :clock-resume t)
>>                    ("m" "Meeting" entry (file
>>       "C:/D-Drive/org/refile.org")
>>              "* TODO %? :MEETING:\n%U\n\n" :clock-in t :clock-resume
>>       t))))
>
> I re-introduced the problem recently. This is now fixed, with
> a regression test for good measure.

Fix confirmed :)

Thanks,
Bernt