From: Noam Postavsky <npostavs@gmail.com>
To: Sergey Vinokurov <serg.foo@gmail.com>
Cc: 32479@debbugs.gnu.org
Subject: bug#32479: Fix tracking of freed emacs_values with enabled --module-assertions
Date: Sat, 25 Aug 2018 19:03:02 -0400 [thread overview]
Message-ID: <878t4uuk0p.fsf@gmail.com> (raw)
In-Reply-To: <05d6bad8-a739-8fcc-bd32-1291423c85a5@gmail.com> (Sergey Vinokurov's message of "Mon, 20 Aug 2018 09:27:46 +0100")
tags 32479 fixed
close 32479 26.2
quit
Sergey Vinokurov <serg.foo@gmail.com> writes:
> I was developing a dynamic module when I noticed that when
> '--module-assertions' are enabled I got strange complaints regarding
> value to be freed. Namely, Emacs was producing an error message like the
> following one:
>
> Emacs module assertion: Global value was not found in list of 10 globals
>
> I tracked it down to a bug in module_free_global_ref. It's traversal of
> the linked list of all allocated global values was flawed and only
> considered the head of the list. Please find attached my attempt at
> fixing it and a test in Emacs test suite that reproduces the issue.
Thanks, pushed to emacs-26.
P.S. Don't forget to end sentences with a period in the body of the
commit message.
[1: 54fb383af6]: 2018-08-25 18:57:56 -0400
Fix detection of freed emacs_values (Bug#32479)
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=54fb383af6f6af7b72c28f38b308d9b24d2af4f6
prev parent reply other threads:[~2018-08-25 23:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-20 8:27 bug#32479: Fix tracking of freed emacs_values with enabled --module-assertions Sergey Vinokurov
2018-08-25 23:03 ` Noam Postavsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878t4uuk0p.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=32479@debbugs.gnu.org \
--cc=serg.foo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.