From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Karl Fogel Newsgroups: gmane.emacs.devel Subject: Re: feature proposal? add-change-log-entry does not find the ChangeLog file: change-log-directory-files Date: Tue, 04 Sep 2018 12:11:58 -0500 Message-ID: <878t4h4275.fsf@red-bean.com> References: <874lf5ft4f.fsf@mat.ucm.es> Reply-To: Karl Fogel NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1536081787 15092 195.159.176.226 (4 Sep 2018 17:23:07 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 4 Sep 2018 17:23:07 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Sep 04 19:23:03 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fxF2d-0003o2-1b for ged-emacs-devel@m.gmane.org; Tue, 04 Sep 2018 19:23:03 +0200 Original-Received: from localhost ([::1]:51963 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fxF4j-0006Wo-E8 for ged-emacs-devel@m.gmane.org; Tue, 04 Sep 2018 13:25:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54100) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fxErz-0006gD-9b for emacs-devel@gnu.org; Tue, 04 Sep 2018 13:12:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fxEry-00048M-6X for emacs-devel@gnu.org; Tue, 04 Sep 2018 13:12:03 -0400 Original-Received: from mail-oi0-x230.google.com ([2607:f8b0:4003:c06::230]:43682) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fxEry-00046T-0a for emacs-devel@gnu.org; Tue, 04 Sep 2018 13:12:02 -0400 Original-Received: by mail-oi0-x230.google.com with SMTP id b15-v6so8117525oib.10 for ; Tue, 04 Sep 2018 10:12:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:references:reply-to:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=ofBP/muADdXUoE8ml5v6sakAoUuMyKQk6tgL/m8sakA=; b=ik7i1EYtTEs8Y+OscivhSPxRcRW8D20h+1Dj355esVfp9+N8R26Rwo3j+Ci8p/eXfh cOKuUngP29PpvkG1zC5sPTMPNd4QWFEKO9PGDMD0q9W9K5J5kw19kVY+Fnj1wX8fRuK4 KuMzBbROoO9vfa/+5tSUiNbucFZc6ZF2GX7z3NkZ44HKcCkC5+uIER1vrz/1l5shwNJw Ib4LgvVubaDrDU5XkFvBbsIKlaIDpIfPRh/tVIzJn0Ne+f7NhvoKlaMejkK+iX7G0GgP Zba/7XuPcBcKaaUlUhfjIhbe+vP6eTcefa5OWdo84UuZjOXxR4zxCJ4PAeGnJvZyyETv VKhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:references:reply-to:date :in-reply-to:message-id:user-agent:mime-version :content-transfer-encoding; bh=ofBP/muADdXUoE8ml5v6sakAoUuMyKQk6tgL/m8sakA=; b=jSPhfePK2KTdPJtrGtnSg5nMlmRUrAh8O4L20TOxofyYpHlwzXOexVSs3jf986zL/j OIiSgbUhiciBfk1GkNykEQX19AUlLMXiJIWlCvPHwH0bZhNEPjYLeYOC7vA2t1UBNc1e zgObtVLA3SWNK6B5v4lX2s5RRWnV+kb5HsKQbaOEPG9ScpLXcQt9SItsEMOl7+rBb8yS ookWlYqB4SmUCxFsqQVPhtpgPuTrDY8SlAQiny99UOQubdgOWVMbdSQKTBSCZaLpGn/V dxEM1bRNL2LoJ+etsjIVPzYYPUKkg3K091tGcMLqtmSwmyhZSK2JB0f43xod3K/rzkJB R3PA== X-Gm-Message-State: APzg51Akt2PWBlRdXiExeEPZncnta9sCPHgJtIqgm4DwwFj9WB2vhYvF Y49+sep6WePv6yQo/vn73zxi0ST/ X-Google-Smtp-Source: ANB0VdaZHwE03Ee1Bc2EvA3E0kMshLvTTjsLSNscW2ZyhByCgTyZYw1GM4jNWM0uuWwl1yUbk7+Yhw== X-Received: by 2002:aca:5ad5:: with SMTP id o204-v6mr26896572oib.26.1536081120229; Tue, 04 Sep 2018 10:12:00 -0700 (PDT) Original-Received: from floss ([2602:306:3707:da30:6d72:aa17:36e1:6f0b]) by smtp.gmail.com with ESMTPSA id t141-v6sm40324278oif.18.2018.09.04.10.11.59 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 04 Sep 2018 10:11:59 -0700 (PDT) In-Reply-To: <874lf5ft4f.fsf@mat.ucm.es> (Uwe Brauer's message of "Tue, 04 Sep 2018 12:34:56 +0200") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4003:c06::230 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:229249 Archived-At: Uwe Brauer writes: >My problem is, if I am in a subdirectory of my mercurial (or git) >repository and run add-change-log-entry, does not open the ChangeLog >file in the =C2=ABroot=C2=BB directory but tries to open the none existing >ChangeLog file in the current subdirectory, which I don't want. > >Any ideas how to deal with this situation? > > >I tried to set=20 > >,---- >[+] >| change-log-directory-files is a variable defined in =E2=80=98add-log.el= =E2=80=99. >| Its value is (".bzr" ".git" "../.hg" ".hg" ".svn") >| Original value was=20 >| (".bzr" ".git" ".hg" ".svn") >`---- > >Did not help. Is this feature not implemented? By this I mean: suppose >in a directory under VC, there is only one ChangeLog file in the root >directory, then if I call add-change-log-entry there is no way to tell >emacs that he only looks for that file? A simple proposal: Have `add-change-log-entry' walk up the tree, starting from the current dir= ectory, and use the first ChangeLog file found. Most of the time, it'll be= in the root of the version-controlled tree, but for projects (like Emacs) = that have separate ChangeLogs in some subdirectories, the proper ChangeLog = would still be found. When a project wants to start using a ChangeLog in a subdirectory, someone = just needs to manually initialize the ChangeLog there (creating it as an em= pty file would be enough), and afterwards `add-change-log-entry' will do th= e right thing. Thoughts? Best regards, -Karl