From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#33870: 27.0.50; xref-goto-xref not configurable Date: Thu, 27 Dec 2018 18:08:15 +0000 Message-ID: <878t0ahmgg.fsf@gmail.com> References: <87a7ktqqx7.fsf@mail.linkov.net> <9215183d-0a44-88b5-5b3c-d0da31f749ad@yandex.ru> <87imzfkhb4.fsf@mail.linkov.net> <87imzfhm04.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1545934027 2986 195.159.176.226 (27 Dec 2018 18:07:07 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 27 Dec 2018 18:07:07 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 33870@debbugs.gnu.org, Juri Linkov To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Dec 27 19:07:03 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gca3i-0000gJ-Ik for geb-bug-gnu-emacs@m.gmane.org; Thu, 27 Dec 2018 19:07:02 +0100 Original-Received: from localhost ([127.0.0.1]:54599 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gca5p-0005a6-G7 for geb-bug-gnu-emacs@m.gmane.org; Thu, 27 Dec 2018 13:09:13 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:40294) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gca5j-0005Zk-Cm for bug-gnu-emacs@gnu.org; Thu, 27 Dec 2018 13:09:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gca5g-0008HB-59 for bug-gnu-emacs@gnu.org; Thu, 27 Dec 2018 13:09:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41270) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gca5f-0008Gd-TW for bug-gnu-emacs@gnu.org; Thu, 27 Dec 2018 13:09:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gca5e-0007BV-Au for bug-gnu-emacs@gnu.org; Thu, 27 Dec 2018 13:09:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Dec 2018 18:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33870 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 33870-submit@debbugs.gnu.org id=B33870.154593410627573 (code B ref 33870); Thu, 27 Dec 2018 18:09:02 +0000 Original-Received: (at 33870) by debbugs.gnu.org; 27 Dec 2018 18:08:26 +0000 Original-Received: from localhost ([127.0.0.1]:39528 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gca53-0007Af-R7 for submit@debbugs.gnu.org; Thu, 27 Dec 2018 13:08:26 -0500 Original-Received: from mail-wr1-f53.google.com ([209.85.221.53]:34446) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gca51-0007AR-Pl for 33870@debbugs.gnu.org; Thu, 27 Dec 2018 13:08:24 -0500 Original-Received: by mail-wr1-f53.google.com with SMTP id j2so19040473wrw.1 for <33870@debbugs.gnu.org>; Thu, 27 Dec 2018 10:08:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-transfer-encoding; bh=fZozBkXAR6hYr99yBKrBc3cD3Zl36qnv+d2+AoTp+fc=; b=IhKXYr6tcQUFZr93PS8CH4SztrieHmdaoZtWPgntyjYD/CgPKtY6oeRRvMsiZJvcEJ ydgM3Siv/ZBDJHW7X+atx+Pnr4x0AJQ8S+cNUzSDy3JV9wnN2iMWjHzTU6PJjXzUO6LE ohbCAhqshVVqPG1HPSBaGQJxDyhi2EvQW3wZp8T/icAEUNUlTC3G1d70aeK28aZ0Ggjs 7EZZmoVzYjIe90nU9t9C7MANAYgDJr05Oe8wm3Rk7BIh5ctX80MWwAt9/5xMh3p5WhpT bpLrqe4VODXMswMOL8GGo2NZLhTDvyonprGTbf1uhN5MwXwfdNaQWkdZncx6Gjry1kFO z4TQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:date:message-id:mime-version:content-transfer-encoding; bh=fZozBkXAR6hYr99yBKrBc3cD3Zl36qnv+d2+AoTp+fc=; b=erQC/UaZuA48vnZaoQA+9dDwO03buoUWhMROb4EMrJ1OV1/M3QBW2b1VDuxd2XII6O VLcNF3XkJ8MA1xyYflCVZAl+afNGDtHTwlITQ5ii8Ah7CfrC09HoRXLjJcQxHxkv1Tc0 z4VVLcQN447YT9ATSUADoxQnaej2E0COagYzkTtOpqJX6TldWU5nqh0jdisxW07fqgEn C9NZBuKXWoAOmDDT988WrxNtYaN3xhLq+AU4jpkJwbtDqFlfllgW1tPh52pdWzkWb1W7 +vvn1EV6mitjkxhGiiOZJBVlWRY6IYgC7/PJTjiGvzBdZfwsI44/UiMB1V8qDZN/7hXV FmIQ== X-Gm-Message-State: AJcUukfO7R33zNaatN71KFcnvANPSOj22nZ0dBk/F5KBDFnxhUZ7MGxy X0nbmMfhuFsdIx6u3EFcMUZYnk0W X-Google-Smtp-Source: ALg8bN62izQPYxIzrCxeGlin3XVj/oPxrbH1ZwgU9LFh2eZCfX83zT3BYiDo1EQB+pE9g2/dPh1uuA== X-Received: by 2002:adf:b102:: with SMTP id l2mr22126664wra.296.1545934097822; Thu, 27 Dec 2018 10:08:17 -0800 (PST) Original-Received: from lolita.yourcompany.com (188.139.62.94.rev.vodafone.pt. [94.62.139.188]) by smtp.gmail.com with ESMTPSA id h10sm25415718wmf.44.2018.12.27.10.08.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 27 Dec 2018 10:08:17 -0800 (PST) In-Reply-To: (Dmitry Gutov's message of "Thu, 27 Dec 2018 15:20:22 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:153923 Archived-At: Dmitry Gutov writes: > On 27.12.2018 2:05, Jo=C3=A3o T=C3=A1vora wrote: >> You can read up the whole bug here: >> >> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D28814 >> >> I quote from that thread: >> >> Here are two very simple Emacs -Q recipes that demonstrate [the bug] > > Does this work well for everybody? > > diff --git a/lisp/progmodes/xref.el b/lisp/progmodes/xref.el > index c71802c918..85d4325d9e 100644 > --- a/lisp/progmodes/xref.el > +++ b/lisp/progmodes/xref.el > @@ -494,7 +494,8 @@ xref--show-pos-in-buf > (or (and (window-live-p xref--original-window) > xref--original-window) > (selected-window)) > - (display-buffer buf action)) > + (pop-to-buffer buf action) > + (selected-window)) > (xref--goto-char pos) > (run-hooks 'xref-after-jump-hook) > (let ((buf (current-buffer))) It works for those two recipes, because `action' is passed directly to display-buffer. Don't know: * if it might be introducing a new untested corner case because of the "recording" of select-window inside. Perhaps this corner case is unwanted, but it might also be wanted (and we didn't know). * if it will bring Yuri what he wants. Doesn't seem like it will, since display buffer is given an explicit ACTION. Jo=C3=A3o