Re: master 7fd2ad7: Fix typo in add-hook doc string

Re: master 7fd2ad7: Fix typo in add-hook doc string

[Glenn Morris]

> branch: master
> commit 7fd2ad755e7fa599697648ac4c971e834de75bf3

>     Fix typo in add-hook doc string

> --- a/lisp/subr.el
> +++ b/lisp/subr.el
> @@ -1555,7 +1555,7 @@ FUNCTION is added at the end.
>  
>  The optional fourth argument, LOCAL, if non-nil, says to modify
>  the hook's buffer-local value rather than its global value.
> -This makes the hook buffer-local, and it makes t a member of the
> +This makes the hook buffer-local, and it makes it a member of the


That wasn't a typo. It refers to the symbol `t' (which is not quoted in
doc strings). If you read your revised version, and the next sentence,
you'll see it now doesn't make sense.

(Doc fixes should happen on the release branch, BTW.)

Re: [Emacs-diffs] master 7fd2ad7: Fix typo in add-hook doc string

[Stefan Monnier]

> -This makes the hook buffer-local, and it makes t a member of the
> +This makes the hook buffer-local, and it makes it a member of the

Actually, this was not a typo: it really makes the value `t` a member of
the buffer-local value.  But arguably this kind of internal info
doesn't belong in the docstring.


        Stefan

Re: master 7fd2ad7: Fix typo in add-hook doc string

[Aurélien Aptel]

Glenn Morris <rgm@gnu.org> writes:
> That wasn't a typo. It refers to the symbol `t' (which is not quoted in
> doc strings). If you read your revised version, and the next sentence,
> you'll see it now doesn't make sense.

Oops :( was a bit too quick

> (Doc fixes should happen on the release branch, BTW.)

ok

thanks, sorry for the disturbance I'll revert.

-- 
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
SUSE Linux GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)

Re: master 7fd2ad7: Fix typo in add-hook doc string

[Eli Zaretskii]

> From: Aurélien Aptel <aaptel@suse.com>
> Date: Thu, 07 Feb 2019 09:57:02 +0100
> 
> Oops :( was a bit too quick
> 
> > (Doc fixes should happen on the release branch, BTW.)
> 
> ok
> 
> thanks, sorry for the disturbance I'll revert.

No need to be sorry, anyone could make a good-faith mistake.

Thanks for paying attention to subtle issues in our documentation.