From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#34974: 27.0.50; Moving article error with duplicate suppression disabled Date: Sun, 24 Mar 2019 17:08:16 +0000 Message-ID: <878sx419q7.fsf@tcd.ie> References: <871s2wpedf.fsf@tcd.ie> <87ftrcmhxx.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="157404"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , 34974@debbugs.gnu.org To: Eric Abrahamsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Mar 24 18:19:38 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h86mV-000eq0-Gc for geb-bug-gnu-emacs@m.gmane.org; Sun, 24 Mar 2019 18:19:35 +0100 Original-Received: from localhost ([127.0.0.1]:58652 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h86mU-0000yL-AG for geb-bug-gnu-emacs@m.gmane.org; Sun, 24 Mar 2019 13:19:34 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:42843) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h86jc-0006zy-HY for bug-gnu-emacs@gnu.org; Sun, 24 Mar 2019 13:16:37 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h86cJ-00047i-GV for bug-gnu-emacs@gnu.org; Sun, 24 Mar 2019 13:09:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43444) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h86cJ-00047c-3N for bug-gnu-emacs@gnu.org; Sun, 24 Mar 2019 13:09:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h86cI-0004LD-07; Sun, 24 Mar 2019 13:09:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <871s2wpedf.fsf@tcd.ie> Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Sun, 24 Mar 2019 17:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34974 X-GNU-PR-Package: emacs,gnus X-GNU-PR-Keywords: patch Original-Received: via spool by 34974-submit@debbugs.gnu.org id=B34974.155344730816638 (code B ref 34974); Sun, 24 Mar 2019 17:09:01 +0000 Original-Received: (at 34974) by debbugs.gnu.org; 24 Mar 2019 17:08:28 +0000 Original-Received: from localhost ([127.0.0.1]:56988 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h86bj-0004KI-VP for submit@debbugs.gnu.org; Sun, 24 Mar 2019 13:08:28 -0400 Original-Received: from mail-ed1-f50.google.com ([209.85.208.50]:36801) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h86bg-0004Jz-Tg for 34974@debbugs.gnu.org; Sun, 24 Mar 2019 13:08:26 -0400 Original-Received: by mail-ed1-f50.google.com with SMTP id e4so5546954edi.3 for <34974@debbugs.gnu.org>; Sun, 24 Mar 2019 10:08:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:message-id:user-agent :mime-version; bh=LDHYcYSGhjct3NqdhgBVhNW8CvxrlX+Yckt9rbH3x9Q=; b=tSEhWSd0rkBzR7qWqMSYrnWJ1QbujRGv0NUZlnP/3tWt1WC9vQW7zXW6rvGncm+Isa Z5EIyhddS6pzQaDai+dDpXTo9IWn5O+H4ilyxQ11+hbS6UWa21h5REWj5GYofcrm8iOU XCLWLwR6CNWTPmoqmhyAN6toBE7Ls0pi1dJ4R/zE18X7u6fNNVx1j4SjzJAUvl3pehmk G0r0qTStIlqkH8O1LypVKk0sUi9bC3nLmKKqryPokfzIIbWFb9iPr4G2qDEfSNIS6g+2 CCEyvcup0gt0TzCBC6mVQQdG6+cYbM4+upvlbrGrL4QKwbJ+vLZbplg3l7iFq+qKU9Sy IulA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:message-id :user-agent:mime-version; bh=LDHYcYSGhjct3NqdhgBVhNW8CvxrlX+Yckt9rbH3x9Q=; b=otKSCy+LZ/0elKjA8dR8FkGMxlH7sXWj1Ps/5weA4hx0wElY/jOcsHrSdqeQKDlBPX AHwmLflbg/2pnF3JZPU4WLUEioa7t0aExQ4RrccINwUKeVcyNu3GqY/dGm43FCrlbiZN /iT4awdMdGEH8Mr5JkS5JrFFh/EWtlseU1FDK8o5Bb3up+qMYnEOL7IXozitWtgbhpku Oc9s1NpgvrrKH6t6z2gD+o8GgpjgSEqs0zzdW2ntCJdngOYL0JXYUx1Nwf2mjzkDox34 YR8dHvjXa5Dxbm3vvCjaYmnKKo+xHf0sAWw7LLHMTrHaxw40Ud77dY4udijey0muih6N wrJA== X-Gm-Message-State: APjAAAXOCyhuI1dnfxygHB9cvVUCBIyXUWC+0mtx9mgCSLPvTKNZNL79 KzAr41Rm+ohs0Rr9pP3ce5QH3A== X-Google-Smtp-Source: APXvYqyZ4QjxJCzVHrsLasBAZYCbk05ZpMwXY1Oyw6/rnklV8k5gF9imOwk3piQaCr5RnknBbewktw== X-Received: by 2002:a17:906:4bc3:: with SMTP id x3mr9534793ejv.150.1553447299180; Sun, 24 Mar 2019 10:08:19 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:f786:805d:f4ab:1006]) by smtp.gmail.com with ESMTPSA id c57sm4708332ede.28.2019.03.24.10.08.17 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Sun, 24 Mar 2019 10:08:18 -0700 (PDT) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:156709 Archived-At: Eric Abrahamsen writes: > "Basil L. Contovounesios" writes: > >> With gnus-suppress-duplicates left at its default value of nil, trying >> to move an article with 'B m ' gives me the following backtrace: >> >> Debugger entered--Lisp error: (wrong-type-argument hash-table-p nil) >> remhash("" nil) >> gnus-dup-unsuppress-article(1988) >> gnus-summary-move-article(nil) >> funcall-interactively(gnus-summary-move-article nil) >> call-interactively(gnus-summary-move-article nil nil) >> command-execute(gnus-summary-move-article) >> >> I'm no expert, and I haven't tried reproducing this with a minimal >> config, but I think gnus-summary-move-article should not call >> gnus-dup-unsuppress-article when gnus-suppress-duplicates is nil, right? >> >> This issue seems to have been uncovered by the switch to hash-tables in >> bug#33653. Previously, gnus-dup-unsuppress-article called unintern, >> which would not complain when its second argument gnus-dup-hashtb was >> nil, even though it probably should have. >> >> Patch to follow. > > It looks like the only other call to `gnus-dup-unsuppress-articles' is > wrapped in a check for `gnus-suppress-duplicates' -- I suppose it would > be enough just to wrap this one as well? That is what the proposed patch[1] does. Is it okay to push this to master? [1]: https://debbugs.gnu.org/34973#8 As I mention there, though, I'm not sure such a guard is sufficient in the case that gnus-suppress-duplicates is enabled at a later stage, but I will investigate and report this as a separate bug if needed. Thanks, -- Basil