From: Noam Postavsky <npostavs@gmail.com>
To: Dave Abrahams <dave@boostpro.com>
Cc: 34292@debbugs.gnu.org
Subject: bug#34292: 26.1; ido-everywhere interferes with find-file
Date: Wed, 03 Apr 2019 20:49:48 -0400 [thread overview]
Message-ID: <878swqfvbn.fsf@gmail.com> (raw)
In-Reply-To: <D4240D6A-2EF9-4D88-B7AC-3B7A97B167C6@boostpro.com> (Dave Abrahams's message of "Wed, 3 Apr 2019 16:37:21 -0700")
[-- Attachment #1: Type: text/plain, Size: 157 bytes --]
Dave Abrahams <dave@boostpro.com> writes:
> shouldn't starting ido-everywhere turn on ido-mode automatically, then?
Seems doable, does this work for you?
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: patch --]
[-- Type: text/x-diff, Size: 1199 bytes --]
From a21e8afe70b0f8fef692d235dc85995c01ca4e7a Mon Sep 17 00:00:00 2001
From: Noam Postavsky <npostavs@users.sourceforge.net>
Date: Wed, 3 Apr 2019 20:13:05 -0400
Subject: [PATCH] Let ido-everywhere turn on ido-mode (Bug#34292)
* lisp/ido.el (ido-everywhere): Turn on ido-mode, if it's not already
on. Otherwise, having ido-everywhere enabled messes all file and
buffer reading interactive commands.
---
lisp/ido.el | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/lisp/ido.el b/lisp/ido.el
index 0854014581..a89f7b0eaa 100644
--- a/lisp/ido.el
+++ b/lisp/ido.el
@@ -1586,8 +1586,10 @@ (define-minor-mode ido-everywhere
(remove-function read-file-name-function #'ido-read-file-name)
(remove-function read-buffer-function #'ido-read-buffer)
(when ido-everywhere
- (add-function :override read-file-name-function #'ido-read-file-name)
- (add-function :override read-buffer-function #'ido-read-buffer)))
+ (if (not ido-mode)
+ (ido-mode 'both)
+ (add-function :override read-file-name-function #'ido-read-file-name)
+ (add-function :override read-buffer-function #'ido-read-buffer))))
(defvar ido-minor-mode-map-entry nil)
--
2.11.0
[-- Attachment #3: Type: text/plain, Size: 192 bytes --]
(it seems to be working for me now, though I had a transient failure the
first time where it refused to open bar, even though ido seemed to be
functioning correctly. Maybe a caching thing?)
next prev parent reply other threads:[~2019-04-04 0:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-02 20:26 bug#34292: 26.1; ido-everywhere interferes with find-file Dave Abrahams
2019-04-01 23:37 ` Noam Postavsky
2019-04-02 23:58 ` Noam Postavsky
2019-04-03 0:01 ` Noam Postavsky
2019-04-03 23:37 ` Dave Abrahams
2019-04-04 0:49 ` Noam Postavsky [this message]
2020-08-19 10:49 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878swqfvbn.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=34292@debbugs.gnu.org \
--cc=dave@boostpro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.