From: Alex Gramiak <agrambot@gmail.com>
To: Alan Third <alan@idiocy.org>
Cc: emacs-devel@gnu.org
Subject: Re: Issue with ns_color_defined makeIndex argument
Date: Sat, 13 Apr 2019 10:16:59 -0600 [thread overview]
Message-ID: <878swdvq10.fsf@gmail.com> (raw)
In-Reply-To: <20190413100933.GA20582@breton.holly.idiocy.org> (Alan Third's message of "Sat, 13 Apr 2019 11:09:33 +0100")
Alan Third <alan@idiocy.org> writes:
> I’m not familiar with this area of the code, and a review hasn’t done
> anything to enlighten me. This code has been in since the NS port was
> merged, so there’s no explanatory reasoning in commit messages.
>
> If I’m reading the code right, when we lookup a colour in image.c, we
> store a 32bit integer representation of the colour in color_def.pixel,
> but when doing a lookup from xfaces.c, we store an index into a lookup
> table in color_def.pixel.
>
>> If so, does anyone have any ideas to rectify this besides adding an
>> extra argument that non-NS window systems just ignore? I'd rather avoid
>> doing that.
>
> I have no ideas, I’m afraid.
Alright, I just made a wrapper procedure to accommodate NS instead.
Thanks for looking at this.
prev parent reply other threads:[~2019-04-13 16:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-11 16:05 Issue with ns_color_defined makeIndex argument Alex
2019-04-13 10:09 ` Alan Third
2019-04-13 16:16 ` Alex Gramiak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878swdvq10.fsf@gmail.com \
--to=agrambot@gmail.com \
--cc=alan@idiocy.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.