Re: Add support for base64url variant

[pierre.techoueyres@free.fr (Pierre Téchoueyres)]

Had you have a chance to look at my patches ?
Should/Could I do something ?

pierre.techoueyres@free.fr (Pierre Téchoueyres) writes:

> Eli Zaretskii <eliz@gnu.org> writes:
>
>>> From: pierre.techoueyres@free.fr (Pierre Téchoueyres)
>>> Cc: emacs-devel@gnu.org
>>> Date: Thu, 23 May 2019 21:37:01 +0200
>>> 
>>> > I'd suggest to call the new argument base64url or somesuch, since
>>> > this is trhe official name.
>>> >
>>> You mean in replacement of url_variant or b64_value_to_char ?
>>
>> The former.
>>
>>> How should I send new versions of the patch ? As a full patch in
>>> attachment like previously ?
>>
>> Yes.  And please include the log messages (in the ChangeLog style).
>>
>>
> You'll find two patches attached.
> First one contains requested changes and, hoppefully, a valid Changelog
>
>
>
> The second patch contains an reworked version wich instead of adding
> many parameters to base64-encode-region (resp. base64-encode-string)
> function create the base64url-encode-region
> (resp. base64url-encode-string) function. Documentation and tests are
> also updated consequently.
>
>
>
> Tell me what you thing is the way to go.