From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alex Branham Newsgroups: gmane.emacs.bugs Subject: bug#36157: 27.0.50; ediff-files does not work after lexical-binding was enabled for ediff Date: Mon, 10 Jun 2019 08:41:50 -0500 Message-ID: <878su9tv4x.fsf@gmail.com> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="174038"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: mu4e 1.2.0; emacs 27.0.50 Cc: 36157@debbugs.gnu.org To: Kaushal Modi Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jun 10 15:43:45 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1haKaN-000j7h-DP for geb-bug-gnu-emacs@m.gmane.org; Mon, 10 Jun 2019 15:43:43 +0200 Original-Received: from localhost ([::1]:46626 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1haKaM-0003kY-DU for geb-bug-gnu-emacs@m.gmane.org; Mon, 10 Jun 2019 09:43:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49154) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1haKZq-0003jk-Bz for bug-gnu-emacs@gnu.org; Mon, 10 Jun 2019 09:43:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1haKZk-0004pL-Sx for bug-gnu-emacs@gnu.org; Mon, 10 Jun 2019 09:43:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42629) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1haKZh-0004o9-P1 for bug-gnu-emacs@gnu.org; Mon, 10 Jun 2019 09:43:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1haKZh-0002MD-Kl for bug-gnu-emacs@gnu.org; Mon, 10 Jun 2019 09:43:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alex Branham Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 10 Jun 2019 13:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36157 X-GNU-PR-Package: emacs Original-Received: via spool by 36157-submit@debbugs.gnu.org id=B36157.15601741228996 (code B ref 36157); Mon, 10 Jun 2019 13:43:01 +0000 Original-Received: (at 36157) by debbugs.gnu.org; 10 Jun 2019 13:42:02 +0000 Original-Received: from localhost ([127.0.0.1]:56173 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1haKYk-0002L1-A5 for submit@debbugs.gnu.org; Mon, 10 Jun 2019 09:42:02 -0400 Original-Received: from mail-ot1-f42.google.com ([209.85.210.42]:33668) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1haKYi-0002KY-Ax for 36157@debbugs.gnu.org; Mon, 10 Jun 2019 09:42:00 -0400 Original-Received: by mail-ot1-f42.google.com with SMTP id p4so5098867oti.0 for <36157@debbugs.gnu.org>; Mon, 10 Jun 2019 06:42:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=Z/GqGbAObdR18Sa1MbAKt4cNkjtKGWYtbkDdVncuLDY=; b=l98X5GMd59ppik0m3e5e7pzEDLdyoSUvXRoO8pdhcZwAxnSeKd+d0afhY62JDb5fIf hT31Bg3hg9gTlf2OjNwfcNRtA1H8Hh9cXxlYsUJDLNKomtd63Lo8mC40EIkl7NYHYmg/ fQm2e5McNQMswR0iHJID/kqy+OLc8DPiHZJm8UccqZHMFJ6zdhDm2YhAN2J0Znsj3E49 1qSnRLHnrGmYv5qGrx/KbBQVZvE8cryMZFZLmPI+SQPgnB2UMJKMwlbNG+f+H7mD6t33 a7GT+mUdqVe/Jlmg5Ltx68YP7Wv3ww8MmZ8MyOgs2aN/jgbWqSjXiP2LH6BF0hV4Y4hZ aNnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=Z/GqGbAObdR18Sa1MbAKt4cNkjtKGWYtbkDdVncuLDY=; b=jXAICGYixMC3Tg/J+TClavziFiLXdVtz2FymsNPhlQIrUag5xWI2ii+0qV1gKww81W oXySN2WYICi/WrBbbcidiTzsFbOAs6NRv9oPK+PuoMa7Zo1UAWxXfKWBaH1KbzjCLDyE CnGtkLJf2oNuAAYBigpSSxfcA3IhcyKhjVdYq5thJxJfSE67DP0zlNbojYH7lrM3vwus qHyREHIgAkBT4qDnJNwa13ZhuWYRjOWbIzUW7vkpnx9SxDIyjpVtqoxk5gF+T4jJsXsH L2bCr75yF5BaaAVqUeXocAWE1mh3W9J/5R7RL7gpj3oOOiCsromrpCy7GKKlrA6Aa5pT zu8w== X-Gm-Message-State: APjAAAXcXxsxOmqDB/TkzZzAF5GruLVPvU7VGoJ0Kk4X69m+vxkmEDjK cVq6KQ4IUJPYFNImsZFWs6cNmzGE X-Google-Smtp-Source: APXvYqxiBH60OXBBJKuzbAUeDEdlKtYhryrjlujyPcuCVqHpksAJoPqjg57eh8Lw+O86Pd1398RZfg== X-Received: by 2002:a9d:6443:: with SMTP id m3mr8857186otl.207.1560174114022; Mon, 10 Jun 2019 06:41:54 -0700 (PDT) Original-Received: from mars (c-75-66-168-160.hsd1.tn.comcast.net. [75.66.168.160]) by smtp.gmail.com with ESMTPSA id p131sm2705284oig.31.2019.06.10.06.41.52 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 10 Jun 2019 06:41:52 -0700 (PDT) In-reply-to: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:160326 Archived-At: On Sun 09 Jun 2019 at 22:21, Kaushal Modi wrote: > It seems like properly enabling lexical binding in ediff will be a bit > tricky. > > If you look at the code of ediff-find-file, you will see the use of > `symbol-value' everywhere. Indeed, it looks like portions of ediff expect symbols like file-A and file-B to be dynamically bound, but also passes them through as arguments to functions. I'm not sure what the best way to deal with this is, since if we just mark them as special the lexical binding will shadow the global binding anyway. In the meantime, feel free to revert that patch if its causing issues. Alex