From: Alex Branham <alex.branham@gmail.com>
To: Kaushal Modi <kaushal.modi@gmail.com>
Cc: 36157@debbugs.gnu.org
Subject: bug#36157: 27.0.50; ediff-files does not work after lexical-binding was enabled for ediff
Date: Mon, 10 Jun 2019 08:41:50 -0500 [thread overview]
Message-ID: <878su9tv4x.fsf@gmail.com> (raw)
In-Reply-To: <CAFyQvY3O=ThRqUSsF+wCgF7Y4AuV_VU2b4T99Rr8UArvCDMBrw@mail.gmail.com>
On Sun 09 Jun 2019 at 22:21, Kaushal Modi <kaushal.modi@gmail.com> wrote:
> It seems like properly enabling lexical binding in ediff will be a bit
> tricky.
>
> If you look at the code of ediff-find-file, you will see the use of
> `symbol-value' everywhere.
Indeed, it looks like portions of ediff expect symbols like file-A and
file-B to be dynamically bound, but also passes them through as
arguments to functions. I'm not sure what the best way to deal with this
is, since if we just mark them as special the lexical binding will
shadow the global binding anyway.
In the meantime, feel free to revert that patch if its causing issues.
Alex
next prev parent reply other threads:[~2019-06-10 13:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-10 3:11 bug#36157: 27.0.50; ediff-files does not work after lexical-binding was enabled for ediff Kaushal Modi
2019-06-10 3:21 ` Kaushal Modi
2019-06-10 13:41 ` Alex Branham [this message]
2019-06-10 13:45 ` Kaushal Modi
2019-06-10 15:37 ` Eli Zaretskii
2019-06-18 23:05 ` Glenn Morris
2019-06-11 2:26 ` Richard Stallman
2019-06-14 18:36 ` Alex Branham
2019-06-16 2:35 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878su9tv4x.fsf@gmail.com \
--to=alex.branham@gmail.com \
--cc=36157@debbugs.gnu.org \
--cc=kaushal.modi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.