From: Juri Linkov <juri@linkov.net>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: Andreas Schwab <schwab@suse.de>, 12492@debbugs.gnu.org
Subject: bug#12492: Acknowledgement (24.2.50; Open vc-dir buffer easier and faster)
Date: Fri, 05 Jul 2019 01:05:20 +0300 [thread overview]
Message-ID: <878stdv4kf.fsf@mail.linkov.net> (raw)
In-Reply-To: <87h881y2bs.fsf@mail.linkov.net> (Juri Linkov's message of "Thu, 04 Jul 2019 23:25:27 +0300")
>>>> +(defun vc-root-dir ()
>>>
>>> This is already defined in vc.el.
>>
>> True. The patch predated the introduction of that function.
>
> Maybe better to add interactivity to the existing function
> `vc-root-dir', i.e. to add a new arg `(&optional interactive)'
> and add `(interactive "p")'.
BTW, why vc-git-log-incoming and vc-git-log-outgoing are interactive?
It seems these functions are not intended to be used as commands:
diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el
index f62e108322..6a6036cf8a 100644
--- a/lisp/vc/vc-git.el
+++ b/lisp/vc/vc-git.el
@@ -1048,7 +1050,6 @@ vc-git-print-log
'("--")))))))
(defun vc-git-log-outgoing (buffer remote-location)
- (interactive)
(vc-setup-buffer buffer)
(vc-git-command
buffer 'async nil
@@ -1062,7 +1063,6 @@ vc-git-log-outgoing
"..HEAD")))
(defun vc-git-log-incoming (buffer remote-location)
- (interactive)
(vc-setup-buffer buffer)
(vc-git-command nil 0 nil "fetch")
(vc-git-command
next prev parent reply other threads:[~2019-07-04 22:05 UTC|newest]
Thread overview: 104+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-22 23:04 bug#12492: 24.2.50; Open vc-dir buffer easier and faster Dmitry Gutov
[not found] ` <handler.12492.B.13483551567692.ack@debbugs.gnu.org>
2012-09-22 23:31 ` bug#12492: Acknowledgement (24.2.50; Open vc-dir buffer easier and faster) Dmitry Gutov
2016-02-24 6:07 ` Lars Ingebrigtsen
2016-02-24 14:59 ` Dmitry Gutov
2016-02-24 23:46 ` Lars Ingebrigtsen
2019-06-27 14:49 ` Lars Ingebrigtsen
2019-06-27 21:16 ` Juri Linkov
2019-06-27 22:14 ` Lars Ingebrigtsen
2019-06-28 19:16 ` Juri Linkov
2019-06-28 19:30 ` Dmitry Gutov
2019-06-28 13:21 ` Dmitry Gutov
2019-06-28 19:17 ` Juri Linkov
2019-06-28 19:29 ` Dmitry Gutov
2019-06-29 10:19 ` Lars Ingebrigtsen
2019-06-30 20:53 ` Juri Linkov
2019-07-02 12:39 ` Lars Ingebrigtsen
2019-07-04 20:17 ` Juri Linkov
2019-07-05 13:09 ` Lars Ingebrigtsen
2019-07-05 13:41 ` Dmitry Gutov
2019-07-05 18:53 ` Juri Linkov
2019-07-06 11:59 ` Lars Ingebrigtsen
2019-07-07 22:56 ` Juri Linkov
2019-07-07 23:09 ` Dmitry Gutov
2020-06-09 23:35 ` bug#41779: Fall back between vc-diff and diff-backup Juri Linkov
2020-06-10 19:05 ` Dmitry Gutov
2020-06-10 21:53 ` Juri Linkov
2020-06-10 22:18 ` Dmitry Gutov
2020-06-10 23:17 ` Juri Linkov
2020-06-10 23:26 ` Dmitry Gutov
2020-06-24 23:32 ` Juri Linkov
2019-07-07 23:11 ` bug#12492: Acknowledgement (24.2.50; Open vc-dir buffer easier and faster) Dmitry Gutov
2020-02-25 0:10 ` Juri Linkov
2020-02-25 10:35 ` Dmitry Gutov
2020-02-25 21:27 ` Juri Linkov
2020-02-26 22:51 ` Dmitry Gutov
2020-02-26 23:41 ` Juri Linkov
2020-02-27 7:27 ` Dmitry Gutov
2020-02-29 21:16 ` Juri Linkov
2020-03-02 22:11 ` Dmitry Gutov
2020-03-02 23:05 ` Juri Linkov
2020-03-03 11:33 ` Dmitry Gutov
2020-03-03 13:31 ` Dmitry Gutov
2020-03-03 23:19 ` Juri Linkov
2020-03-04 12:05 ` Dmitry Gutov
2020-03-05 0:04 ` Juri Linkov
2020-03-05 23:15 ` Dmitry Gutov
2020-03-05 23:59 ` Juri Linkov
2020-03-06 15:24 ` "Non-standard UI", was: " Dmitry Gutov
2020-03-08 0:53 ` "Non-standard UI", Juri Linkov
2020-03-08 10:38 ` "Non-standard UI" Dmitry Gutov
2020-03-06 15:33 ` bug#12492: Acknowledgement (24.2.50; Open vc-dir buffer easier and faster) Dmitry Gutov
2020-03-08 0:47 ` Juri Linkov
2020-03-08 9:57 ` Dmitry Gutov
2020-03-29 0:08 ` Juri Linkov
2020-03-29 11:09 ` Dmitry Gutov
2020-03-06 9:40 ` Eli Zaretskii
2020-03-06 16:01 ` Dmitry Gutov
2020-03-06 16:14 ` Eli Zaretskii
2020-03-06 16:53 ` Dmitry Gutov
2020-03-06 17:12 ` Eli Zaretskii
2020-03-06 22:34 ` Dmitry Gutov
2020-03-07 7:37 ` Eli Zaretskii
2020-03-08 0:49 ` Dmitry Gutov
2020-03-09 17:24 ` Eli Zaretskii
2020-03-09 22:47 ` Dmitry Gutov
2020-03-10 18:18 ` Eli Zaretskii
2020-03-11 13:35 ` Dmitry Gutov
2020-03-11 16:14 ` Eli Zaretskii
2020-03-11 23:54 ` Dmitry Gutov
2020-03-12 14:57 ` Eli Zaretskii
2020-03-13 12:23 ` Dmitry Gutov
2020-03-13 14:30 ` Eli Zaretskii
2020-03-15 21:57 ` Dmitry Gutov
2020-03-16 3:25 ` Eli Zaretskii
2020-03-16 8:02 ` Dmitry Gutov
2020-03-21 11:28 ` Eli Zaretskii
2019-07-01 13:01 ` Dmitry Gutov
2020-02-27 22:50 ` Juri Linkov
2020-03-02 22:17 ` Dmitry Gutov
2020-03-02 22:57 ` Juri Linkov
2020-03-03 11:27 ` Dmitry Gutov
2020-03-03 23:27 ` Juri Linkov
2020-03-04 11:51 ` Dmitry Gutov
2020-03-05 0:06 ` Juri Linkov
2019-07-01 8:02 ` Andreas Schwab
2019-07-01 12:56 ` Dmitry Gutov
2019-07-04 20:25 ` Juri Linkov
2019-07-04 22:05 ` Juri Linkov [this message]
2019-07-05 13:44 ` Dmitry Gutov
2019-07-05 13:43 ` Dmitry Gutov
2019-07-05 18:56 ` Juri Linkov
2019-07-06 8:37 ` Dmitry Gutov
2012-09-23 7:01 ` bug#12492: 24.2.50; Open vc-dir buffer easier and faster Andreas Schwab
2012-09-23 8:38 ` Dmitry Gutov
2012-09-23 8:46 ` Andreas Schwab
2012-09-23 11:46 ` Dmitry Gutov
2012-09-23 11:54 ` Andreas Schwab
2012-09-23 12:26 ` Dmitry Gutov
2015-01-21 20:55 ` bug#12492: vc-dir vs. vc-root-dir Ivan Shmakov
2015-01-21 20:55 ` Ivan Shmakov
2015-01-21 21:55 ` Stefan Monnier
2015-01-22 5:40 ` Ivan Shmakov
2015-01-22 17:04 ` Stefan Monnier
2015-01-23 12:12 ` Ivan Shmakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878stdv4kf.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=12492@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.