From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#17871: 24.4.50; (elisp) `Core Advising Primitives': interactive spec as function? Date: Sun, 04 Aug 2019 14:56:57 +0200 Message-ID: <878ss99jhi.fsf@mouse.gnus.org> References: <400906ac-35f1-48e4-8df9-8e65b340209b@default> <87vbrjdajs.fsf@web.de> <82178260-247b-4653-85db-d6586480419e@default> <87d2dqdsyj.fsf@web.de> <8736ihb0ds.fsf@mouse.gnus.org> <87d0hl3xqx.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="195005"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Stefan Monnier , 17871@debbugs.gnu.org To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 04 15:15:44 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1huGMQ-000oan-0Z for geb-bug-gnu-emacs@m.gmane.org; Sun, 04 Aug 2019 15:15:42 +0200 Original-Received: from localhost ([::1]:44476 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1huGMO-0003xR-W5 for geb-bug-gnu-emacs@m.gmane.org; Sun, 04 Aug 2019 09:15:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47965) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1huGLp-00033o-G4 for bug-gnu-emacs@gnu.org; Sun, 04 Aug 2019 09:15:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1huGLo-00076n-92 for bug-gnu-emacs@gnu.org; Sun, 04 Aug 2019 09:15:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51987) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1huGLo-00076g-62 for bug-gnu-emacs@gnu.org; Sun, 04 Aug 2019 09:15:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1huGLn-0000LT-Vf for bug-gnu-emacs@gnu.org; Sun, 04 Aug 2019 09:15:04 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Aug 2019 13:15:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17871 X-GNU-PR-Package: emacs Original-Received: via spool by 17871-submit@debbugs.gnu.org id=B17871.15649244731185 (code B ref 17871); Sun, 04 Aug 2019 13:15:03 +0000 Original-Received: (at 17871) by debbugs.gnu.org; 4 Aug 2019 13:14:33 +0000 Original-Received: from localhost ([127.0.0.1]:60788 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1huGLI-0000Ix-Ta for submit@debbugs.gnu.org; Sun, 04 Aug 2019 09:14:33 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:37358) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1huGLD-0000Hz-UT for 17871@debbugs.gnu.org; Sun, 04 Aug 2019 09:14:28 -0400 Original-Received: from 77.18.62.220.tmi.telenormobil.no ([77.18.62.220] helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1huG4I-0007VN-Fu; Sun, 04 Aug 2019 14:57:00 +0200 In-Reply-To: <87d0hl3xqx.fsf@web.de> (Michael Heerdegen's message of "Sun, 04 Aug 2019 14:45:26 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:164569 Archived-At: Michael Heerdegen writes: > I guess SPEC is never functionp, at least after that change. By > skimming over the code, the > > (interactive (lambda (old-interactive-form) ...)) > > case is transformed by `advice--make-interactive-form' to something else > that is not a function, and apart from this, interactive specs are never > functionp. Ah, right. But since `advice--make-interactive-form' does the transform, then I guess functionp interactive specs in advice is still allowed? And then we should add an example in the manual, I think. Anybody got one? :-) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no