From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alex Branham Newsgroups: gmane.emacs.bugs Subject: bug#22700: 25.0.91; `erc-echo-timestamps' no longer echoes timestamp for each line Date: Thu, 15 Aug 2019 09:27:02 -0500 Message-ID: <878sruy05l.fsf@gmail.com> References: <87r3gcmyfc.fsf@riseup.net> <871sfh4o92.fsf@mouse.gnus.org> <87h8ocei9c.fsf@mouse.gnus.org> <87imr0u7dc.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="67289"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , 22700@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Aug 15 16:28:22 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hyGjh-000HGF-KW for geb-bug-gnu-emacs@m.gmane.org; Thu, 15 Aug 2019 16:28:17 +0200 Original-Received: from localhost ([::1]:42476 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hyGjg-0008Qa-Ee for geb-bug-gnu-emacs@m.gmane.org; Thu, 15 Aug 2019 10:28:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55116) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hyGjW-0008LN-P6 for bug-gnu-emacs@gnu.org; Thu, 15 Aug 2019 10:28:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hyGjS-0005Kz-5z for bug-gnu-emacs@gnu.org; Thu, 15 Aug 2019 10:28:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43285) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hyGjS-0005Ko-2N for bug-gnu-emacs@gnu.org; Thu, 15 Aug 2019 10:28:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hyGjR-0001fN-R5 for bug-gnu-emacs@gnu.org; Thu, 15 Aug 2019 10:28:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alex Branham Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Aug 2019 14:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22700 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed patch Original-Received: via spool by 22700-submit@debbugs.gnu.org id=B22700.15658792316241 (code B ref 22700); Thu, 15 Aug 2019 14:28:01 +0000 Original-Received: (at 22700) by debbugs.gnu.org; 15 Aug 2019 14:27:11 +0000 Original-Received: from localhost ([127.0.0.1]:52105 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hyGid-0001ca-7Z for submit@debbugs.gnu.org; Thu, 15 Aug 2019 10:27:11 -0400 Original-Received: from mail-ot1-f49.google.com ([209.85.210.49]:35074) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hyGib-0001cA-Np for 22700@debbugs.gnu.org; Thu, 15 Aug 2019 10:27:10 -0400 Original-Received: by mail-ot1-f49.google.com with SMTP id g17so5444808otl.2 for <22700@debbugs.gnu.org>; Thu, 15 Aug 2019 07:27:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=5OND/cNpHvz7WQPMIi4wxt5R+t2uMN4pJesYCmlZJuE=; b=YTBxBs957CyF8rFdvDxBHPKeJw1H+V9Rfcow5SKwcbtZ4UT6I/QYZWoxjlZx3jCilT 8VozZvZb/eDXwuItwKHwD3l6CXU5Yp0p9wUdcP0c7q//NRgLh5VD6PSw6DAan+6TOn0q sZ8lcJwxNj/FNxBAS3B+AmLIAUZzAeno2I/GoswPIusqa15/Rx8kh1ux24JKGY9wzMFE 5agK/0xskhjYSKBm9r15ba6tVZP0nt29KPq87W/Jpe6WG4O/kpE6GWvDicMcwn4KqAVU +UGwrsjmImVaviYYu/n7G2Wc12x63KI74Y6XHO9VqkHKsKMFBMYw0n69eE01baqYWU0d yCXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=5OND/cNpHvz7WQPMIi4wxt5R+t2uMN4pJesYCmlZJuE=; b=lmZsMQpsO0kDTcPV457lOyfaamGl820OBV7dRlmR2MECBiUc+rxqiZ9cU5kqoh/L0d g/MQpBXFjdXYeM392FXWzzL3TtDiU+hp6iWP0Zu3VRW1ueapG1dvcY9iMYU7SzznvtRG ya7k/BzyOkDHQ/TBIXsm1A+dFUWo5j2GMla4Pja5ZbeU/K48q0pVodJ/FoTVmFqZxty6 SrUFZBIwKhEI1yVjzQ+OeqlytRT4IVm6+Nk88JoW1xo/fbtXlwQGb3SgJeSXy7PW4DoH CEmdt9AhKJ8uFODU9zcXMdlnKsBb8gx/JOSXWQ3dQd8mJsOQ0Jx1xW8t5CI9nVAxbL6p hTXg== X-Gm-Message-State: APjAAAVVFsiOljO0JGKdFN6hZQo1L+18fFurQ6wlrpCbf6ACSZ/xFzAt CqOJDoZdNYn6/ZaLK57KjoEQsy+C X-Google-Smtp-Source: APXvYqx7ktfQiDgAy1KDDt7c2iL9FiXmIZia5a//1p1nTA2oqylZ2Vv4fuL+zU5XoozaKVWynUMvzA== X-Received: by 2002:a05:6830:458:: with SMTP id d24mr3479304otc.126.1565879223810; Thu, 15 Aug 2019 07:27:03 -0700 (PDT) Original-Received: from earth (cpe-70-114-192-208.austin.res.rr.com. [70.114.192.208]) by smtp.gmail.com with ESMTPSA id z26sm1223277ote.40.2019.08.15.07.27.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Aug 2019 07:27:03 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Wed, 14 Aug 2019 18:50:12 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:165093 Archived-At: On Wed 14 Aug 2019 at 18:50, Stefan Monnier wrote: >> This is because cursor-sensor--detect doesn't call >> cursor-sensor-functions if the text property hasn't changed[1]. Since ERC >> applies the property to _all_ of the message, the text property remains >> `eq' and so it doesn't get called when it should. > > How 'bout the patch below which makes the function different on > each message? Works well unless you C-n/p and point remains inside the same IRC message. Probably a happy medium between what I suggested and the problems Noam pointed out though. Should we go ahead and apply this to master? It's clearly an improvement over what's there now, which doesn't really work at all. Thanks, Alex