From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#37319: 26.3; shr: Why inhibiting cookies when fetching images? Date: Sat, 14 Sep 2019 15:57:05 +0200 Message-ID: <878sqr7zgu.fsf@gnus.org> References: <87blvxkhud.fsf@cassou.me> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="220896"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 37319@debbugs.gnu.org To: Damien Cassou Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Sep 14 15:58:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i98Z1-000vGl-6T for geb-bug-gnu-emacs@m.gmane.org; Sat, 14 Sep 2019 15:58:11 +0200 Original-Received: from localhost ([::1]:50078 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i98Yz-0002Fc-Qm for geb-bug-gnu-emacs@m.gmane.org; Sat, 14 Sep 2019 09:58:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40640) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i98Yt-0002FS-NA for bug-gnu-emacs@gnu.org; Sat, 14 Sep 2019 09:58:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i98Ys-00070S-Mm for bug-gnu-emacs@gnu.org; Sat, 14 Sep 2019 09:58:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38166) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i98Ys-00070E-Jk for bug-gnu-emacs@gnu.org; Sat, 14 Sep 2019 09:58:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i98Ys-0008BS-G5 for bug-gnu-emacs@gnu.org; Sat, 14 Sep 2019 09:58:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Sep 2019 13:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37319 X-GNU-PR-Package: emacs Original-Received: via spool by 37319-submit@debbugs.gnu.org id=B37319.156846943231389 (code B ref 37319); Sat, 14 Sep 2019 13:58:02 +0000 Original-Received: (at 37319) by debbugs.gnu.org; 14 Sep 2019 13:57:12 +0000 Original-Received: from localhost ([127.0.0.1]:46987 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i98Y3-0008AD-LR for submit@debbugs.gnu.org; Sat, 14 Sep 2019 09:57:11 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:35530) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i98Y1-0008A2-Oa for 37319@debbugs.gnu.org; Sat, 14 Sep 2019 09:57:10 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i98Xx-0000ZO-H6; Sat, 14 Sep 2019 15:57:07 +0200 In-Reply-To: <87blvxkhud.fsf@cassou.me> (Damien Cassou's message of "Fri, 06 Sep 2019 09:24:26 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:166450 Archived-At: Damien Cassou writes: > I would like to use shr to render an HTML document with images. These > images are only accessible when logged in, so I need cookies to be sent > by shr. Unfortunately, `shr-tag-img` explicitly pass t to > INHIBIT-COOKIES when calling `url-queue-retrieve`. Several calls to > `url-retrieve` in the same file also inhibit cookies. > > Why is that so? It's an artefact from when shr was used mainly for rendering Gnus articles, I think. > Can we make that configurable through, e.g., a new option > `shr-img-inhibit-cookies` or similar? Yes, I think that sounds fine. eww, for instance, should (by default) send cookies when retrieving images, for instance, but it needs to be tempered by allowing not sending cookies to third-party images and the like. The entire eww cookie/referer thing needs a makeover, but that's a different story. But, yes, adding a `shr-use-cookies' variable to be bound before calling `shr-insert-document' would be good. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no