all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Matthew Newton <matt@mnewton.com>
Cc: 30449@debbugs.gnu.org
Subject: bug#30449: imenu contains redundant '*Rescan*' item with auto refresh
Date: Fri, 20 Sep 2019 15:02:18 +0200	[thread overview]
Message-ID: <878sqjazol.fsf@gnus.org> (raw)
In-Reply-To: <33378FAE-C23F-4B17-A468-65406AF6D393@mnewton.com> (Matthew Newton's message of "Thu, 19 Sep 2019 14:36:47 -0700")

Matthew Newton <matt@mnewton.com> writes:

> I don’t know the codebase at all and I just spent a couple minutes looking at it. But shouldn’t imenu--make-index-alist always return a list? So the last lines would be:
>
> (if imenu-auto-rescan
>       imenu--index-alist
>     ;; Add a rescan option to the index.
>     (cons imenu--rescan-item imenu--index-alist))

Yes, that looks like the correct fix.  I've now applied it to the Emacs
trunk.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





      reply	other threads:[~2019-09-20 13:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-13 21:12 bug#30449: imenu contains redundant '*Rescan*' item with auto refresh Campbell Barton
2019-07-14 16:32 ` Lars Ingebrigtsen
2019-09-16 23:38   ` Lars Ingebrigtsen
2019-09-19 21:36 ` Matthew Newton
2019-09-20 13:02   ` Lars Ingebrigtsen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878sqjazol.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=30449@debbugs.gnu.org \
    --cc=matt@mnewton.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.