From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#20258: 24.5; format-time-string miscounting of multibyte characters Date: Mon, 30 Sep 2019 15:39:15 +0200 Message-ID: <878sq5ewe4.fsf@gnus.org> References: <87blv2a3aj.fsf@gnus.org> <83d0fie08y.fsf@gnu.org> <83k19qcfjc.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="188116"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 20258@debbugs.gnu.org, Andreas Schwab , stefan@marxist.se, gunnar.horrigmo@usit.uio.no To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Sep 30 15:40:26 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iEvub-000mmp-1x for geb-bug-gnu-emacs@m.gmane.org; Mon, 30 Sep 2019 15:40:25 +0200 Original-Received: from localhost ([::1]:52644 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iEvuZ-0001Ny-RW for geb-bug-gnu-emacs@m.gmane.org; Mon, 30 Sep 2019 09:40:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45985) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iEvuG-00010Z-1B for bug-gnu-emacs@gnu.org; Mon, 30 Sep 2019 09:40:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iEvuE-00066z-TF for bug-gnu-emacs@gnu.org; Mon, 30 Sep 2019 09:40:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48266) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iEvuE-00066t-QA for bug-gnu-emacs@gnu.org; Mon, 30 Sep 2019 09:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iEvuE-0007yJ-Jh for bug-gnu-emacs@gnu.org; Mon, 30 Sep 2019 09:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 Sep 2019 13:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20258 X-GNU-PR-Package: emacs Original-Received: via spool by 20258-submit@debbugs.gnu.org id=B20258.156985076430591 (code B ref 20258); Mon, 30 Sep 2019 13:40:02 +0000 Original-Received: (at 20258) by debbugs.gnu.org; 30 Sep 2019 13:39:24 +0000 Original-Received: from localhost ([127.0.0.1]:57087 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iEvtb-0007xL-RH for submit@debbugs.gnu.org; Mon, 30 Sep 2019 09:39:24 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:53236) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iEvtZ-0007xC-Gf for 20258@debbugs.gnu.org; Mon, 30 Sep 2019 09:39:21 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iEvtU-0001fF-2P; Mon, 30 Sep 2019 15:39:18 +0200 In-Reply-To: <83k19qcfjc.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 30 Sep 2019 12:13:59 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:167874 Archived-At: Eli Zaretskii writes: >> The POSIX descriptions says bytes. > > Right. So it might be a glibc documentation bug (or maybe the glibc > manual I have here is outdated). > > And there is the issue with non-glibc implementations. What about something appropriately vague like the following patch to draw attention to the issue: diff --git a/src/timefns.c b/src/timefns.c index 330d5623f0..20f7ccb7d7 100644 --- a/src/timefns.c +++ b/src/timefns.c @@ -1437,8 +1437,11 @@ DEFUN ("format-time-string", Fformat_time_string, Sformat_time_string, 1, 3, 0, `^' Use upper case characters if possible. `#' Use opposite case characters if possible. -A field width N is an unsigned decimal integer with a leading digit nonzero. -%NX is like %X, but takes up at least N positions. +A field width N is an unsigned decimal integer with a leading digit +nonzero. %NX is like %X, but takes up at least N positions. The +field width is (on most systems) in bytes, not characters, so it +depends on the locale what the width (in characters) %NX will end up +being. The modifiers are: -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no