From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#37515: 27.0.50; button.el doesn't support help-echo function Date: Tue, 01 Oct 2019 14:28:50 +0200 Message-ID: <878sq48xa5.fsf@gnus.org> References: <87zhirdv75.fsf@gnus.org> <87ftki1xby.fsf@gnus.jao.io> <87sgodftxd.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="42932"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Katsumi Yamaoka , "Jose A. Ortega Ruiz" , 37515@debbugs.gnu.org To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 01 14:29:56 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iFHHw-000B5D-0c for geb-bug-gnu-emacs@m.gmane.org; Tue, 01 Oct 2019 14:29:56 +0200 Original-Received: from localhost ([::1]:41374 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFHHu-0002Wk-Ev for geb-bug-gnu-emacs@m.gmane.org; Tue, 01 Oct 2019 08:29:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44026) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFHH5-0002ED-Px for bug-gnu-emacs@gnu.org; Tue, 01 Oct 2019 08:29:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iFHH4-0000qe-Nm for bug-gnu-emacs@gnu.org; Tue, 01 Oct 2019 08:29:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52182) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iFHH4-0000qS-Kp for bug-gnu-emacs@gnu.org; Tue, 01 Oct 2019 08:29:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iFHH4-0003v7-Fp for bug-gnu-emacs@gnu.org; Tue, 01 Oct 2019 08:29:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Oct 2019 12:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37515 X-GNU-PR-Package: emacs Original-Received: via spool by 37515-submit@debbugs.gnu.org id=B37515.156993293715051 (code B ref 37515); Tue, 01 Oct 2019 12:29:02 +0000 Original-Received: (at 37515) by debbugs.gnu.org; 1 Oct 2019 12:28:57 +0000 Original-Received: from localhost ([127.0.0.1]:32769 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFHGy-0003uh-LZ for submit@debbugs.gnu.org; Tue, 01 Oct 2019 08:28:56 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:49454) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFHGx-0003uY-FQ for 37515@debbugs.gnu.org; Tue, 01 Oct 2019 08:28:55 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iFHGs-0002Y1-Rs; Tue, 01 Oct 2019 14:28:53 +0200 In-Reply-To: <87sgodftxd.fsf@tcd.ie> (Basil L. Contovounesios's message of "Mon, 30 Sep 2019 20:47:10 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:167982 Archived-At: "Basil L. Contovounesios" writes: > Some further changes are needed to fully support the help-echo property. > Firstly, help-echo functions expect an overlay as their second argument > when the object that had the property is an overlay (button). Secondly, > help-echo values can be forms in addition to strings and functions. > Lastly, (info "(elisp) Button Properties") needs updating to reflect the > supported values of the help-echo button property. > > The following patch should do all this. I will push it in the next few > days if there are no objections. WDYT? Looks good to me. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no