From: "Michał Krzywkowski" <mkrzywkow@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 37892@debbugs.gnu.org, "Michał Krzywkowski" <mkrzywkow@gmail.com>
Subject: bug#37892: 27.0.50; Crash when signaling a thread
Date: Sun, 27 Oct 2019 11:16:03 +0100 [thread overview]
Message-ID: <878sp6wl24.fsf@gmail.com> (raw)
In-Reply-To: <8336ffvf1p.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1412 bytes --]
>>>>> "Eli" == Eli Zaretskii <eliz@gnu.org> writes:
Eli> Michał, can you tell why you needed to call thread-signal while the
Eli> thread was in sit-for?
>>
>> I wanted to signal some background thread which was doing some work and
>> then Emacs crashed, because it just so happened that it was in sit-for.
>> The thread function was doing _more_ than just sit-for.
>>
>> I actually don't care (and can't know) what another thread is doing, I
>> just want to send a signal to it.
Eli> But thread-signal is not for causing an error in a thread, it is for
Eli> unblocking a thread that waits on a mutex or a condvar. So why would
Eli> you use it when the thread is not blocked?
Then I think documentation for that function should be changed to
explicitly say that the signal will *only* be delivered if the target
thread is in a "blocked call to ‘mutex-lock’, ‘condition-wait’, or
‘thread-join’".
Currently, the docstring of thread-signal just says that the function
will interrupt threads which are blocked, but does not actually say that
the signal will be delivered only in those cases. In fact, it says that
it works like signal, so I don't think it's unreasonable to assume that
it will just interrupt a thread whatever it's doing.
--
Michał Krzywkowski
PGP: A5A7 06C4 28EF 8F64 2868 13A1 7BDE C129 F0B8 09A1
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2019-10-27 10:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 17:06 bug#37892: 27.0.50; Crash when signaling a thread Michał Krzywkowski
2019-10-25 8:44 ` Eli Zaretskii
2019-10-26 12:29 ` Michał Krzywkowski
2019-10-26 12:58 ` Eli Zaretskii
2019-10-27 10:16 ` Michał Krzywkowski [this message]
2019-10-27 13:25 ` Eli Zaretskii
2019-10-27 19:26 ` Michał Krzywkowski
2021-12-05 3:15 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878sp6wl24.fsf@gmail.com \
--to=mkrzywkow@gmail.com \
--cc=37892@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.