From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#17272: bug#19064: bug#17272: bug#19064: bug#17272: bug#19064: 25.0.50; `message' overwrites `y-or-n-p' prompt, so user misses it Date: Wed, 20 Nov 2019 23:44:28 +0000 Message-ID: <878soacdur.fsf@gmail.com> References: <8ea0a3fa-5169-4493-bd54-3ebe47836a35@default> <87sgmy3x22.fsf@gnus.org> <871rugbqmy.fsf@mail.linkov.net> <87d0dxyh7z.fsf@gnus.org> <53c55db5-d623-4946-af2e-d141e7bc7acd@default> <87sgmrpir5.fsf@web.de> <87mucya2a7.fsf@web.de> <87mucy4cb2.fsf@web.de> <621b98dc-0fe9-4eef-9e11-7580fb446e97@default> <87k1822ocn.fsf@web.de> <87lfsfmtk0.fsf@mail.linkov.net> <874kz3gibu.fsf@gnus.org> <87bltaw3xz.fsf@mail.linkov.net> <87r224x54p.fsf@mail.linkov.net> <87v9rgnv0o.fsf@gnus.org> <877e3vqx9r.fsf@mail.linkov.net> <87v9reqk6o.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="77269"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Michael Heerdegen , 17272@debbugs.gnu.org, Lars Ingebrigtsen , 19064@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Nov 21 00:45:18 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iXZev-000Jyq-MB for geb-bug-gnu-emacs@m.gmane.org; Thu, 21 Nov 2019 00:45:17 +0100 Original-Received: from localhost ([::1]:35094 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iXZet-00020q-Rs for geb-bug-gnu-emacs@m.gmane.org; Wed, 20 Nov 2019 18:45:15 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54316) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iXZek-00020a-IZ for bug-gnu-emacs@gnu.org; Wed, 20 Nov 2019 18:45:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iXZej-0004sI-Di for bug-gnu-emacs@gnu.org; Wed, 20 Nov 2019 18:45:06 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42276) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iXZej-0004sA-AR for bug-gnu-emacs@gnu.org; Wed, 20 Nov 2019 18:45:05 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iXZej-0007Vc-5D for bug-gnu-emacs@gnu.org; Wed, 20 Nov 2019 18:45:05 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 20 Nov 2019 23:45:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17272 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 17272-submit@debbugs.gnu.org id=B17272.157429349028828 (code B ref 17272); Wed, 20 Nov 2019 23:45:05 +0000 Original-Received: (at 17272) by debbugs.gnu.org; 20 Nov 2019 23:44:50 +0000 Original-Received: from localhost ([127.0.0.1]:51097 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXZeT-0007Up-VS for submit@debbugs.gnu.org; Wed, 20 Nov 2019 18:44:50 -0500 Original-Received: from mail-wr1-f41.google.com ([209.85.221.41]:43564) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXZeQ-0007UT-FH; Wed, 20 Nov 2019 18:44:47 -0500 Original-Received: by mail-wr1-f41.google.com with SMTP id n1so2040228wra.10; Wed, 20 Nov 2019 15:44:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=NPsW82qeYFeSxLioBzS262RGRo4BjSAfphApmKmAILI=; b=DeFzdaHlPm61AvVJEJaG0QeEffv+0t7ltCqzIfdcupROqyP4OOKawUA71AlRUeZMI2 dgUCmKG3QKwf5go7MZkQyUVFBnCXYnE1kgzDxUUg3YfkswO/TszJkXN26rn8uOgkOsUq A2ksCf3CqAwPVxEhgw4jHusMCRi/J+emFsdw/BcFuKsdcZEQNSctrbvpmIDkOKt144cL FDD2VJdO6j5DCuntKIFuzg5lA7a27n0zAZ7ZEBDOQ4zu6CvWmuYXT6KJpEW5ccXU7d7A c4e/l/Yxo09rB8/AmKxtg31Ls8cwcTpYVOiGXYQ8Zzc/mh07gy98ex4R/+DBXpdYmxVj ZoIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=NPsW82qeYFeSxLioBzS262RGRo4BjSAfphApmKmAILI=; b=FplTH9/WaMQNWQp6w5RMTLnhjCuw5PpFLXS6mZ0bDsoyLTxpYWH1jHXKM9okwOKk/t VjOSgchVPcGJRfUrSFUsUrieZvqNaT2QgAe8JQVbZCbCV1m4xjkAIKWAyVpjlXXGit7J 2yEGzNEwmOEZSLnzK/XDppBV+StEfKIDwlbI56jO5YBl1kd368COrSJdVXnvuzFeD/Kz dCexh77el2Dc818HYOkwfwMjBGERUkX5G0yOJGz9go1pcUYLSV2tNoebdyxwVfCxrniX euLI0MguuMzKIODopaKsi4N5a3WXwgbJuC2IET7eWI3+FHX5inv2HmEbBku14q13BUAY a/Rg== X-Gm-Message-State: APjAAAVmmuyFB05BUbdBZrt8LGPcJy2v4X8RqyhkavKWRo4oNJiOUQQ3 qszzM7N6oTFZWSXnf+s+S/g= X-Google-Smtp-Source: APXvYqzBi0qQkcoSubpgVXE8JhCWhLy9XMgDBBJq7znvQlf4YVhjw3LSosilq3jg3zb/Hi2BZkNnxg== X-Received: by 2002:a05:6000:1286:: with SMTP id f6mr3999279wrx.44.1574293480369; Wed, 20 Nov 2019 15:44:40 -0800 (PST) Original-Received: from lolita.yourcompany.com ([2001:818:d820:9500:1ebb:afd8:ab26:f0f6]) by smtp.gmail.com with ESMTPSA id j2sm1001328wrt.61.2019.11.20.15.44.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Nov 2019 15:44:38 -0800 (PST) In-Reply-To: <87v9reqk6o.fsf@mail.linkov.net> (Juri Linkov's message of "Thu, 21 Nov 2019 00:10:59 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172088 Archived-At: Juri Linkov writes: >> Emacs -Q >> M-x fido-mode >> (defalias 'yes-or-no-p 'y-or-n-p) ;; a common custmization >> C-x b >> C-k ;; to kill the Messages buffer >> >> Before your changes to `y-or-n-p` this worked well, afterwards >> I get the "Attempt to use minibuffer inside minibuffer" error. >> >> Bear in mind that fido-mode is very new. Also bear in mind >> that the problem is already present when yes-or-no-p is used. >> >> I think a good fix is for icomplete to do this (and for >> you to do nothing :-) ) > > It's tempting to do nothing :-), but since the problem is > already present with yes-or-no-p too, it should be fixed > because it's a general problem affecting other commands too. I tend to agree, but it's a longstanding thing in Emacs, so I would be very wary of touching it (at least until we get some more opinions). > > The nil value of enable-recursive-minibuffers by default was intended > to avoid confusion for beginners unadvisedly typing such sequences as > M-x M-x M-x M-x M-x ... to get out from which is not easy. That may be true, but are you sure there aren't other problems being avoided by it? Let me give you and example: in icomplete-mode, there is a post-command-hook that displays some overlays in the minibuffer. Now, if we take your patch, indeed icomplete-mode doesn't have to worry about enable-recursive-minibuffers in the example I gave you. This is good, no more error message. However, that also means that instead of an annoying error message, you get another confusing bug where the post-command-hook will prevail in the recursive minibuffer, which just doesn't make sense when answering just yes-or-no. In this particular case, I additionally protected the code against this, but what I'm saying is that other bugs may be uncovered by your patch that are today hidden behind the annoying-but-reasonable error message. Jo=C3=A3o