From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Deus Max Newsgroups: gmane.emacs.bugs Subject: bug#38918: 26.3; EBDB fails to edit (add) tags Date: Sat, 18 Jan 2020 18:20:48 +0200 Message-ID: <878sm468in.fsf@aia00054aia.gr> References: <87d0bzcnmm.fsf@disroot.org> <87zhf3m4pe.fsf@ericabrahamsen.net> <87blri6a9j.fsf@disroot.org> <87r20en36v.fsf@ericabrahamsen.net> <87v9pqgou0.fsf@disroot.org> <8736csz841.fsf@ericabrahamsen.net> <87d0bv1mmb.fsf@disroot.org> <87h817uq0x.fsf@ericabrahamsen.net> <87muas943w.fsf@disroot.org> <87r204pplx.fsf@ericabrahamsen.net> <87sgki2r5s.fsf@disroot.org> <87o8v5lkq0.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="37412"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: "Jorge P. de Morais Neto" , 38918@debbugs.gnu.org To: Eric Abrahamsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 18 17:22:37 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1isqrs-0009gr-Fb for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 18 Jan 2020 17:22:36 +0100 Original-Received: from localhost ([::1]:42370 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1isqrr-00049A-8h for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 18 Jan 2020 11:22:35 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34109) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1isqrL-00048C-Ff for bug-gnu-emacs@gnu.org; Sat, 18 Jan 2020 11:22:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1isqrK-0006Hl-4n for bug-gnu-emacs@gnu.org; Sat, 18 Jan 2020 11:22:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36103) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1isqrJ-0006Ha-Tw for bug-gnu-emacs@gnu.org; Sat, 18 Jan 2020 11:22:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1isqrJ-0007H7-Q7 for bug-gnu-emacs@gnu.org; Sat, 18 Jan 2020 11:22:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Deus Max Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 Jan 2020 16:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38918 X-GNU-PR-Package: emacs Original-Received: via spool by 38918-submit@debbugs.gnu.org id=B38918.157936447827907 (code B ref 38918); Sat, 18 Jan 2020 16:22:01 +0000 Original-Received: (at 38918) by debbugs.gnu.org; 18 Jan 2020 16:21:18 +0000 Original-Received: from localhost ([127.0.0.1]:42076 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1isqqb-0007G3-RO for submit@debbugs.gnu.org; Sat, 18 Jan 2020 11:21:18 -0500 Original-Received: from mout.gmx.net ([212.227.15.15]:52157) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1isqqW-0007Fk-Af for 38918@debbugs.gnu.org; Sat, 18 Jan 2020 11:21:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1579364455; bh=7UHoB3mTM97DwFet4QdImWZNrq1s1i6ttbEqMRDSlw8=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=JUlg9fGmzaTlDwINzYWwR292+TlJbH0W2uGWtgPfhcu/xAvr8vSLVR/S+yeNp8aKf ljANjRnRzlFiqLccyxynC2F4uyiSIjWTUqDR/iYgU1OlbtRBwxW1S+ODXef4gnJz/t KJ2fjftrflBHOlk8fU7gU9ozS+4co3a3VeJjfwUk= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from dellcorei5dias ([5.54.155.167]) by mail.gmx.com (mrgmx005 [212.227.17.184]) with ESMTPSA (Nemesis) id 1Mn2W5-1jJdT62Dxv-00k46M; Sat, 18 Jan 2020 17:20:55 +0100 In-Reply-To: <87o8v5lkq0.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Tue, 14 Jan 2020 14:46:47 -0800") X-Provags-ID: V03:K1:A0jNkHYDM5J04NIFi1MStjR1ZGEttE07kwXMFLgPlvjfqxPRb/C EjvGZoOYsdMYS7+r9Exrst9lP/hCYADzzU2p2Sjpy1sm/SYR9tV9YKtkD4Dc8CIS633bHay hkCthYy6iRoS4sielrj4X7ZtsM/9s/tp47ILZ2GUIBTOjN5B1lUFPVa1qlnW8tHv8EmYxfu +UIDgDyhJ3FgY2xjeeOyg== X-UI-Out-Filterresults: notjunk:1;V03:K0:4HmBpZgL30Y=:ybe/us51fc9WiIFEQvzdNc rsSo6Lrfga7FvrlG4dsmBECHAZkG4bkhRhZKeoyGBZ5YcsArjFhrbjb67vBskOHng0B1qhSZB NJP1Ynb6BPs4kY36VZQNJWqwbZwI1XmJtwPjWdvT7pDq2YQ8PqYyt5ihRunlbt9rcEhikhHjU nN4yQXapOlQL0AjYkhIwxXG3DlNVmjBir+jbhVgSwAipCMAd2a/jdhU8F0j4G6+APCcLEQ8bH r6GyDAeKN5Wb3vn7ndgnsFwdaE7dpf9uHLb7A533cwo7+81BpPleB+mo7V5CGXeKn4RIfGjGh 0CkApiXt7b2wa2wAbydJYB2n2qf6QgNzodH1PG3GFWWhhQm0IiPohEh8l35FgRLzEuE3J/SVs JP1wJdYuKIS3WoLtUqBIFakigMtCo3IM/DLfLkhBZDu5nEeoIo9EesvS06nRkonmw57Q/3uWj cromMLSkUM7L49rO/Lgp+sZYKQ6rSykZ3IaalCx0mXM/QmtEYIAuChMFuEywEZMCUoGwhudJp +e6lFwO5cza1OSc6SSs8I7cWFR5xbg5xbB/yBHSlHdqDyvT1B+9/SEzzySDwmbbRcotbl5PIH Me1i1aouU4/boNB/zmpRTo9Vm/FBaN8pymRq5B/P8l1U2mXeqq+O9J8ilRCvjvDxoiiLkeCSL xrBXZ2kkHq5vl1sS+NBvOME/I/l0NeCTbemTiG3kRPAmDrqpKYSpIiMclYd/ueAf6qIbUbD6r X+D0L+Ri8ffYb+mV33TC/lYSTCzYVtufelGMMGugTA4Ie92JshbPFEAxPLs5GD9QQhgWbXyH X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:174819 Archived-At: On Tue, Jan 14 2020, Eric Abrahamsen wrote: > Jorge P. de Morais Neto writes: > > >> Besides, it seems that the function `org--tag-add-to-alist' does not >> exist on the Org Mode version (9.1 IIRC) that comes with Emacs 26.3. I >> think you should document that the Org Tags functionality depends on >> recent Org Mode. Also, maybe (I don't know if this would be worth your >> time) EBDB could provide a clear error message when the user attempts to >> use that functionality on an old Org Mode. Currently it lets Emacs >> complain that the symbol's value as a function is void. > > This is a bigger problem -- I'm committed to supporting Emacs 25. I > think I'll just write my own function (read: copy and paste Org's) to do > the same thing. > > Thanks, > Eric Hi Eric, It's a bad practice to duplicate functions from other packages. At least maybe you could enclose the definition in a (eval-after-load 'org ...) construct and provide org--tag-add-to-alist only if it is not defined. That way you will also be able to provide a message recommending an upgrade to a more recent org-mode. Deus